Re: PSA: No more mozilla::Move

2018-06-02 Thread Jean-Yves Avenard
> On 2 Jun 2018, at 3:45 pm, Jean-Yves Avenard wrote: >> >> Beware of some local mac builds maybe being broken. That should be fixed >> by bug 1270217 (thanks jwatt!). > > > FWIW, this breaks build with clang 6.0.0 on mac… > > such as: > 0:04.70 >

Re: PSA: No more mozilla::Move

2018-06-02 Thread Jean-Yves Avenard
> On 2 Jun 2018, at 9:56 am, Emilio Cobos Álvarez wrote: > > Hi, just a quick PSA: > > In bug 1465585 I switched all uses of mozilla::Move to std::move, and > removed the former. > > The reasoning for that is that it allows compilers to detect misuses of > std::move and warn about them

PSA: No more mozilla::Move

2018-06-02 Thread Emilio Cobos Álvarez
Hi, just a quick PSA: In bug 1465585 I switched all uses of mozilla::Move to std::move, and removed the former. The reasoning for that is that it allows compilers to detect misuses of std::move and warn about them (-Wpessimizing-move / -Wself-move / -Wreturn-std-move). Beware of some local mac