Re: Proposal: Require dangling commas for multiline objects/arrays on all Javascript mozilla-central code

On 22/08/2018 21:29, Mark Banner wrote: Since there are a large amount of instances (approx 12k) that would need to be fixed across the code base, I would propose that we roll it out on a per-directory basis. For example, we could do all of browser/ at the start of the 64 cycle just after

Re: Proposal: Require dangling commas for multiline objects/arrays on all Javascript mozilla-central code

On 22/08/2018 21:29, Mark Banner wrote: I would like to propose that we require dangling commas for multi-line object/arrays in Javascript code for mozilla-central. Strong +1 from me as well. I would propose that we roll it out on a per-directory basis. For example, we could do all of

Re: Proposal: Require dangling commas for multiline objects/arrays on all Javascript mozilla-central code

On Wed, Aug 22, 2018 at 09:29:26PM +0100, Mark Banner wrote: I would like to propose that we require dangling commas for multi-line object/arrays in Javascript code for mozilla-central. +1 I've lost count of the number of times I've hit an obscure failure because I added a new element to the

Proposal: Require dangling commas for multiline objects/arrays on all Javascript mozilla-central code

I would like to propose that we require dangling commas for multi-line object/arrays in Javascript code for mozilla-central. Why: * Multiple components in toolkit/ and browser/ already have comma-dangle enabled .