Re: Proposal for reorganizing test directories

2012-11-02 Thread Ms2ger
On 11/02/2012 01:47 AM, Dave Mandelin wrote: First, I want to try to pour some gasoline on the dying embers and suggest that perhaps we should totally rearrange everything. As a developer user of our testing systems, I always found it incredibly irritating that there were test directories

Re: Proposal for reorganizing test directories

2012-11-02 Thread Ehsan Akhgari
On 2012-11-01 8:47 PM, Dave Mandelin wrote: |-- tests/ |-- browser-chrome/ |-- topic1 (omit this level if there would be only one) |-- topic2 |-- [...] |-- chrome/ |-- crashtests/ |-- marionette/ |--

Re: Proposal for reorganizing test directories

2012-11-02 Thread Dave Mandelin
On Tuesday, October 30, 2012 7:26:34 AM UTC-7, Henrik Skupin wrote: As nearly all of you agreed on a flat folder structure makes a lot of sense if only one type of test is present. I second that, and we shouldn't make use of a 'tests' subfolder in such a case. But it would be fantastic if we

Re: Proposal for reorganizing test directories

2012-11-02 Thread Gregory Szorc
On 11/2/12 1:08 AM, Ms2ger wrote: On 11/02/2012 01:47 AM, Dave Mandelin wrote: First, I want to try to pour some gasoline on the dying embers and suggest that perhaps we should totally rearrange everything. As a developer user of our testing systems, I always found it incredibly irritating that

Re: Proposal for reorganizing test directories

2012-11-01 Thread Dave Mandelin
At the last Tuesday meeting I foolishly agreed :-) to take charge of following up on this discussion and seeing if we can come to a decision. So, here goes: First, I want to try to pour some gasoline on the dying embers and suggest that perhaps we should totally rearrange everything. As a

Re: Proposal for reorganizing test directories

2012-11-01 Thread Dave Mandelin
On Thursday, November 1, 2012 6:33:39 PM UTC-7, therealbr...@gmail.com wrote: On Thursday, November 1, 2012 5:47:57 PM UTC-7, Dave Mandelin wrote: At the last Tuesday meeting I foolishly agreed :-) to take charge of following up on this discussion and seeing if we can come to a decision.

Re: Proposal for reorganizing test directories

2012-11-01 Thread Robert O'Callahan
On Fri, Nov 2, 2012 at 2:53 PM, Dave Mandelin dmande...@gmail.com wrote: Sure, it's not some grand thing. I just like things to be nicely organized. And I really did find mochitest paths a hassle and a (small) tax on development effort. You could keep tests near the code and still have a

Re: Proposal for reorganizing test directories

2012-11-01 Thread Nicholas Nethercote
On Thu, Nov 1, 2012 at 6:33 PM, therealbrendane...@gmail.com wrote: The tyranny of hierarchy never ends. Either we have subsidiarity for js and other modules, or not. If Gecko is one big module -- ok, I get it. But you need a principle for giving js its own tests while hoisting all others.

Re: Proposal for reorganizing test directories

2012-10-30 Thread Karl Tomlinson
Henrik Skupin writes: differences like 'mochitest' vs. 'mochitests'. The right usage would be 'mochitest' and it would apply to the other frameworks too. It would be useful to have different names to distinguish between tests and implementation for the tests. I don't know whether that is an

Re: Proposal for reorganizing test directories

2012-10-26 Thread Gregory Szorc
On 10/26/12 2:48 AM, Gervase Markham wrote: On 25/10/12 14:48, Henrik Skupin wrote: When I started to work on tests for WebRTC and WebAPI lately I have noticed that there are no clear specifications where tests have to be added. Some are located in a tests subdirectory (like

Proposal for reorganizing test directories

2012-10-25 Thread Henrik Skupin
Hi all, When I started to work on tests for WebRTC and WebAPI lately I have noticed that there are no clear specifications where tests have to be added. Some are located in a tests subdirectory (like /dom/feature/tests/) while others are under a testing folder (like /dom/testing/mochitest). This

Re: Proposal for reorganizing test directories

2012-10-25 Thread Henrik Skupin
Justin Lebar wrote on 10/25/12 10:06 AM: I'd probably be a lot more sympathetic to this proposal if I understood in a concrete way how making my life a little harder here would make your life a little easier. What problem exactly are you trying to solve? Good points. So let me give one

Re: Proposal for reorganizing test directories

2012-10-25 Thread Boris Zbarsky
On 10/25/12 11:51 AM, Rob Campbell wrote: You won't have browser-chrome living next to xpcshell in the same location (pretty sure, please correct me if I'm wrong). http://mxr.mozilla.org/mozilla-central/source/docshell/test/ It's got xpcshell tests, xpcshell-ipc tests, browser tests,

Re: Proposal for reorganizing test directories

2012-10-25 Thread Justin Lebar
Ah, interesting. I think I misunderstood the main point of your proposal -- your purpose isn't to standardize the names of directories which contain tests much as to move tests closer in the directory structure to the code they're testing. Thanks for clarifying. So let me give one example. I

Re: Proposal for reorganizing test directories

2012-10-25 Thread Jason Duell
Why have those tests be placed into this location and not beside the actual implementation code? Necko has had a general policy of not allowing mochitests within the /netwerk tree, so any cookie, etc tests that need browser functionality (i.e. more than xpcshell) live elsewhere. It's really