Re: Proposal to adjust our clang-format rules to include spaces after the hash for nested preprocessor directives

I've received some on and off-list responses to this, all in favour. I've filed https://bugzilla.mozilla.org/show_bug.cgi?id=1521000 to make the change. Thanks to everyone who provided feedback. On Thu, Jan 10, 2019 at 8:01 PM Ehsan Akhgari wrote: > Hi everyone, > > I'd like to propose the fir

Re: Proposal to adjust our clang-format rules to include spaces after the hash for nested preprocessor directives

On 11/01/19 02:01, Ehsan Akhgari wrote: > The common way to deal with this problem is to indent nested preprocessor > directives, very much similarly to how we indent normal code, for example: > > #if foo > # if bar > #define x 1 > # else > #define x 2 > # endif > #endif this would be

Re: Proposal to adjust our clang-format rules to include spaces after the hash for nested preprocessor directives

On Thu, Jan 10, 2019 at 08:01:52PM -0500, Ehsan Akhgari wrote: The common way to deal with this problem is to indent nested preprocessor directives, very much similarly to how we indent normal code, for example: #if foo # if bar #define x 1 # else #define x 2 # endif #endif +1 This

Proposal to adjust our clang-format rules to include spaces after the hash for nested preprocessor directives

Hi everyone, I'd like to propose the first modification to our clang-format rules based on the feedback I've received since the switch to our new coding style from the SpiderMonkey team. The problem we're trying to solve is that in code that has nested preprocessor directives, when the directives