Re: NS_LITERAL_CSTRING

2015-05-17 Thread Neil
FYI The patch to make NS_LITERAL_CSTRING only work with string literals (and preprocessor macros that expand to string literals) has now been merged to mozilla-central. -- Warning: May contain traces of nuts. ___ dev-platform mailing list

Re: NS_LITERAL_CSTRING

2015-04-28 Thread Neil
Ehsan Akhgari wrote: On 2015-04-27 6:29 AM, Neil wrote: I found the following in-tree examples, none of which would have worked with NS_LITERAL_STRING: These are terrible! But what should we replace them with? 1. Change all of those static const char arrays back into #define 2.

Re: NS_LITERAL_CSTRING

2015-04-27 Thread Ehsan Akhgari
On 2015-04-27 6:29 AM, Neil wrote: NS_LITERAL_STRING, as its name suggests, only ever gets used on string literals, or macros that expand to string literals. NS_LITERAL_CSTRING gets (ab?)used in all sorts of ways. Should we be consistent and require NS_LITERAL_CSTRING to be used on string