Re: Resolving URLs in c++

2019-07-12 Thread Kris Maglione
On Thu, Jul 11, 2019 at 10:57:05PM -0700, mcace...@mozilla.com wrote: Was looking at how WebKit implements the WebShare API, and they have this nice method `completeURL(str)` [1] that resolved URLs relative to, I guess, the `Document` object (or whatever context is). So they can basically do

Re: Resolving URLs in c++

2019-07-12 Thread Anne van Kesteren
On Fri, Jul 12, 2019 at 9:05 AM Boris Zbarsky wrote: > You could simplify this a bit by calling > nsContentUtils::ewURIWithDocumentCharset, but that doesn't solve most of > the issue. >From the name that sounds somewhat wrong to me too. At least, for new APIs I think we should always use UTF-8

Re: Resolving URLs in c++

2019-07-12 Thread Boris Zbarsky
On 7/12/19 1:57 AM, mcace...@mozilla.com wrote: Do we have an equivalent in Gecko? No, but it would no be a bad idea to add something... Right now, in Gecko, I'm having to do this: Yeah, that's kinda ugly... rv = NS_NewURI(getter_AddRefs(resolvedUri), aData.mUrl.Value(), nullptr,