Re: intent to ship: drawFocusIfNeeded

2014-05-06 Thread Ian Hickson
On Tue, 6 May 2014, Robert O'Callahan wrote: On Tue, May 6, 2014 at 5:57 PM, Ian Hickson i...@hixie.ch wrote: Just so we're clear, I really don't care what the name is, nor do I have any objection to people having private conversations or whatnot. My point is just that there has not

Re: intent to ship: drawFocusIfNeeded

2014-05-05 Thread Ian Hickson
On Mon, 5 May 2014, Robert O'Callahan wrote: drawSystemFocusRing is a rather bad name since most calls to it will draw nothing. drawCustomFocusRing is an even worse name since it will draw nothing approximately always. drawFocusIfNeeded replaces drawSystemFocusRing, which is the method

Re: intent to ship: drawFocusIfNeeded

2014-05-05 Thread Robert O'Callahan
On Tue, May 6, 2014 at 8:13 AM, Ian Hickson i...@hixie.ch wrote: drawFocusIfNeeded() isn't a particularly good name either, since you're not drawing the focus, you're drawing the focus ring. In the old email thread, Jatinder Mann objected to using the term ring since the focus drawn might not

Re: intent to ship: drawFocusIfNeeded

2014-05-05 Thread Robert O'Callahan
On Tue, May 6, 2014 at 4:13 PM, Ian Hickson i...@hixie.ch wrote: On Tue, 6 May 2014, Robert O'Callahan wrote: We could probably come up with a slightly better name, but only very slightly better, so at this point I would rather not reopen the discussion. If someone else wants to, that's

Re: intent to ship: drawFocusIfNeeded

2014-05-05 Thread Rik Cabanier
On Mon, May 5, 2014 at 9:28 PM, Robert O'Callahan rob...@ocallahan.orgwrote: On Tue, May 6, 2014 at 4:13 PM, Ian Hickson i...@hixie.ch wrote: On Tue, 6 May 2014, Robert O'Callahan wrote: We could probably come up with a slightly better name, but only very slightly better, so at this point

Re: intent to ship: drawFocusIfNeeded

2014-05-05 Thread Robert O'Callahan
On Tue, May 6, 2014 at 4:44 PM, Rik Cabanier caban...@gmail.com wrote: FWIW the discussion was public. See http://lists.w3.org/Archives/Public/public-canvas-api/2014JanMar/0003.html Haha, OK, apology withdrawn :-). Thanks, Rob -- Jtehsauts tshaei dS,o n Wohfy Mdaon yhoaus

Re: intent to ship: drawFocusIfNeeded

2014-05-02 Thread Ehsan Akhgari
On Thu, May 1, 2014 at 4:10 PM, Rik Cabanier caban...@gmail.com wrote: On Thu, May 1, 2014 at 11:58 AM, Ehsan Akhgari ehsan.akhg...@gmail.comwrote: On 2014-05-01, 2:22 PM, Rik Cabanier wrote: On Thu, May 1, 2014 at 10:49 AM, Ehsan Akhgari ehsan.akhg...@gmail.com

Re: intent to ship: drawFocusIfNeeded

2014-05-01 Thread Anne van Kesteren
On Thu, May 1, 2014 at 1:44 AM, Rik Cabanier caban...@gmail.com wrote: [...] Pointer to the bug? Reason it's not in the WHATWG specification? -- http://annevankesteren.nl/ ___ dev-platform mailing list dev-platform@lists.mozilla.org

Re: intent to ship: drawFocusIfNeeded

2014-05-01 Thread Ehsan Akhgari
Hi Rik, How extensive is our testing of this feature? I'm very surprised that bug 1004499 was not caught by a test when you landed this. Cheers, Ehsan On 2014-04-30, 8:44 PM, Rik Cabanier wrote: Primary eng emails caban...@adobe.com *Spec*

Re: intent to ship: drawFocusIfNeeded

2014-05-01 Thread Ehsan Akhgari
Another question: Trevor had some concerns over this API in bug 958241. Were those concerns sufficiently addressed? Thanks! Ehsan On 2014-04-30, 8:44 PM, Rik Cabanier wrote: Primary eng emails caban...@adobe.com *Spec*

Re: intent to ship: drawFocusIfNeeded

2014-05-01 Thread Ian Hickson
On Thu, 1 May 2014, Rik Cabanier wrote: No particular reason. The spec text is identical; just the name of the method changed. Roc suggested the new name and people liked it better. I believe Ian stated that he would update the WHATWG version when there are 2 implementations. There's two

Re: intent to ship: drawFocusIfNeeded

2014-05-01 Thread Ehsan Akhgari
On 2014-05-01, 3:12 PM, Ian Hickson wrote: On Thu, 1 May 2014, Rik Cabanier wrote: No particular reason. The spec text is identical; just the name of the method changed. Roc suggested the new name and people liked it better. I believe Ian stated that he would update the WHATWG version when

Re: intent to ship: drawFocusIfNeeded

2014-05-01 Thread Rik Cabanier
On Thu, May 1, 2014 at 11:58 AM, Ehsan Akhgari ehsan.akhg...@gmail.comwrote: On 2014-05-01, 2:22 PM, Rik Cabanier wrote: On Thu, May 1, 2014 at 10:49 AM, Ehsan Akhgari ehsan.akhg...@gmail.com mailto:ehsan.akhg...@gmail.com wrote: Hi Rik, How extensive is our testing of this