Re: Searchfox (new code search tool)

2016-06-08 Thread Richard Z
On Mon, Jun 06, 2016 at 09:35:34PM -0700, Bill McCloskey wrote: > Hi everyone, > > I would like to announce a new tool I've been working on for source > code searching called Searchfox (http://searchfox.org). If you use MXR > or DXR, I recommend you try Searchfox. Here are some of the benefits:

Re: Searchfox (new code search tool)

2016-06-07 Thread Gregory Szorc
On Mon, Jun 6, 2016 at 9:35 PM, Bill McCloskey wrote: > Hi everyone, > > I would like to announce a new tool I've been working on for source > code searching called Searchfox (http://searchfox.org). If you use MXR > or DXR, I recommend you try Searchfox. Here are some of

Re: Searchfox (new code search tool)

2016-06-07 Thread Bill McCloskey
On Mon, Jun 6, 2016 at 10:18 PM, Mike Hommey wrote: > I'm going to sound negative, but why? Or more precisely, why not > contribute to DXR to add those features that you implemented in > searchfox that DXR doesn't have? > I started trying to contribute small changes to DXR,

Re: Searchfox (new code search tool)

2016-06-07 Thread Peter Elmers
As a DXR contributor, I'd like to point out it hasn't been sitting still recently either: xpidl (find definitions/jump to headers) and JavaScript (ported from Searchfox, in fact) support have landed and are just waiting a config change in the production builder to be live. C++ search,

Re: Searchfox (new code search tool)

2016-06-07 Thread Bobby Holley
Searchfox is the best thing ever. It made a huge difference in the speed and ease with which I can query the codebase and get the answers I need. My understanding is that Bill achieved a lot of the performance and correctness wins over dxr with different architectural choices, and by using Rust.

Re: Searchfox (new code search tool)

2016-06-07 Thread Andrew Halberstadt
On 07/06/16 01:18 AM, Mike Hommey wrote: I'm going to sound negative, but why? Or more precisely, why not contribute to DXR to add those features that you implemented in searchfox that DXR doesn't have? MXR is already taking too long to fade out of existence, do we really want yet another

Re: Searchfox (new code search tool)

2016-06-07 Thread Matthew N.
It's more due to lack of mxr-parity rather than usage that is delaying the MXR retirement. See the dependency tree: https://bugzilla.mozilla.org/showdependencytree.cgi?id=1097091_resolved=1 Matthew On Mon, Jun 6, 2016 at 11:23 PM, Sebastian Zartner < sebastianzart...@gmail.com> wrote: > On 7

Re: Searchfox (new code search tool)

2016-06-07 Thread smaug
On 06/07/2016 10:37 AM, Gabor Krizsanits wrote: Wow, this is amazing. Million thanks for this, especially for the speed, the easy blame walk and the highlight. I always wanted to have a tool for the traversing history like that. Indeed. So much better than what dxr/mxr gives, and finally I

Re: Searchfox (new code search tool)

2016-06-07 Thread Astley Chen
Agreed. As long as the tool helps and run faster, it is worth a try. I’m also hoping that most of functions only on DXR can be ported to Searchfox soon, for exp, “Jump to file”, “Jump to bugzilla”. For syntax highlighting, just found literal string color and comment color are switched, is there

Re: Searchfox (new code search tool)

2016-06-07 Thread Gabor Krizsanits
Wow, this is amazing. Million thanks for this, especially for the speed, the easy blame walk and the highlight. I always wanted to have a tool for the traversing history like that. One thing I miss is to see the revision number / contributor name on the side bar for each line on the sidebar in

Re: Searchfox (new code search tool)

2016-06-07 Thread Sebastian Zartner
On 7 June 2016 at 07:18, Mike Hommey wrote: > MXR is already taking too long to fade out of existence, do we really > want yet another different tool? For some contributors (like me) this may be, because they simply don't know that DXR is meant to replace MXR. If you want

Re: Searchfox (new code search tool)

2016-06-06 Thread Mike Hommey
On Mon, Jun 06, 2016 at 09:35:34PM -0700, Bill McCloskey wrote: > Hi everyone, > > I would like to announce a new tool I've been working on for source > code searching called Searchfox (http://searchfox.org). If you use MXR > or DXR, I recommend you try Searchfox. Here are some of the benefits: