Re: Shutdown hangs are very common

2015-07-07 Thread Georg Fritzsche
Can we fix the UX? Presumably we will never have zero shutdown hangs and there may be different/better ways to prompt the user about it. On Mon, Jul 6, 2015 at 10:48 PM, Vladan D vdje...@mozilla.com wrote: KaiRo pointed out another reason to reduce shutdown hang rates on IRC: it's lousy UX.

Re: Shutdown hangs are very common

2015-07-07 Thread jmathies
On Monday, July 6, 2015 at 3:52:39 PM UTC-5, Kyle Huey wrote: On Mon, Jul 6, 2015 at 1:37 PM, Ryan VanderMeulen rya...@gmail.com wrote: On 7/6/2015 4:34 PM, Vladan D wrote: Background: Firefox shutdown hangs are turned into shutdown crashes by a watchdog thread [1] that forces a crash

Re: Shutdown hangs are very common

2015-07-06 Thread Mike Conley
Should fixing shutdown hangs be higher priority? Starting and shutting down properly (and quickly), IMO, fall into the core quality / no compromise / we have to get this right bucket. So making it higher priority sounds aligned with the Three Pillars. And if so, should we allow features with

Re: Shutdown hangs are very common

2015-07-06 Thread Kyle Huey
On Mon, Jul 6, 2015 at 1:37 PM, Ryan VanderMeulen rya...@gmail.com wrote: On 7/6/2015 4:34 PM, Vladan D wrote: Background: Firefox shutdown hangs are turned into shutdown crashes by a watchdog thread [1] that forces a crash if shutdown hasn't completed within 1 minute. Thanks to the watchdog

Re: Shutdown hangs are very common

2015-07-06 Thread David Rajchenbach-Teller
On 06/07/15 22:48, Vladan D wrote: KaiRo pointed out another reason to reduce shutdown hang rates on IRC: it's lousy UX. The crash-reporter dialog pops up a minute after the user closed Firefox That's bug 1137941, but how would that reduce shutdown hangs? -- David Rajchenbach-Teller, PhD

Shutdown hangs are very common

2015-07-06 Thread Vladan D
Background: Firefox shutdown hangs are turned into shutdown crashes by a watchdog thread [1] that forces a crash if shutdown hasn't completed within 1 minute. Thanks to the watchdog and the Windows profile unlocker [2], shutdown hangs aren't as frustrating as they used to be. However, shutdown

Re: Shutdown hangs are very common

2015-07-06 Thread Ryan VanderMeulen
On 7/6/2015 4:34 PM, Vladan D wrote: Background: Firefox shutdown hangs are turned into shutdown crashes by a watchdog thread [1] that forces a crash if shutdown hasn't completed within 1 minute. Thanks to the watchdog and the Windows profile unlocker [2], shutdown hangs aren't as frustrating

Re: Shutdown hangs are very common

2015-07-06 Thread Vladan D
KaiRo pointed out another reason to reduce shutdown hang rates on IRC: it's lousy UX. The crash-reporter dialog pops up a minute after the user closed Firefox On Monday, July 6, 2015 at 4:37:41 PM UTC-4, RyanVM wrote: On 7/6/2015 4:34 PM, Vladan D wrote: Background: Firefox shutdown hangs

Re: Shutdown hangs are very common

2015-07-06 Thread Vladan D
On Monday, July 6, 2015 at 5:00:36 PM UTC-4, David Rajchenbach-Teller wrote: On 06/07/15 22:48, Vladan D wrote: KaiRo pointed out another reason to reduce shutdown hang rates on IRC: it's lousy UX. The crash-reporter dialog pops up a minute after the user closed Firefox That's bug

Re: Shutdown hangs are very common

2015-07-06 Thread David Major
Should fixing shutdown hangs be higher priority? And if so, should we allow features with shutdown hangs to be released? I admit to skimming over shutdown-hang signatures when looking at topcrash lists. In my experience they're often longstanding issues that are difficult to diagnose and

Re: Shutdown hangs are very common

2015-07-06 Thread Karl Tomlinson
Vladan D. writes: Should fixing shutdown hangs be higher priority? _exit() after profile-before-change notification would be the many-holes-with-one-plug bug to prioritize. https://wiki.mozilla.org/XPCOM_Shutdown https://bugzilla.mozilla.org/show_bug.cgi?id=662444

Re: Shutdown hangs are very common

2015-07-06 Thread Kyle Huey
On Mon, Jul 6, 2015 at 3:05 PM, Karl Tomlinson mozn...@karlt.net wrote: Vladan D. writes: Should fixing shutdown hangs be higher priority? _exit() after profile-before-change notification would be the many-holes-with-one-plug bug to prioritize. https://wiki.mozilla.org/XPCOM_Shutdown

Re: Shutdown hangs are very common

2015-07-06 Thread David Rajchenbach-Teller
Ah, right. On 06/07/15 23:05, Vladan D wrote: I think you misunderstood, I wasn't talking about the reducing the watchdog timeout :) I was saying that shutdown hangs result in bad Crash Reporter UX, so that is one more reason to *fix* shutdown hangs, i.e. reduce the shutdown hang rate by