Re: Use of C++11 std::unique_ptr for the WOFF2 module

2016-02-01 Thread Nathan Froyd
On Mon, Feb 1, 2016 at 4:29 AM, Frédéric Wang wrote: > I tried updating the source code of WOFF2 to the latest upstream > version. Unfortunately, try server builds fail on OSX and mobile devices > because the C++11 class std::unique_ptr does not seem to be available. > IIUC

Use of C++11 std::unique_ptr for the WOFF2 module

2016-02-01 Thread Frédéric Wang
Dear all, I'm trying to upgrade our local copy of OTS to version 5.0.0 [1]. OTS relies on the Brotli and WOFF2 libraries, whose source code we currently include in mozilla-cental. I tried updating the source code of WOFF2 to the latest upstream version. Unfortunately, try server builds fail on

Re: Use of C++11 std::unique_ptr for the WOFF2 module

2016-02-01 Thread Frédéric WANG
Le 01/02/2016 23:38, Nathan Froyd a écrit : > We're working on moving all of our platforms to use a C++11-ish > standard library. For std::unique_ptr, at least, the best tack is to > write a small polyfill based on mfbt/UniquePtr.h. (It's not clear to > me how your suggestion with std::vector

Re: Use of C++11 std::unique_ptr for the WOFF2 module

2016-02-01 Thread Ehsan Akhgari
On 2016-02-01 5:38 PM, Nathan Froyd wrote: On Mon, Feb 1, 2016 at 4:29 AM, Frédéric Wang wrote: I tried updating the source code of WOFF2 to the latest upstream version. Unfortunately, try server builds fail on OSX and mobile devices because the C++11 class std::unique_ptr

Re: Use of C++11 std::unique_ptr for the WOFF2 module

2016-02-01 Thread Ted Mielczarek
On Mon, Feb 1, 2016, at 04:29 AM, Frédéric Wang wrote: > Dear all, > > I'm trying to upgrade our local copy of OTS to version 5.0.0 [1]. OTS > relies on the Brotli and WOFF2 libraries, whose source code we currently > include in mozilla-cental. > > I tried updating the source code of WOFF2 to

Re: Use of C++11 std::unique_ptr for the WOFF2 module

2016-02-01 Thread Jeff Muizelaar
Lee Salzman came up with a hacky solution to this problem for the Skia update that he's working on. I haven't seen it yet, but apparently it builds. -Jeff On Mon, Feb 1, 2016 at 4:29 AM, Frédéric Wang wrote: > Dear all, > > I'm trying to upgrade our local copy of OTS to

Re: Use of C++11 std::unique_ptr for the WOFF2 module

2016-02-01 Thread Frédéric Wang
Le 01/02/2016 16:23, Ehsan Akhgari a écrit : > > Also the lack of libc++ on OSX makes this an issue there, which should > explain the OSX issue mentioned above. > Yes, I tried to follow what's done in build/clang-plugin/moz.build This allowed to compile the c++ files but linking failed. --

Re: Use of C++11 std::unique_ptr for the WOFF2 module

2016-02-01 Thread Ehsan Akhgari
On 2016-02-01 9:33 AM, Ted Mielczarek wrote: On Mon, Feb 1, 2016, at 04:29 AM, Frédéric Wang wrote: Dear all, I'm trying to upgrade our local copy of OTS to version 5.0.0 [1]. OTS relies on the Brotli and WOFF2 libraries, whose source code we currently include in mozilla-cental. I tried