Re: XPT files shouldn't be added to package-manifest.in any more

2018-04-18 Thread Boris Zbarsky
On 4/18/18 3:27 PM, Kris Maglione wrote: Legacy. The blocklist service is ancient, and has some C++ consumers. The JS-only parts wound up getting glommed onto the XPIDL interface over time. I'd already suggested we fix that before I realized it was the cause of this problem. OK. In that

Re: XPT files shouldn't be added to package-manifest.in any more

2018-04-18 Thread Kris Maglione
On Wed, Apr 18, 2018 at 03:15:23PM -0400, Boris Zbarsky wrote: On 4/18/18 1:54 PM, Gijs Kruitbosch wrote: Given that we're also not supposed to be making new JS-implemented webidl things, what's the long-term plan for artifact build support for changing JS-implemented interfaces? For the

Re: XPT files shouldn't be added to package-manifest.in any more

2018-04-18 Thread Boris Zbarsky
On 4/18/18 1:54 PM, Gijs Kruitbosch wrote: Err, so it seems a side-effect of this (which wasn't very obvious to me when this was posted) is that it's now no longer possible to change a ..idl file for a JS component in an artifact build and have it "work". So to be clear, this is a case in

Re: XPT files shouldn't be added to package-manifest.in any more

2018-04-18 Thread Gijs Kruitbosch
Err, so it seems a side-effect of this (which wasn't very obvious to me when this was posted) is that it's now no longer possible to change a .idl file for a JS component in an artifact build and have it "work". Specifically, I ran into this when changing the return type of an extant idl

XPT files shouldn't be added to package-manifest.in any more

2018-04-05 Thread Andrew McCreight
I recently landed bug 1438688, which makes it so that we don't ship XPT files any more, so they don't need to be added to a package-manifest.in file. (Instead, the XPT information is compiled into the binary.) I think it'll give you an error if you add it anyways, but I haven't tested it. We still