Re: mozilla::RefPtr is dead, long live ::RefPtr

2015-10-18 Thread Kyle Huey
Huzzah! When are you going to do nsCOMPtr? ;) - Kyle On Sun, Oct 18, 2015 at 7:43 AM, Nathan Froyd wrote: > Hi all, > > Bug 1207245 has landed on mozilla-central. Its main purpose in life is to > unify mozilla::RefPtr and nsRefPtr (both of which live in MFBT) into a >

Re: mozilla::RefPtr is dead, long live ::RefPtr

2015-10-18 Thread Boris Zbarsky
On 10/18/15 10:43 AM, Nathan Froyd wrote: Bug 1207245 has landed on mozilla-central. Are we sure enough this will stick that we should update documentation (e.g. ) to refer to RefPtr instead of nsRefPtr? -Boris

mozilla::RefPtr is dead, long live ::RefPtr

2015-10-18 Thread Nathan Froyd
Hi all, Bug 1207245 has landed on mozilla-central. Its main purpose in life is to unify mozilla::RefPtr and nsRefPtr (both of which live in MFBT) into a single RefPtr class. This new RefPtr class, like nsRefPtr, lives at the *global* scope, not in the mozilla:: namespace. Follow-up patches or

Re: mozilla::RefPtr is dead, long live ::RefPtr

2015-10-18 Thread Boris Zbarsky
On 10/18/15 11:11 AM, Kyle Huey wrote: When are you going to do nsCOMPtr? ;) Are we sure there is no codesize hit when moving from nsCOMPtr (which tries to share implementation via nsCOMPtr_base) to RefPtr? -Boris ___ dev-platform mailing list

Re: mozilla::RefPtr is dead, long live ::RefPtr

2015-10-18 Thread Kyle Huey
I meant removing the ns prefix (i.e. s/nsCOMPtr/COMPtr/), which is the net effect of this change for places that previous used nsRefPtr, AIUI. - Kyle On Sun, Oct 18, 2015 at 8:24 AM, Boris Zbarsky wrote: > On 10/18/15 11:11 AM, Kyle Huey wrote: >> >> When are you going to do