Re: redundant(?) code churn and code style issues in bug 525063

I come with a followup on this matter, we’ve backed out the issues. Now the tree should be OK. Please see: https://hg.mozilla.org/mozilla-central/rev/8a94faa5cc60495da5d80d4b3c07bf5877d2e6d8 Thanks, ANdi > O

Re: redundant(?) code churn and code style issues in bug 525063

Hello all, Right now we are working on backing out the changes the caused this. I will keep you posted when this is done. P.S it should be done very shortly. > On 13 Apr 2018, at 15:48, Nathan Froyd wrote: > > we're signature.asc Description: Message signed with OpenPGP __

Re: redundant(?) code churn and code style issues in bug 525063

FWIW, all these complaints (and more) have been raised in the bug. I'm not entirely sure what we're going to do yet, but rest assured that people are definitely aware of the issues. Thanks, -Nathan On Fri, Apr 13, 2018 at 8:31 AM, Kartikaya Gupta wrote: > On Fri, Apr 13, 2018 at 6:18 AM, Jonatha

Re: redundant(?) code churn and code style issues in bug 525063

On Fri, Apr 13, 2018 at 6:18 AM, Jonathan Kew wrote: > It's presumably auto-generated by a static-analysis tool or something like > that, but ISTM it has been overly aggressive, adding a lot more code churn > than necessary (as well as committing some pretty extreme style violations > such as over

redundant(?) code churn and code style issues in bug 525063

The huge patch that recently hit mozilla-central in bug 525063 makes me a bit sad. Did we really need to do this? On this scale? It's presumably auto-generated by a static-analysis tool or something like that, but ISTM it has been overly aggressive, adding a lot more code churn than necessary