Re: Coming in Firefox 65: Dedicated Profiles Per Install and Profile Downgrade Protection

[Tom Ritter]

On Fri, Oct 19, 2018 at 3:43 PM Dave Townsend  wrote:
> On Fri, Oct 19, 2018 at 6:31 AM Tom Ritter  wrote:
>> > On Thu, Oct 18, 2018 at 3:32 PM Dave Townsend  
>> > wrote:
>> > > For cases where users manually downgrade an install of Firefox or attempt
>> > > to forcefully use an older version of Firefox with a newer profile the
>> > > profile downgrade protection feature will now tell the user that the
>> > > profile is too new to use with this Firefox giving them the option to
>> > > create a new profile to use or to quit.
>>
>>
>> If you have multiple channels installed, and have them all start with
>> -P for profile selection, it seems like this downgrade protection
>> mechanism might trigger if you select the wrong profile for the
>> channel you started. That would lead to confusion.
>
>
> Well one benefit of these changes is that you wouldn't need to run with -P 
> any longer, each installed channel will be able to have its own default 
> profile. And throwing a warning when you try to open your nightly profile 
> with beta is definitely intended.

Well, if all you're using -P for is to separate profiles-by-channels,
then yea you can get rid of it, but one might have multiple
profiles/per channel.

(And yea, the warning in that case is definitely intended.)

>> Maybe we could detect if the user started with -P, and if so change
>> the error message to intelligently guide the user in that case?
>
> Guide them in what way?

Instead of saying "The profile is too new to use with this Firefox.
Create a new profile or Quit" maybe something like "The profile is too
new to use with this Firefox. Restart and choose a different profile
or Create a new profile"

-tom
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Coming in Firefox 65: Dedicated Profiles Per Install and Profile Downgrade Protection

[bruno ais]

>
> The old profile is not deleted though.
>
Ok, thanks.That's what I wanted to confirm.

On Fri, Oct 19, 2018 at 6:05 PM Dave Townsend  wrote:

> The new profile will be clean and empty. Since we know the previous
> profile is from a newer version of Firefox there isn't a way to copy its
> data without running the same risks as current downgrades. Users can use
> Firefox Sync if they want to share data between profiles. The old profile
> is not deleted though.
>
> On Fri, Oct 19, 2018 at 10:02 AM bruno ais  wrote:
>
>> When creating a new profile to accomodate the downgrade, is the previous
>> data deleted? Are there options to keep the old profile for just in case or
>> selecting to use a new profile cleans the old one completely?
>>
>> On Fri, Oct 19, 2018 at 2:43 PM mhoye  wrote:
>>
>>>
>>>
>>> -- Original Message --
>>> From: "Dave Townsend" 
>>> To: "dev-platform" ; "Firefox Dev" <
>>> firefox-...@mozilla.org>
>>> Sent: 2018-10-18 3:32:36 PM
>>> Subject: Coming in Firefox 65: Dedicated Profiles Per Install and
>>> Profile Downgrade Protection
>>>
>>> In Firefox 65 we intend to ship two new features to help prevent user
>>> frustration caused by using profiles created by newer versions of Firefox.
>>>
>>>
>>> This has been a serious problem from a community participation
>>> perspective for a while now. Making it safe and easy to flip back and forth
>>> between versions of Firefox will make casual participation in testing and
>>> QA, among many other things, hugely easier and more accessible; I'm quite
>>> grateful that we're doing this work.
>>>
>>>
>>> - mhoye
>>> ___
>>> firefox-dev mailing list
>>> firefox-...@mozilla.org
>>> https://mail.mozilla.org/listinfo/firefox-dev
>>>
>>
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Coming in Firefox 65: Dedicated Profiles Per Install and Profile Downgrade Protection

[Dave Townsend]

The new profile will be clean and empty. Since we know the previous profile
is from a newer version of Firefox there isn't a way to copy its data
without running the same risks as current downgrades. Users can use Firefox
Sync if they want to share data between profiles. The old profile is not
deleted though.

On Fri, Oct 19, 2018 at 10:02 AM bruno ais  wrote:

> When creating a new profile to accomodate the downgrade, is the previous
> data deleted? Are there options to keep the old profile for just in case or
> selecting to use a new profile cleans the old one completely?
>
> On Fri, Oct 19, 2018 at 2:43 PM mhoye  wrote:
>
>>
>>
>> -- Original Message --
>> From: "Dave Townsend" 
>> To: "dev-platform" ; "Firefox Dev" <
>> firefox-...@mozilla.org>
>> Sent: 2018-10-18 3:32:36 PM
>> Subject: Coming in Firefox 65: Dedicated Profiles Per Install and Profile
>> Downgrade Protection
>>
>> In Firefox 65 we intend to ship two new features to help prevent user
>> frustration caused by using profiles created by newer versions of Firefox.
>>
>>
>> This has been a serious problem from a community participation
>> perspective for a while now. Making it safe and easy to flip back and forth
>> between versions of Firefox will make casual participation in testing and
>> QA, among many other things, hugely easier and more accessible; I'm quite
>> grateful that we're doing this work.
>>
>>
>> - mhoye
>> ___
>> firefox-dev mailing list
>> firefox-...@mozilla.org
>> https://mail.mozilla.org/listinfo/firefox-dev
>>
>
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Coming in Firefox 65: Dedicated Profiles Per Install and Profile Downgrade Protection

[bruno ais]

When creating a new profile to accomodate the downgrade, is the previous
data deleted? Are there options to keep the old profile for just in case or
selecting to use a new profile cleans the old one completely?

On Fri, Oct 19, 2018 at 2:43 PM mhoye  wrote:

>
>
> -- Original Message --
> From: "Dave Townsend" 
> To: "dev-platform" ; "Firefox Dev" <
> firefox-...@mozilla.org>
> Sent: 2018-10-18 3:32:36 PM
> Subject: Coming in Firefox 65: Dedicated Profiles Per Install and Profile
> Downgrade Protection
>
> In Firefox 65 we intend to ship two new features to help prevent user
> frustration caused by using profiles created by newer versions of Firefox.
>
>
> This has been a serious problem from a community participation perspective
> for a while now. Making it safe and easy to flip back and forth between
> versions of Firefox will make casual participation in testing and QA, among
> many other things, hugely easier and more accessible; I'm quite grateful
> that we're doing this work.
>
>
> - mhoye
> ___
> firefox-dev mailing list
> firefox-...@mozilla.org
> https://mail.mozilla.org/listinfo/firefox-dev
>
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: web-platform-tests that fail only in Firefox (from wpt.fyi data)

[Boris Zbarsky]

On 10/19/18 8:42 AM, Philip Jägenstedt wrote:

That's a bit odd, the  is in the markup and would be
when running manually or under automation. Are you sure that explains
the difference?


Yes.  I filed https://github.com/web-platform-tests/wpt/issues/13625

-Boris

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Coming in Firefox 65: Dedicated Profiles Per Install and Profile Downgrade Protection

[Dave Townsend]

On Fri, Oct 19, 2018 at 6:31 AM Tom Ritter  wrote:

> Awesome!
>
> > On Thu, Oct 18, 2018 at 3:32 PM Dave Townsend 
> wrote:
> > > For cases where users manually downgrade an install of Firefox or
> attempt
> > > to forcefully use an older version of Firefox with a newer profile the
> > > profile downgrade protection feature will now tell the user that the
> > > profile is too new to use with this Firefox giving them the option to
> > > create a new profile to use or to quit.
>
>
> If you have multiple channels installed, and have them all start with
> -P for profile selection, it seems like this downgrade protection
> mechanism might trigger if you select the wrong profile for the
> channel you started. That would lead to confusion.
>

Well one benefit of these changes is that you wouldn't need to run with -P
any longer, each installed channel will be able to have its own default
profile. And throwing a warning when you try to open your nightly profile
with beta is definitely intended.


> Maybe we could detect if the user started with -P, and if so change
> the error message to intelligently guide the user in that case?
>

Guide them in what way?
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: PSA: Dangling Commas landing part 2 - 20th Oct

[Mark Banner]

On 03/10/2018 15:45, Mark Banner wrote:


Following the successful enabling of the ESLint comma-dangle rule for 
some of our javascript files, I am intending on enabling it for the 
rest on Friday 20th October.



...
Bug 1486741  is 
the tracking bug for this, and there's a try push 
 
from earlier today with the first version of the patches. 


This has now landed on autoland.

Mark.

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Coming in Firefox 65: Dedicated Profiles Per Install and Profile Downgrade Protection

[mhoye]

-- Original Message --
From: "Dave Townsend" 
To: "dev-platform" ; "Firefox Dev" 


Sent: 2018-10-18 3:32:36 PM
Subject: Coming in Firefox 65: Dedicated Profiles Per Install and 
Profile Downgrade Protection


In Firefox 65 we intend to ship two new features to help prevent user 
frustration caused by using profiles created by newer versions of 
Firefox.


This has been a serious problem from a community participation 
perspective for a while now. Making it safe and easy to flip back and 
forth between versions of Firefox will make casual participation in 
testing and QA, among many other things, hugely easier and more 
accessible; I'm quite grateful that we're doing this work.



- mhoye
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Coming in Firefox 65: Dedicated Profiles Per Install and Profile Downgrade Protection

[Tom Ritter]

Awesome!

> On Thu, Oct 18, 2018 at 3:32 PM Dave Townsend  wrote:
> > For cases where users manually downgrade an install of Firefox or attempt
> > to forcefully use an older version of Firefox with a newer profile the
> > profile downgrade protection feature will now tell the user that the
> > profile is too new to use with this Firefox giving them the option to
> > create a new profile to use or to quit.


If you have multiple channels installed, and have them all start with
-P for profile selection, it seems like this downgrade protection
mechanism might trigger if you select the wrong profile for the
channel you started. That would lead to confusion.

Maybe we could detect if the user started with -P, and if so change
the error message to intelligently guide the user in that case?

-tom
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: web-platform-tests that fail only in Firefox (from wpt.fyi data)

[Philip Jägenstedt]

On Wed, Oct 17, 2018 at 11:53 PM Boris Zbarsky  wrote:
>
> On 10/13/18 3:27 AM, Philip Jägenstedt wrote:
> > Fiddling with these rules can reveal lots
> > more potential issues, and if you like I could provide reports on that too.
>
> I would be pretty interested in that, yes.  In particular, a report
> where there is 1 "not PASS and not FAIL" and 3 "PASS" would be pretty
> helpful, I suspect.

Rerunning my script it's apparent that unreliable Edge results [1]
leads to the same tests being considered lone failures or not for the
other browsers. So, I've use the same set of runs for this report of
what you suggested:
https://gist.github.com/foolip/e6014c9bcc8ca405219bf18542eb5d69

It's not a long list, so I checked them all and they are timeouts.
This is sometimes the failure mode for genuine problems, so looking
over these might be valuable.

> By the way, I recently found some tests that fail when run directly but
> pass in the harness.  :(  For example
> http://w3c-test.org/html/infrastructure/common-dom-interfaces/collections/htmlallcollection.html
> fails various subtests in all browsers due to the  being
> in the DOM when running directly.  Not really sure what we can do with that.

That's a bit odd, the  is in the markup and would be
when running manually or under automation. Are you sure that explains
the difference? If it does, then just removing it from the markup and
adapting any affected tests would be the way to go. I updated the test
pretty recently, if you're confident it's broken can you file a wpt
issue and assign me?

[1] https://github.com/web-platform-tests/results-collection/issues/563
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform