Re: On builds getting slower

2013-08-03 Thread Mike Hommey
On Sat, Aug 03, 2013 at 01:36:15PM +1000, Nicholas Nethercote wrote: (...) Even worse, link times are through the roof. I was thrilled when, two years ago, I switched from ld to gold and linking time plummeted. The first link after rebooting was always slow, but I could link libxul back then

Re: On builds getting slower

2013-08-03 Thread Nicholas Nethercote
On Sat, Aug 3, 2013 at 5:47 PM, Mike Hommey m...@glandium.org wrote: One piece of the puzzle, at least in Mozilla code, is the tendency to #include Foo.h when class Bar contains a field of type Foo*, instead of leaving the include to Bar.cpp and forward declare in Bar.h. This certainly

Re: On indirect feedback

2013-08-03 Thread Robert O'Callahan
On Sat, Aug 3, 2013 at 12:43 PM, Brian Smith br...@briansmith.org wrote: I think some people may interpret what you say in that last paragraph the opposite of how you intend. I am pretty sure you mean something like If somebody starts to complain to you about somebody else, then stop them and

Re: On builds getting slower

2013-08-03 Thread Mike Hommey
On Sat, Aug 03, 2013 at 04:47:29PM +0900, Mike Hommey wrote: On Sat, Aug 03, 2013 at 01:36:15PM +1000, Nicholas Nethercote wrote: (...) Even worse, link times are through the roof. I was thrilled when, two years ago, I switched from ld to gold and linking time plummeted. The first link

nsIDownloadManager replaced by Downloads.jsm

2013-08-03 Thread Paolo Amadini
Hello, if you are maintaining an add-on or a Mozilla product that interacts with downloads, you should look into updating your code to use the new Downloads.jsm module instead of nsIDownloadManager as soon as possible. While other Mozilla products may migrate at different times, Firefox for

Re: Removing support for OS/2

2013-08-03 Thread Peter Weilbacher
Hi Gregory et al., On Fri, 2 Aug 2013, Mike Hommey wrote: CCing the last two persons who submitted patches for OS/2 On Thu, Aug 01, 2013 at 04:13:23PM -0700, Gregory Szorc wrote: We have a number of references to OS/2 throughout the build system and source tree. According to Kyle Huey

Re: nsIDownloadManager replaced by Downloads.jsm

2013-08-03 Thread Neil
Paolo Amadini wrote: The complete documentation of the module can be found here: https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Downloads.jsm ... plus you'll need all the subpages for the other objects of course. Do I have to watch the download lists globally in order to

Re: Removing support for OS/2

2013-08-03 Thread Cameron Kaiser
On 8/3/13 8:11 AM, Peter Weilbacher wrote: We have a number of references to OS/2 throughout the build system and source tree. According to Kyle Huey OS/2 has likely broken since we removed --disable-ipc (bug 638755) in March 2011. While OS/2 is a tier-3 supported build configuration [1], we

Re: nsIDownloadManager replaced by Downloads.jsm

2013-08-03 Thread Neil
Paolo Amadini wrote: On 03/08/2013 17.26, Neil wrote: Do I have to watch the download lists globally in order to find out about new downloads (e.g. from content-disposition: attachment)? Yes, you should add a view to the public and private download lists. So nsIDownloadManagerUI

Re: reminder: content processes (e10s) are now used by desktop Firefox

2013-08-03 Thread Mark Hammond
On 3/08/2013 5:30 AM, Philip Chee wrote: On 02/08/2013 16:57, t...@adblockplus.org wrote: The code in question was explicitly running in Firefox Mobile only. It used messageManager.loadFrameScript() API to inject code into the content process of new tabs - I doubt that it will work the same