Re: Just Autoland It

2016-01-26 Thread cbook
Note that we have problems on the tree due to https://bugzilla.mozilla.org/show_bug.cgi?id=1243276 - to avoid more problems from broken autolander landings we will set the trees to approval-only to avoid incomplete landings from autolander. - Tomcat

Re: Just Autoland It

2016-01-26 Thread Karl Tomlinson
>> On 25/01/16 05:44 PM, Eric Rescorla wrote: >> >On Mon, Jan 25, 2016 at 1:58 PM, Mike Hommey wrote: >> > >> >>It's also painful to use MozReview's comment system. The comments in the >> >>reviews pane don't show much diff context, and while I just realized >> >>it's possible to make it show more

Re: Just Autoland It

2016-01-26 Thread Karl Tomlinson
Mike Hommey writes: > On Mon, Jan 25, 2016 at 11:23:59AM -0800, Steve Fink wrote: >> Heh. Your list of UI complaints is very similar to mine. Some comments: >> >> >> On 01/25/2016 04:26 AM, Honza Bambas wrote: > Also, iirc, when you reply diff comments in MozReview, the resulting > comments sent

Re: Just Autoland It

2016-01-26 Thread Karl Tomlinson
On Fri, 22 Jan 2016 14:24:38 -0500, Ehsan Akhgari wrote: > What about the case where the information doesn't exist in the > repository because the author, for example, cherry-picked a > specific commit on a throw-away branch because the rest of the > dependencies are still being worked on? Or, as

Re: Just Autoland It

2016-01-26 Thread Karl Tomlinson
Boris Zbarsky writes: > On 1/23/16 9:48 PM, Mike Hommey wrote: >> Note that if /other/ changes from other bugs have happened to the same >> files between the last reviewed iteration and the rebase before landing, >> the interdiff will show them without any kind of visual cues. > > Ah, that's unfor

Re: e10s tests

2016-01-26 Thread neil
On Tuesday, January 5, 2016 at 2:38:30 PM UTC-5, Felipe G wrote: > (cross-posted to fx-dev and dev.platform) > > As we drive towards shipping e10s, we are working on making sure that our > tests work with e10s. As you already know, there's a number of tests that > are disabled from running on e10s

Re: Moving FirefoxOS into Tier 3 support

2016-01-26 Thread Andrew Halberstadt
Hi, I'm on the engineering productivity team, and work a lot on continuous integration and test harnesses. I stood up initial Gecko unittests on B2G emulator, worked on B2G automation for several years up until the divide, and still help nominally maintain the emulator and mulet unittests. So that

Re: Moving FirefoxOS into Tier 3 support

2016-01-26 Thread Adam Farden
If we jump on the Marshmallow bandwagon we can drop stlport, Google already did that too. https://bugzilla.mozilla.org/show_bug.cgi?id=1213259 https://bugzilla.mozilla.org/show_bug.cgi?id=1218802 - specifically patch [07] On Mon, Jan 25, 2016 at 6:34 PM, Nathan Froyd wrote: > On Mon, Jan 25, 2

Re: Just Autoland It

2016-01-26 Thread Honza Bambas
On 1/26/2016 16:46, Benjamin Smedberg wrote: On 1/26/2016 10:26 AM, Boris Zbarsky wrote: On 1/26/16 7:38 AM, Axel Hecht wrote: Which is basically what I do whenever I want to do something. I have a clear idea and intention on what I want to show up on bugzilla, but not on what to do on review

Re: Just Autoland It

2016-01-26 Thread Mike Conley
FWIW, adding r- abilities is bug 1197879[1]. There's a prototype patch that adds the UI, but I believe the MozReview team was still trying to sort out the best terminology to use. [1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1197879 On 26/01/2016 10:46 AM, Benjamin Smedberg wrote: > > > On

Re: Just Autoland It

2016-01-26 Thread Benjamin Smedberg
On 1/26/2016 10:26 AM, Boris Zbarsky wrote: On 1/26/16 7:38 AM, Axel Hecht wrote: Which is basically what I do whenever I want to do something. I have a clear idea and intention on what I want to show up on bugzilla, but not on what to do on reviewboard to get there. Which might just be a cate

Re: Just Autoland It

2016-01-26 Thread Boris Zbarsky
On 1/26/16 7:38 AM, Axel Hecht wrote: Which is basically what I do whenever I want to do something. I have a clear idea and intention on what I want to show up on bugzilla, but not on what to do on reviewboard to get there. Which might just be a category of documentation that's not written yet.

Re: Just Autoland It

2016-01-26 Thread Axel Hecht
Piling on: I'm using mozreview mostly as an occasional patch author: Plus, I can schedule a try build. Minus, I need to bother the reviewer with a published request in order to do so. Resorted to add yet another hg extension to my local .hg/hgrc. My most frequent concern is that bugzilla and

Re: Moving FirefoxOS into Tier 3 support

2016-01-26 Thread Gabriele Svelto
On 26/01/2016 10:51, jma...@mozilla.com wrote: > I would assume all gecko patches would get landed on either mozilla-inbound > or fx-team. If you use mozreview and take advantage of the autoland feature, > then these specific patches will land on mozilla-inbound. Thanks, I'll definitely have a

Re: Moving FirefoxOS into Tier 3 support

2016-01-26 Thread jmaher
> Same here. I'm now unable to land the gecko dependencies for bug 1227980 > [1] and that's annoying to say the least considering it took a month to > write and test that thing (not even mentioning the time spent by the > many reviewers and QA people involved). What are we supposed to do with > tho

Re: Moving FirefoxOS into Tier 3 support

2016-01-26 Thread Gabriele Svelto
On 26/01/2016 10:19, Shawn Huang wrote: > Hi Fabrice, > Following this comment, I'm confused. Do we need to check-in into > b2g-inbound by hand? "checked-in" keyboard no longer supports FirefoxOS > project? Does this mean only people who have Level 3 access permission can > land code? Same here. I

Re: Moving FirefoxOS into Tier 3 support

2016-01-26 Thread Shawn Huang
Hi Fabrice, Following this comment, I'm confused. Do we need to check-in into b2g-inbound by hand? "checked-in" keyboard no longer supports FirefoxOS project? Does this mean only people who have Level 3 access permission can land code? https://bugzilla.mozilla.org/show_bug.cgi?id=1201778#c102 "d