Re: Is there a way to improve partial compilation times?

2017-03-08 Thread Wei-Cheng Pan
On 08/03/2017 10:24 PM, Ehsan Akhgari wrote: > On 2017-03-08 6:40 AM, James Graham wrote: >> On 08/03/17 11:11, Frederik Braun wrote: >>> On 08.03.2017 01:17, Ralph Giles wrote: I second Jeff's point about building with icecream[1]. If you work in an office with a build farm, or near a

Re: Project Stockwell (reducing intermittents) - March 2017 update

2017-03-08 Thread Karl Tomlinson
I would like to see failure rates expressed as a ratio of failures to test runs, but I recognise that this data may not be readily available and getting it may not be that important if we have a rough idea. These are a means for setting priorities, and so a rank works well. If we have 100 tests,

Re: Project Stockwell (reducing intermittents) - March 2017 update

2017-03-08 Thread L. David Baron
On Wednesday 2017-03-08 17:15 -0500, Kartikaya Gupta wrote: > On Wed, Mar 8, 2017 at 4:01 PM, wrote: > > In the past I have not always been made aware when my tests were disabled, > > which has lead to me feeling jaded. > > We have a process (in theory) that

Re: Revocation protocol idea

2017-03-08 Thread Jonathan Kingston
Hey, What would be the advantage of using this over the safesite list? Obviously there would be less broken sites on the web as we would be permitting the site to still be viewed by the user rather than just revoking the permission but are there other advantages? On Sun, Mar 5, 2017 at 4:23 PM,

Re: Project Stockwell (reducing intermittents) - March 2017 update

2017-03-08 Thread Kartikaya Gupta
On Wed, Mar 8, 2017 at 4:01 PM, wrote: > In the past I have not always been made aware when my tests were disabled, > which has lead to me feeling jaded. We have a process (in theory) that ensures the relevant people get notified of tests. The process involves

Re: Intent to ship: WebVR on Windows in Release

2017-03-08 Thread bajones
Hi all! I'm a spec editor for WebVR and implementer on Chrome. Wanted to chime in on a few points. Boris: Thanks for the spec bugs you've filed and the concern about improving the spec language to ensure consistent implementations between browsers. The type of issues you have brought up are

Re: Is there a way to improve partial compilation times?

2017-03-08 Thread Steve Fink
On 03/08/2017 06:21 AM, Ehsan Akhgari wrote: On 2017-03-07 2:49 PM, Eric Rahm wrote: I often wonder if unified builds are making things slower for folks who use ccache (I assume one file changing would mean a rebuild for the entire unified chunk), I'm not sure if there's a solution to that but

Re: Is there a way to improve partial compilation times?

2017-03-08 Thread zbraniecki
On Wednesday, March 8, 2017 at 8:57:57 AM UTC-8, James Graham wrote: > On 08/03/17 14:21, Ehsan Akhgari wrote: > At risk of stating the obvious, if you aren't touching C++ code (or > maybe jsm?), and aren't using any funky compile options, you should be > using an artifact build for best

Re: Project Stockwell (reducing intermittents) - March 2017 update

2017-03-08 Thread chris . ryan . pearce
On Wednesday, March 8, 2017 at 11:18:03 PM UTC+13, jma...@mozilla.com wrote: > On Tuesday, March 7, 2017 at 11:45:38 PM UTC-5, Chris Pearce wrote: > > I recommend that instead of classifying intermittents as tests which fail > > > 30 times per week, to instead classify tests that fail more than

Re: Startup JS debugging (sometimes) possible via Browser Toolbox

2017-03-08 Thread Jared Wein
This is very useful! Thank you for adding this! On Wed, Mar 8, 2017 at 2:11 PM, Dave Townsend wrote: > This is awesome, thanks for implementing this! > > On Wed, Mar 8, 2017 at 11:09 AM, J. Ryan Stinnett > wrote: > >> With bug 1275942 in Firefox 55, a

Re: Is there a way to improve partial compilation times?

2017-03-08 Thread James Graham
On 08/03/17 14:21, Ehsan Akhgari wrote: On 2017-03-07 2:49 PM, Eric Rahm wrote: I often wonder if unified builds are making things slower for folks who use ccache (I assume one file changing would mean a rebuild for the entire unified chunk), I'm not sure if there's a solution to that but it

Re: Is there a way to improve partial compilation times?

2017-03-08 Thread Simon Sapin
On 08/03/17 15:24, Ehsan Akhgari wrote: What we did in the Toronto office was walked to people who ran Linux on their desktop machines and installed the icecream server on their computer. I suggest you do the same in London. There is no need to wait for dedicated build machines. ;-) We’ve

New ErrorResult::Throw Static Analysis

2017-03-08 Thread Michael Layzell
Bug 1331434 is on inbound, and it adds a new static analysis and an attribute called MOZ_MUST_RETURN_FROM_CALLER. This attribute is currently attached to ErrorResult::Throw. This analysis is intended to help catch buggy code which performs logic like: if (!foo) {

Re: Is there a way to improve partial compilation times?

2017-03-08 Thread Frederik Braun
Gotcha. Problem for the Berlin office: There are only 3 people who have a desktop and run linux. Two of them are part of our "cluster" :) ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Heads Up: /storage upgraded from version 1.0 to 2.0

2017-03-08 Thread Ehsan Akhgari
On 2017-03-07 8:02 PM, Ben Kelly wrote: > On Tue, Mar 7, 2017 at 6:09 PM, Xidorn Quan wrote: > >>> This major version change is downgrade-incompatible, so IndexedDB and >>> DOM cache won't work in an older version if their profile has been >>> upgraded. >>> IndexedDB is also

Re: Is there a way to improve partial compilation times?

2017-03-08 Thread Ehsan Akhgari
On 2017-03-08 6:40 AM, James Graham wrote: > On 08/03/17 11:11, Frederik Braun wrote: >> On 08.03.2017 01:17, Ralph Giles wrote: >>> I second Jeff's point about building with icecream[1]. If you work in >>> an office with a build farm, or near a fast desktop machine you can >>> pass jobs to, this

Re: Is there a way to improve partial compilation times?

2017-03-08 Thread Ehsan Akhgari
On 2017-03-07 2:49 PM, Eric Rahm wrote: > I often wonder if unified builds are making things slower for folks who use > ccache (I assume one file changing would mean a rebuild for the entire > unified chunk), I'm not sure if there's a solution to that but it would be > interesting to see if

Re: Project Stockwell (reducing intermittents) - March 2017 update

2017-03-08 Thread Marco Bonardo
On Wed, Mar 8, 2017 at 2:12 PM, Kartikaya Gupta wrote: > What makes me sad is all the > developers in this thread trying to push back against disabling of > clearly problematic tests, asking for things like tracking bugs and > needinfos, when the reality is that the

Re: Project Stockwell (reducing intermittents) - March 2017 update

2017-03-08 Thread Kartikaya Gupta
I've been reading this thread with much sadness, but refraining from commenting because I have nothing good to say. But I feel like I should probably comment regardless. What makes me sad is all the developers in this thread trying to push back against disabling of clearly problematic tests,

Re: Is there a way to improve partial compilation times?

2017-03-08 Thread James Graham
On 08/03/17 11:11, Frederik Braun wrote: On 08.03.2017 01:17, Ralph Giles wrote: I second Jeff's point about building with icecream[1]. If you work in an office with a build farm, or near a fast desktop machine you can pass jobs to, this makes laptop builds much more tolerable. What do you

Re: Is there a way to improve partial compilation times?

2017-03-08 Thread Gabriele Svelto
On 08/03/2017 01:11, Mike Hommey wrote: > You probably want a desktop machine, not a new laptop. I second that, modern laptops are usually thermally limited. I actually drilled holes in the back of my Thinkpad to improve airflow (and it did improve build times). My main box is a not-so-recent

Re: Is there a way to improve partial compilation times?

2017-03-08 Thread Frederik Braun
On 08.03.2017 01:17, Ralph Giles wrote: > I second Jeff's point about building with icecream[1]. If you work in > an office with a build farm, or near a fast desktop machine you can > pass jobs to, this makes laptop builds much more tolerable. > What do you mean by build farm? Do some offices

Re: Project Stockwell (reducing intermittents) - March 2017 update

2017-03-08 Thread jmaher
On Tuesday, March 7, 2017 at 11:45:38 PM UTC-5, Chris Pearce wrote: > I recommend that instead of classifying intermittents as tests which fail > > 30 times per week, to instead classify tests that fail more than some > threshold percent as intermittent. Otherwise on a week with lots of