Re: Using the accesskey attribute with HTML elements in browser chrome

On 06/20/2017 04:36 PM, Brian Grinstead wrote: On Jun 19, 2017, at 6:58 PM, Ehsan Akhgari wrote: On 06/19/2017 04:28 PM, Brian Grinstead wrote: I was wondering what would need to be done in order to use the accesskey attribute on HTML elements in the browser chrome. Here are some of the diff

Re: Intent to unship: HTML scoped style sheets (

On Wed, Jun 21, 2017, at 02:05 AM, Bobby Holley wrote: > Yeah - stylo for the frontend would be nice, but it's not part of > our MVP. Thanks for confirming what I thought was the case. :-) On Tue, Jun 20, 2017, at 03:26 PM, Patrick Brosset wrote: > Cameron, what bug should this one block (iiuc chr

Re: Changing .idl files

I just found https://bugzilla.mozilla.org/show_bug.cgi?id=1347507: "Stuff we can remove when XPCOM extensions are no longer supported". A number of the blocking bugs are for removing XPIDL interfaces. If you know of other things that can be removed, please add them as blocking bugs. Nick On Wed,

Intent to unship: Add-on SDK and others

With Firefox 57 only running WebExtensions, we are hoping to spend some time *after* Firefox 57 doing some cleaning and removing un-needed code. The plans are still being formed, but we are aiming to land some of these in the Firefox 58 or Firefox 59 trains. The timetable is currently under discuss

Re: Profiling nightlies on Mac - what tools are used?

On Tue, Jun 20, 2017 at 10:28 AM, Ehsan Akhgari wrote: > On 06/20/2017 12:28 PM, Nathan Froyd wrote: > >> On Tue, Jun 20, 2017 at 12:19 PM, Ehsan Akhgari >> wrote: >> >>> On 06/20/2017 08:34 AM, Nathan Froyd wrote: >>> There is some kind of interaction with the underlying machine (see

Re: Using the accesskey attribute with HTML elements in browser chrome

> On Jun 19, 2017, at 6:58 PM, Ehsan Akhgari wrote: > > On 06/19/2017 04:28 PM, Brian Grinstead wrote: >> I was wondering what would need to be done in order to use the accesskey >> attribute on HTML elements in the browser chrome. Here are some of the >> differences between the attribute in H

Re: Profiling nightlies on Mac - what tools are used?

Very much so yes. Even if having unstripped builds were universally slower (they only seem to be only slower on the ci machines) any performance impact is likely to not impact the distribution of samples substantially. On Tue, Jun 20, 2017 at 2:09 PM, Chris Peterson wrote: > On 6/20/17 10:28 AM,

Re: Getting a JS stack from an automation assertion

On 6/20/17 1:53 PM, Benjamin Smedberg wrote: Is there a way to have automation call DumpJSStack() on assertion (before crashing) You could hack a DumpJSStack() call into the nsDebug machinery, basically. Would it be safe to call DumpJSStack() explicitly from the place where I'm firing this as

Re: Profiling nightlies on Mac - what tools are used?

On 6/20/17 10:28 AM, Ehsan Akhgari wrote: That seems like the obvious next step to investigate to me. We should *really* only talk about stripping builds as the last resort IMO, since we have way too many developers using OSX every day... Does profiling an unstripped Mac build still produce u

Re: Intent to unship: HTML scoped style sheets (

Yeah - stylo for the frontend would be nice, but it's not part of our MVP. It wouldn't be hard, just presumably implementing a few more scattered internal things and fixing more bugs exposed by the heavier usage of XBL. But we could ship in 57 without it, and so it seems foolish to widen our scope

Re: Intent to unship: HTML scoped style sheets (

On 6/20/17 2:14 AM, Cameron McCormack wrote: Cameron, what bug should this one block (iiuc chrome support will be removed a bit later, so we have some time, do you already have a bug for that part?) Actually, let me backtrack a little. I might be misremembering our plans for Stylo in chrom

Getting a JS stack from an automation assertion

I'm working on a patch which adds a new assertion, and this code is failing in automation in an intermittent way. The assertion is in C++ code but it's being called by unknown JS code. Is there a way to have automation call DumpJSStack() on assertion (before crashing), or are there other debugging

Re: Profiling nightlies on Mac - what tools are used?

On 06/20/2017 12:28 PM, Nathan Froyd wrote: On Tue, Jun 20, 2017 at 12:19 PM, Ehsan Akhgari wrote: On 06/20/2017 08:34 AM, Nathan Froyd wrote: There is some kind of interaction with the underlying machine (see comment 104 in said bug, where the binaries perform identically on a local machine,

Re: Errors found by cppcheck

On 06/20/2017 12:54 PM, Andrew Halberstadt wrote: Yes, we can blacklist checks with: cppcheck --suppress= You can see the check ids with: cppcheck --errorlist It's actually even more flexible, checks can be disabled for specific files, directories and even lines in the file. And it can all be

Re: Errors found by cppcheck

Yes, we can blacklist checks with: cppcheck --suppress= You can see the check ids with: cppcheck --errorlist It's actually even more flexible, checks can be disabled for specific files, directories and even lines in the file. And it can all be specified in a text file then passed in with: cppchec

Re: Profiling nightlies on Mac - what tools are used?

On Tue, Jun 20, 2017 at 12:19 PM, Ehsan Akhgari wrote: > On 06/20/2017 08:34 AM, Nathan Froyd wrote: >> There is some kind of interaction with the underlying machine (see >> comment 104 in said bug, where the binaries perform identically on a >> local machine, but differently on infrastructure), b

Re: Profiling nightlies on Mac - what tools are used?

On 06/20/2017 08:34 AM, Nathan Froyd wrote: There is some kind of interaction with the underlying machine (see comment 104 in said bug, where the binaries perform identically on a local machine, but differently on infrastructure), but we haven't tracked that down yet. From comment 104 it seems th

Recording code loaded during startup, and avoiding regressions

As part of Quantum/Photon, we are working on improving startup . More specifically, we care a lot about reducing the time it takes to first paint the browser window. Sometimes this means removing useless code

Intent to ship: Enable throttling of tracking timeouts on nightly

Hi all! As of 2017-06-21 I intend to, for nightly only, turn on throttling of timeouts from tracking scripts for windows in the foreground. We're already shipping this for background timeouts, and our hope is that enabling throttling for foreground will help us determine the effectiveness of the t

Re: Profiling nightlies on Mac - what tools are used?

On Tue, Jun 20, 2017 at 3:59 AM, Julian Seward wrote: > On 20/06/17 05:58, Boris Zbarsky wrote: >> On 6/19/17 11:22 PM, Gregory Szorc wrote: >>> The decision to strip Nightly builds does not come lightly. Read 1338651 >>> comment 111 and later for the ugly backstory. >> >> It's still really confus

Re: Profiling nightlies on Mac - what tools are used?

On Tue, Jun 20, 2017, at 03:59 AM, Julian Seward wrote: > I've used VTune on Linux and have some idea what it can and can't do. > I have tried it on Mac, but my impression, from the Intel web site, is > that it is at least available for Mac. Apparently the version for Mac is just a GUI for viewing

Re: Using the accesskey attribute with HTML elements in browser chrome

On 6/20/2017 5:28 AM, Brian Grinstead wrote: I was wondering what would need to be done in order to use the accesskey attribute on HTML elements in the browser chrome. Here are some of the differences between the attribute in HTML and XUL that I've found so far: 1) In XUL (https://developer.m

Re: Intent to unship: HTML scoped style sheets (

On Tue, Jun 20, 2017, at 03:26 PM, Patrick Brosset wrote: > DevTools also uses a scoped stylesheet in its tooltip widget [1]. > I have filed a bug [2] to remove it. Thank you. > Cameron, what bug should this one block (iiuc chrome support will be > removed a bit later, so we have some time, do yo

Re: Profiling nightlies on Mac - what tools are used?

On 20/06/17 05:58, Boris Zbarsky wrote: > On 6/19/17 11:22 PM, Gregory Szorc wrote: >> The decision to strip Nightly builds does not come lightly. Read 1338651 >> comment 111 and later for the ugly backstory. > > It's still really confusing to me that not stripping symbols has a significant > perf

Re: Intent to unship: HTML scoped style sheets (

DevTools also uses a scoped stylesheet in its tooltip widget [1]. I have filed a bug [2] to remove it. Cameron, what bug should this one block (iiuc chrome support will be removed a bit later, so we have some time, do you already have a bug for that part?) Thanks! Patrick [1] http://searchfox.or