Re: #pragma once?

2017-10-11 Thread Tom Tromey
> "Marco" == Marco Bonardo writes: Marco> See the previous pragma once proposal: Marco> https://groups.google.com/forum/#!msg/mozilla.dev.platform/PgDjWw3xp8k/PLYQc5xoWmsJ Something I didn't see in that thread is that, at least with GCC, pragma once does not scale

Re: C++ function that the optimizer won't eliminate

2017-10-11 Thread Gabriele Svelto
On 09/10/2017 13:47, Henri Sivonen wrote: > I omitted volatile, because the GCC manual said it has no effect on > basic asm. However, it turns out it still has an effect on extended > asm, which is what this is. Oops. Yes, volatile implies the statement has side effects and so it cannot be moved

Re: Experimenting with a shared review queue for Core::Build Config

2017-10-11 Thread smaug
On 10/11/2017 09:55 PM, Andreas Tolfsen wrote: +tools-marionette Also sprach Chris Cooper: Many of the build peers have long review queues. Is having a long review queue the actual issue? Isn't (too) high throughput at least equally bad issue. Does the new setup somehow try to ensure reviews

Re: Experimenting with a shared review queue for Core::Build Config

2017-10-11 Thread Andreas Tolfsen
+tools-marionette Also sprach Chris Cooper: Many of the build peers have long review queues. I'm not convinced that all of the review requests going to any particular build peer need to be exclusive. I think it is great that you’re experimenting with this, and I’m very excited about it! In

Re: Experimenting with a shared review queue for Core::Build Config

2017-10-11 Thread Botond Ballo
On Wed, Oct 11, 2017 at 2:37 PM, Chris Cooper wrote: > On Wed, Oct 11, 2017 at 1:46 PM, Nathan Froyd wrote: >> Does this user have a bugzilla :alias so that folks submitting patches >> via MozReview or similar can just write r=build-peer or something, >>

Re: Experimenting with a shared review queue for Core::Build Config

2017-10-11 Thread Chris Cooper
On Wed, Oct 11, 2017 at 1:46 PM, Nathan Froyd wrote: > Does this user have a bugzilla :alias so that folks submitting patches > via MozReview or similar can just write r=build-peer or something, > rather than having to manually select the appropriate shared queue > after

Re: Experimenting with a shared review queue for Core::Build Config

2017-10-11 Thread Nathan Froyd
Does this user have a bugzilla :alias so that folks submitting patches via MozReview or similar can just write r=build-peer or something, rather than having to manually select the appropriate shared queue after submitting their patch for review? -Nathan On Wed, Oct 11, 2017 at 1:41 PM, Chris

Experimenting with a shared review queue for Core::Build Config

2017-10-11 Thread Chris Cooper
Many of the build peers have long review queues. I'm not convinced that all of the review requests going to any particular build peer need to be exclusive. We're going to try an experiment to see if we can make this better for patch authors and reviewers alike. To this end, we've set up a shared

Re: #pragma once?

2017-10-11 Thread Marco Bonardo
See the previous pragma once proposal: https://groups.google.com/forum/#!msg/mozilla.dev.platform/PgDjWw3xp8k/PLYQc5xoWmsJ On Wed, Oct 11, 2017 at 11:45 AM, Emilio Cobos Álvarez wrote: > Hi, > > I'm adding a header to the build, and I'm wondering: Can we use pragma once?

#pragma once?

2017-10-11 Thread Emilio Cobos Álvarez
Hi, I'm adding a header to the build, and I'm wondering: Can we use pragma once? I don't see it anywhere in the build except third-party paths and: dom/svg/nsISVGPoint.h xpcom/io/nsAnonymousTemporaryFile.h So I'm not sure if it's because it's somehow prohibited or not recommended, or just