Re: Intent to unship: mozmm CSS unit.

2017-11-12 Thread Emilio Cobos Álvarez
Also, another thought I just had about this unit: Probably if we don't
unship it, then privacy.resistFingerPrinting should do something about
it, since it allows to calculate the DPI of the screen trivially using
CSSOM accessors.

Filed bug 1416574.
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Intent to require Python 3 to build Firefox 59 and later

2017-11-12 Thread David Burns
I am not saying it should but if we have a requirement for python 3, we are
also going to have a requirement for py2 to both be available for local
development.

David

On 11 November 2017 at 14:10, Andrew Halberstadt 
wrote:

> On Fri, Nov 10, 2017 at 9:44 PM David Burns  wrote:
>
>> My only concern about this is how local developer environments are going
>> to be when it comes to testing. While I am sympathetic to moving to python
>> 3 we need to make sure that all the test harnesses have been moved over and
>> this is something that needs a bit of coordination. Luckily a lot of the
>> mozbase stuff is already moving to python 3 support but that still means we
>> need to have web servers and the actual test runners moved over too.
>>
>> David
>>
>
> For libraries like mozbase, I think the plan will be to support both 2 and
> 3 at
> the same time. There are libraries (like 'six') that make this possible.
> I'd bet
> there are even parts of the build system that will still need to support
> both at
> the same time.
>
> With that in mind, I don't think python 3 support for test harnesses needs
> to
> block the build system.
>
> Andrew
>
> On 10 November 2017 at 23:27, Gregory Szorc  wrote:
>>
>>> For reasons outlined at https://bugzilla.mozilla.org/
>>> show_bug.cgi?id=1388447#c7, we would like to make Python 3 a
>>> requirement to build Firefox sometime in the Firefox 59 development cycle.
>>> (Firefox 59 will be an ESR release.)
>>>
>>> The requirement will likely be Python 3.5+. Although I would love to
>>> make that 3.6 if possible so we can fully harness modern features and
>>> performance.
>>>
>>> I would love to hear feedback - positive or negative - from downstream
>>> packagers and users of various operating systems and distributions about
>>> this proposal.
>>>
>>> Please send comments to dev-bui...@lists.mozilla.org or leave them on
>>> bug 1388447.
>>>
>>> ___
>>> dev-builds mailing list
>>> dev-bui...@lists.mozilla.org
>>> https://lists.mozilla.org/listinfo/dev-builds
>>>
>>> ___
>> dev-builds mailing list
>> dev-bui...@lists.mozilla.org
>> https://lists.mozilla.org/listinfo/dev-builds
>>
>
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Intent to unship: mozmm CSS unit.

2017-11-12 Thread Gijs Kruitbosch

On 12/11/2017 16:36, Emilio Cobos Álvarez wrote:

On 11/12/2017 05:14 PM, Xidorn Quan wrote:

I doubt if there is anything changed since then (except that we still
haven't pushed this on csswg), so maybe we still shouldn't remove it.


I'm definitely ok with adding something like that if there's an use-case
and demand for it... But given I haven't been able to find any actual
usage of it, not even internal, I suspect there isn't much?


Related, but not exactly the same (so please carry on with whatever you 
want to do with mozmm): browser chrome at least has a usecase for a CSS 
unit that matches 1 device pixel on various dpis, because layout already 
adjusts some (but not all!) sizes to align to device pixels and this 
causes issues when we basically want "make a line that is 1 device pixel 
wide". We can workaround the lack of such a unit with CSS variables and 
something like:


@media (min-resolution: 2dppx) {
  --mydevicepixel: 0.5px;
}

but it's tedious to do for dpi on windows (which has a lot more 
variations than on macOS) and probably a perf nightmare.


~ Gijs
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Intent to unship: mozmm CSS unit.

2017-11-12 Thread Gijs Kruitbosch

On 12/11/2017 16:56, Gijs Kruitbosch wrote:

because layout already adjusts some (but not all!) sizes to align to device 
pixels


For reference: https://bugzilla.mozilla.org/show_bug.cgi?id=477157 and 
friends.


~ Gijs
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Intent to unship: mozmm CSS unit.

2017-11-12 Thread Emilio Cobos Álvarez


On 11/12/2017 05:14 PM, Xidorn Quan wrote:
> IIRC, we have discussed unshipping this somewhere before we added its
> support to stylo (maybe the Taipei meeting this year?) and dbaron said
> that mozmm provides an ability to size something based on physical size
> which is not directly possible in any other unit, so this is something
> we may want to put into spec rather than removing.

Huh, I don't recall being part of that discussion, but that sounds
plausible.

> I doubt if there is anything changed since then (except that we still
> haven't pushed this on csswg), so maybe we still shouldn't remove it.

I'm definitely ok with adding something like that if there's an use-case
and demand for it... But given I haven't been able to find any actual
usage of it, not even internal, I suspect there isn't much?

In any case, having features exposed to the web without any
specification or other browsers supporting it looks like the wrong thing
to me, and the kind of thing that may bite in the future (and that makes
Servo's life harder, too), so I still would like to unship it if possible.

If afterwards we figure out that this is needed, I'd be happy to see it
added as something every browser agrees with. My patch keeps the ability
to convert physical millimeters to CSS pixels, so it'd be trivial to
reintroduce if Mozilla decides to push for this feature and other
browsers agree.

 -- Emilio
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Intent to unship: mozmm CSS unit.

2017-11-12 Thread Xidorn Quan

On Mon, Nov 13, 2017, at 02:11 AM, Emilio Cobos Álvarez wrote:
> Hi,
> 
> In bug 1416564 I intend to remove the mozmm CSS unit.
> 
> This unit is Mozilla-only, has no spec, and is unused in all our
> codebase (except for two tests, one of those which tests the unit
> itself).
> 
> This unit was introduced experimentally in bug 537890, our browser
> chrome code used it in bug 588464, and all that is gone since then.
> 
> Given there's no spec, and no usage in the wild as far as I can tell, I
> think we should try to remove it.
> 
> Thoughts?

IIRC, we have discussed unshipping this somewhere before we added its
support to stylo (maybe the Taipei meeting this year?) and dbaron said
that mozmm provides an ability to size something based on physical size
which is not directly possible in any other unit, so this is something
we may want to put into spec rather than removing.

I doubt if there is anything changed since then (except that we still
haven't pushed this on csswg), so maybe we still shouldn't remove it.

- Xidorn
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Intent to unship: mozmm CSS unit.

2017-11-12 Thread Emilio Cobos Álvarez
Hi,

In bug 1416564 I intend to remove the mozmm CSS unit.

This unit is Mozilla-only, has no spec, and is unused in all our
codebase (except for two tests, one of those which tests the unit itself).

This unit was introduced experimentally in bug 537890, our browser
chrome code used it in bug 588464, and all that is gone since then.

Given there's no spec, and no usage in the wild as far as I can tell, I
think we should try to remove it.

Thoughts?

 -- Emilio
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform