Re: Intent to Unship: -moz-window-opacity / -moz-window-transform / -moz-window-transform-origin CSS properties.
The subject of the email should probably say "from content pages" :) On 6/2/18 5:18 PM, Emilio Cobos Álvarez wrote: Hi, In bug 1419695 I plan to unship the CSS properties mentioned in the subject of this email. The only reason they were exposed were because they landed as accidentally exposed given the confusing semantics of the "internal" properties (that just hides them from CSSOM enumeration code), and the ones that are really chrome-only / ua-only. We couldn't just hide them because the style system was refusing to transition chrome-only / ua-only properties, and the mac code does transition them. In any case, these properties don't have any effect on content pages, since the properties are only used for Mac OS windows, so other than hiding them from the OM / forbidding them from parsing, this shouldn't have any other compat impact. Let me know if you think otherwise. Thanks! Thanks! -- Emilio ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Intent to Unship: -moz-window-opacity / -moz-window-transform / -moz-window-transform-origin CSS properties.
Hi, In bug 1419695 I plan to unship the CSS properties mentioned in the subject of this email. The only reason they were exposed were because they landed as accidentally exposed given the confusing semantics of the "internal" properties (that just hides them from CSSOM enumeration code), and the ones that are really chrome-only / ua-only. We couldn't just hide them because the style system was refusing to transition chrome-only / ua-only properties, and the mac code does transition them. In any case, these properties don't have any effect on content pages, since the properties are only used for Mac OS windows, so other than hiding them from the OM / forbidding them from parsing, this shouldn't have any other compat impact. Let me know if you think otherwise. Thanks! Thanks! -- Emilio ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: PSA: No more mozilla::Move
> On 2 Jun 2018, at 3:45 pm, Jean-Yves Avenard wrote: >> >> Beware of some local mac builds maybe being broken. That should be fixed >> by bug 1270217 (thanks jwatt!). > > > FWIW, this breaks build with clang 6.0.0 on mac… > > such as: > 0:04.70 > /Users/jyavenard/Work/Mozilla/obj-ff-dbg/dist/include/mozilla/Move.h:222:14: > error: no type named 'move' in namespace ‘std' > > which is ultra weird a Move.h properly includes sorry for the noise, yes, applying bug 1270217 did fix it… smime.p7s Description: S/MIME cryptographic signature ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: PSA: No more mozilla::Move
> On 2 Jun 2018, at 9:56 am, Emilio Cobos Álvarez wrote: > > Hi, just a quick PSA: > > In bug 1465585 I switched all uses of mozilla::Move to std::move, and > removed the former. > > The reasoning for that is that it allows compilers to detect misuses of > std::move and warn about them (-Wpessimizing-move / -Wself-move / > -Wreturn-std-move). > > Beware of some local mac builds maybe being broken. That should be fixed > by bug 1270217 (thanks jwatt!). FWIW, this breaks build with clang 6.0.0 on mac… such as: 0:04.70 /Users/jyavenard/Work/Mozilla/obj-ff-dbg/dist/include/mozilla/Move.h:222:14: error: no type named 'move' in namespace ‘std' which is ultra weird a Move.h properly includes smime.p7s Description: S/MIME cryptographic signature ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
PSA: No more mozilla::Move
Hi, just a quick PSA: In bug 1465585 I switched all uses of mozilla::Move to std::move, and removed the former. The reasoning for that is that it allows compilers to detect misuses of std::move and warn about them (-Wpessimizing-move / -Wself-move / -Wreturn-std-move). Beware of some local mac builds maybe being broken. That should be fixed by bug 1270217 (thanks jwatt!). Cheers, -- Emilio ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
