Re: Tagged pointers

2018-07-12 Thread Alexis Beingessner
On Thu, Jul 12, 2018 at 11:03 PM, Robert O'Callahan wrote: > On Fri, Jul 13, 2018 at 11:40 AM, Steve Fink wrote: > > > On 07/12/2018 04:27 PM, Cameron McCormack wrote: > > > >> On Fri, Jul 13, 2018, at 6:51 AM, Kris Maglione wrote: > >> > >>> I actually have a patch sitting around with helpers

Re: Tagged pointers

2018-07-12 Thread Mike Hommey
On Fri, Jul 13, 2018 at 03:03:47PM +1200, Robert O'Callahan wrote: > On Fri, Jul 13, 2018 at 11:40 AM, Steve Fink wrote: > > > On 07/12/2018 04:27 PM, Cameron McCormack wrote: > > > >> On Fri, Jul 13, 2018, at 6:51 AM, Kris Maglione wrote: > >> > >>> I actually have a patch sitting around with

Re: Tagged pointers

2018-07-12 Thread Robert O'Callahan
On Fri, Jul 13, 2018 at 11:40 AM, Steve Fink wrote: > On 07/12/2018 04:27 PM, Cameron McCormack wrote: > >> On Fri, Jul 13, 2018, at 6:51 AM, Kris Maglione wrote: >> >>> I actually have a patch sitting around with helpers to make it super >>> easy to >>> use smart pointers as tagged pointers :)

Re: Fission MemShrink Newsletter #1: What (it is) and Why (it matters to you)

2018-07-12 Thread Randell Jesup
>On 07/12/2018 11:08 PM, Randell Jesup wrote: >> We may need to trade first-load time against memory use by lazy-initing >> more things than now, though we did quite a bit on that already for >> reducing startup time. > >One thing to remember that some of the child processes will be more

Re: Using clang-cl to ship Windows builds

2018-07-12 Thread Anthony Jones
On Friday, 13 July 2018 11:26:07 UTC+12, Jörg Knobloch wrote: > On 10/07/2018 22:29, David Major wrote: > > Bug 1443590 is switching our official Windows builds to use clang-cl > > as the compiler. > > > > Please keep an eye out for regressions and file a blocking bug for > > anything that might

Re: Fission MemShrink Newsletter #1: What (it is) and Why (it matters to you)

2018-07-12 Thread Nicholas Nethercote
On Fri, Jul 13, 2018 at 1:56 AM, Andrew McCreight wrote: > > > > Just curious, is there a bug on file to measure excess capacity on > > nsTArrays and hash tables? > > njn looked at that kind of issue at some point (he changed how arrays grow, > for instance, to reduce overhead), but it has

Two tips for faster Firefox builds

2018-07-12 Thread Nicholas Nethercote
Hi, Here are two things that might help you get faster builds. TL;DR: 1. On Linux, make sure you have lld installed, because it's a *much* faster linker than gold, and it's now used by default if installed. 2. Upgrade your sccache to version 0.2.7 to get faster rebuilds of changed Rust files.

Re: Tagged pointers

2018-07-12 Thread Mike Hommey
On Thu, Jul 12, 2018 at 04:40:39PM -0700, Steve Fink wrote: > On 07/12/2018 04:27 PM, Cameron McCormack wrote: > > On Fri, Jul 13, 2018, at 6:51 AM, Kris Maglione wrote: > > > I actually have a patch sitting around with helpers to make it super easy > > > to > > > use smart pointers as tagged

Tagged pointers

2018-07-12 Thread Steve Fink
On 07/12/2018 04:27 PM, Cameron McCormack wrote: On Fri, Jul 13, 2018, at 6:51 AM, Kris Maglione wrote: I actually have a patch sitting around with helpers to make it super easy to use smart pointers as tagged pointers :) I never wound up putting it up for review, since my original use case

Re: Fission MemShrink Newsletter #1: What (it is) and Why (it matters to you)

2018-07-12 Thread Cameron McCormack
On Fri, Jul 13, 2018, at 6:51 AM, Kris Maglione wrote: > I actually have a patch sitting around with helpers to make it super easy to > use smart pointers as tagged pointers :) I never wound up putting it up for > review, since my original use case went away, but it you can think of any >

Re: Using clang-cl to ship Windows builds

2018-07-12 Thread Jörg Knobloch
On 10/07/2018 22:29, David Major wrote: Bug 1443590 is switching our official Windows builds to use clang-cl as the compiler. Please keep an eye out for regressions and file a blocking bug for anything that might be fallout from this change. I'm especially interested in hearing about the

Re: Fission MemShrink Newsletter #1: What (it is) and Why (it matters to you)

2018-07-12 Thread Xidorn Quan
On Fri, Jul 13, 2018, at 7:08 AM, smaug wrote: > One thing to remember that some of the child processes will be more > important than others. For example all the processes used for browsing > contexts in > the foreground tab should probably prefer performance over memory (in > cases that is

Re: Fission MemShrink Newsletter #1: What (it is) and Why (it matters to you)

2018-07-12 Thread smaug
On 07/12/2018 11:08 PM, Randell Jesup wrote: I do hope that the 100 process figures scenario that was given is a worse case scenario though... It's not. Worst case is a LOT worse. Shutting down threads/threadpools when not needed or off an idle timer is a Good thing. There may be some perf

Re: Fission MemShrink Newsletter #1: What (it is) and Why (it matters to you)

2018-07-12 Thread Kris Maglione
On Thu, Jul 12, 2018 at 10:27:13PM +0200, Gabriele Svelto wrote: On 12/07/2018 22:19, Kris Maglione wrote: I've actually been thinking on filing a bug to do something similar, to measure cumulative effects of excess padding in certain types since I began looking into bug 1460674, and Sylvestre

Re: Fission MemShrink Newsletter #1: What (it is) and Why (it matters to you)

2018-07-12 Thread Kris Maglione
On Thu, Jul 12, 2018 at 04:08:49PM -0400, Randell Jesup wrote: I do hope that the 100 process figures scenario that was given is a worse case scenario though... It's not. Worst case is a LOT worse. Shutting down threads/threadpools when not needed or off an idle timer is a Good thing.

Re: Yes=0, No=1

2018-07-12 Thread Justin Dolske
On Thu, Jul 12, 2018 at 1:28 PM, Jason Orendorff wrote: > > ...This is bad, right? Asking for a friend. > > 1 Justin ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Intent to remove: the 'Memory usage of Subprocesses' table from about:performance

2018-07-12 Thread Kris Maglione
+1 for adding it back in the future. Even if memory usage isn't as directly related to performance as CPU usage is, it has a *huge* effect on performance on memory constrained systems, if it causes them to have to swap. Also, in my experience, the overlap between poorly-performing code and

Re: Fission MemShrink Newsletter #1: What (it is) and Why (it matters to you)

2018-07-12 Thread Kris Maglione
On Thu, Jul 12, 2018 at 08:56:28AM -0700, Andrew McCreight wrote: On Thu, Jul 12, 2018 at 3:57 AM, Emilio Cobos Álvarez wrote: Thanks for doing this! Just curious, is there a bug on file to measure excess capacity on nsTArrays and hash tables? njn looked at that kind of issue at some point

Yes=0, No=1

2018-07-12 Thread Jason Orendorff
The codebase has a few bool-like enum classes like this: enum class HolodeckSafetyProtocolsEnabled { Yes, No }; Note that `bool(HolodeckSafetyProtocolsEnabled::Yes)` is false. ...This is bad, right? Asking for a friend. -j ___

Re: Fission MemShrink Newsletter #1: What (it is) and Why (it matters to you)

2018-07-12 Thread Gabriele Svelto
On 12/07/2018 22:19, Kris Maglione wrote: > I've actually been thinking on filing a bug to do something similar, to > measure cumulative effects of excess padding in certain types since I > began looking into bug 1460674, and Sylvestre mentioned that > clang-analyzer can generate reports on excess

Re: Fission MemShrink Newsletter #1: What (it is) and Why (it matters to you)

2018-07-12 Thread Kris Maglione
On Thu, Jul 12, 2018 at 12:57:35PM +0200, Emilio Cobos Álvarez wrote: Thanks for doing this! Just curious, is there a bug on file to measure excess capacity on nsTArrays and hash tables? I don't think so, but it's a good idea. I've actually been thinking on filing a bug to do something

Re: Fission MemShrink Newsletter #1: What (it is) and Why (it matters to you)

2018-07-12 Thread Randell Jesup
>I do hope that the 100 process figures scenario that was given is a worse case >scenario though... It's not. Worst case is a LOT worse. Shutting down threads/threadpools when not needed or off an idle timer is a Good thing. There may be some perf hit since it may mean starting a thread

Re: Intent to remove: the 'Memory usage of Subprocesses' table from about:performance

2018-07-12 Thread Eric Rahm
Thanks Florian, considering it's roughly unmaintained right now, leaking, and showing up in perf profiles it sounds reasonable to remove the memory section. I've filed bug 1475301 [1] to allow us to measure USS off main thread; we can deal with adding that back in the future if it makes sense. -e

Re: Fission MemShrink Newsletter #1: What (it is) and Why (it matters to you)

2018-07-12 Thread Andrew McCreight
On Thu, Jul 12, 2018 at 3:57 AM, Emilio Cobos Álvarez wrote: > Thanks for doing this! > > Just curious, is there a bug on file to measure excess capacity on > nsTArrays and hash tables? > > WebKit has a bunch of bugs like: > > https://bugs.webkit.org/show_bug.cgi?id=186709 > > Which seem

Re: Fission MemShrink Newsletter #1: What (it is) and Why (it matters to you)

2018-07-12 Thread Tom Ritter
On Wed, Jul 11, 2018 at 6:25 PM, Karl Tomlinson wrote: > Is there a guideline that should be used to evaluate what can > acceptably run in the same process for different sites? > This is on me to write. I have been slow at doing so mainly because there's a lot of "What does X look like and

Re: Fission MemShrink Newsletter #1: What (it is) and Why (it matters to you)

2018-07-12 Thread Emilio Cobos Álvarez
Thanks for doing this! Just curious, is there a bug on file to measure excess capacity on nsTArrays and hash tables? WebKit has a bunch of bugs like: https://bugs.webkit.org/show_bug.cgi?id=186709 Which seem relevant. -- Emilio On 07/10/2018 08:19 PM, Kris Maglione wrote: Welcome to

Re: Intent to remove: the 'Memory usage of Subprocesses' table from about:performance

2018-07-12 Thread Florian Quèze
On Thu, Jul 12, 2018 at 1:18 AM, Eric Rahm wrote: > What performance issues are you seeing? RSS and USS should be relatively > lightweight and the polling frequency isn't very high. It seems ResidentUniqueDistinguishedAmount does blocking system calls, resulting in blocking the main thread for

Re: Using clang-cl to ship Windows builds

2018-07-12 Thread Mike Hommey
On Wed, Jul 11, 2018 at 11:34:52PM -0700, Anthony Jones wrote: > On Thursday, 12 July 2018 15:50:40 UTC+12, halivi...@gmail.com wrote: > > I hope that both Firefox and Chrome continue to keep the build and > > tests running on MSVC. It would suck if for example we can't build > > Firefox with

Re: Using clang-cl to ship Windows builds

2018-07-12 Thread Anthony Jones
On Thursday, 12 July 2018 15:50:40 UTC+12, halivi...@gmail.com wrote: > I hope that both Firefox and Chrome continue to keep the build and tests > running on MSVC. It would suck if for example we can't build Firefox with > MSVC. I can't comment on Chrome. > Will the Firefox team publish

Re: Proposed W3C Charters: Accessibility (APA and ARIA Working Groups)

2018-07-12 Thread James Teh
I (and others in the accessibility team) think we should support these charters. The ARIA working group is especially important in the future evolution of web accessibility. I have some potential concerns/questions regarding the personalisation semantics specifications from APA, but they're more