Re: Plan for Sunsetting MozReview

2018-08-27 Thread Botond Ballo
> Until this gets fixed, a workaround for closed bugs is to go to the bottom of > the bug, and look for https://hg.mozilla.org/mozilla-central/rev/... links. > Not as pretty, and missing review context, but hopefully this should help > explore the changed code in most cases. For bugs that

Re: Plan for Sunsetting MozReview

2018-08-27 Thread gsquelart
(Disclaimer: I'm not from IT!) Until this gets fixed, a workaround for closed bugs is to go to the bottom of the bug, and look for https://hg.mozilla.org/mozilla-central/rev/... links. Not as pretty, and missing review context, but hopefully this should help explore the changed code in most

Re: Plan for Sunsetting MozReview

2018-08-27 Thread Eric Shepherd (Sheppy)
We've noticed that attachment links are no longer working because they're still trying to go to reviewboard, and there don't appear to be redirects. See for example this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1211330. It has two attachments. Clicking either one of them gives you a

Scheduling code coverage builds on try

2018-08-27 Thread Gregory Mierzwinski
Hello, As of now, we've completely disabled any code coverage builds (*-ccov or *-jsdcov) from running on try when try syntax is used with the changes in [1]. A change has also been made in [2] that now requires the use of the `--full` argument with |mach try fuzzy --full| to be able to schedule

Re: Please don't use functions from ctype.h and strings.h

2018-08-27 Thread Henri Sivonen
I think it's worthwhile to have a lint, but regexps are likely to have false positives, so using clang-tidy is probably better. A bug is on file: https://bugzilla.mozilla.org/show_bug.cgi?id=1485588 On Mon, Aug 27, 2018 at 4:06 PM, Tom Ritter wrote: > Is this something worth making a lint over?

Re: Please don't use functions from ctype.h and strings.h

2018-08-27 Thread Tom Ritter
Is this something worth making a lint over? It's pretty easy to make regex-based lints, e.g. yml-only based lint: https://searchfox.org/mozilla-central/source/tools/lint/cpp-virtual-final.yml yml+python for slightly more complicated regexing:

Please don't use functions from ctype.h and strings.h

2018-08-27 Thread Henri Sivonen
Please don't use the functions from ctype.h and strings.h. See: https://daniel.haxx.se/blog/2018/01/30/isalnum-is-not-my-friend/ https://daniel.haxx.se/blog/2008/10/15/strcasecmp-in-turkish/ https://stackoverflow.com/questions/2898228/can-isdigit-legitimately-be-locale-dependent-in-c In addition

[desktop] Bugs logged by Desktop Release QA in the last 7 days

2018-08-27 Thread Bogdan Maris
Hello, Here's the list of new issues found and filed by the Desktop Release QA team last two weeks. Additional details on the team's priorities last week, as well as the plans for the current week are available at: https://tinyurl.com/yclje85s Bugs logged by Desktop Release QA in the last 7