On Sat, Dec 15, 2018 at 04:06:05AM +0100, Emilio Cobos Álvarez wrote:
In https://bugzilla.mozilla.org/show_bug.cgi?id=1513009 I just landed
a patch so that warnings for non-third-party Rust code get reported as
errors in automation, and thus fail to build (also if you build
locally with
Personally I would prefer if we rewrote the commits locally to be
formatted prior to submitting it into Phabricator. That way everything
stays in sync. Also usually clang-formatting a patch is the last thing
I want to do before submission anyway. And doing it now is kind of
annoying if you have a
On 12/15/18 1:35 PM, Xidorn Quan wrote:
Does it affect third-party crates? If there is a new warning hits a crate we
use, would that cause the build to fail? I suppose not, otherwise there needs
to be some additional policy to handle that case I gues?
It does not. Cargo is very helpful and
On Sat, Dec 15, 2018, at 9:44 PM, Emilio Cobos Álvarez wrote:
> In https://bugzilla.mozilla.org/show_bug.cgi?id=1513009 I just landed a
> patch so that warnings for non-third-party Rust code get reported as
> errors in automation, and thus fail to build (also if you build locally
> with
I think we should aim at option b) (updated automatically by bots after
submission to Phabricator)
We have more and more tools at review phase (clang-format, flake8,
eslint, clang-tidy, codespell, etc) which propose some auto-fixes.
Currently, the turn around time of the tools is 14m on
On Fri, Dec 14, 2018 at 1:58 PM Sylvestre Ledru wrote:
> We have more and more tools at review phase (clang-format, flake8, eslint,
> clang-tidy, codespell, etc) which propose some auto-fixes.
Honestly I find it quite annoying when I'm trying to review a patch
and the phabricator diff is filled
Thanks for this Philip.
I have started raising bugs and blocking
https://bugzilla.mozilla.org/show_bug.cgi?id=1498357.
David
On Fri, 14 Dec 2018 at 08:41, Philip Jägenstedt wrote:
> On Fri, Oct 19, 2018 at 2:42 PM Philip Jägenstedt
> wrote:
> >
> > On Wed, Oct 17, 2018 at 11:53 PM Boris
That's fantastic, there's a lot to triage but hopefully it's well worth it.
If you create any ad-hoc mapping between failures and bugs, please comment
on https://github.com/web-platform-tests/wpt.fyi/issues/64 and perhaps we
can populate using that data when the linking feature exists. +Luke
In https://bugzilla.mozilla.org/show_bug.cgi?id=1513009 I just landed a
patch so that warnings for non-third-party Rust code get reported as
errors in automation, and thus fail to build (also if you build locally
with --enable-warnings-as-errors).
This is the equivalent of what we already do
9 matches
Mail list logo
