Intent to implement and ship: CSS 'prefers-color-scheme' media feature

2019-02-15 Thread Mats Palmgren
Summary: The 'prefers-color-scheme' media feature is way for pages to detect if the user prefers a light or dark color theme. The values are 'light', 'dark', and 'no-preference'. If the "resist fingerprinting" feature is active we always match 'light'. If the media type is 'print' we always

Re: try pushes: use a base revision from 2019-02-06 or newer

2019-02-15 Thread Randell Jesup
>On 2/12/19 9:15 PM, Randell Jesup wrote: >>> if you push to the Try server, use base revisions (= the shared revision on >>> top of which you add your changes) from 2019-02-06 or newer, else there >>> will be many test failures due to expired certificates. The newer base >>> revisions have the

Re: Type-based alias analysis and Gecko C++

2019-02-15 Thread Ted Mielczarek
On Fri, Feb 15, 2019, at 4:00 AM, Henri Sivonen wrote: > How committed are we to -fno-strict-aliasing? FWIW, some work was done to investigate re-enabling strict aliasing a while ago but it proved untenable at the time: https://bugzilla.mozilla.org/show_bug.cgi?id=414641 -Ted

Re: Type-based alias analysis and Gecko C++

2019-02-15 Thread Jason Orendorff
On Fri, Feb 15, 2019 at 8:43 AM David Major wrote: > [...] If we can easily remove (or reduce) uses of this flag, I think > that would be pretty uncontroversial. > It sounds risky to me. My impression is we have a lot of TBAA violations, which would make every compiler version bump a game of UB

Re: Fission Engineering Newsletter #1

2019-02-15 Thread Neha Kochar
>> Are you including bugs that are about reducing our memory usage >> with more processes? What about doing better sandboxing of the content >> process (e.g. ensuring a compromised process can't request information >> from the parent that isn't relevant to it)? > This is

Re: Type-based alias analysis and Gecko C++

2019-02-15 Thread David Major
I don't think anyone wants to allow aliasing merely for its own sake. A lot of these flags were added just to keep builds working in the face of noisy compilers a long time ago. It would be good to retest with our current codebase and current compilers and see where we stand. If we can easily

Type-based alias analysis and Gecko C++

2019-02-15 Thread Henri Sivonen
I happened to have a reason to run our build system under strace, and I noticed that we pass -fno-strict-aliasing to clang. How committed are we to -fno-strict-aliasing? If we have no intention of getting rid of -fno-strict-aliasing, it would make sense to document this at