Re: Must we rebuild all our rust code constantly?

2019-08-19 Thread Jörg Knobloch
Hi all, I'm not sure whether Thunderbirds are different, but the issue is that (on Windows) xul.dll is constantly relinked although there haven't been any changes to C++ or RS files. Log below. Oh, you can also see some ugly hunspell warnings that have crept in a while ago. Jörg. $ mach

Re: Must we rebuild all our rust code constantly?

2019-08-19 Thread Kris Maglione
On Tue, Aug 20, 2019 at 02:23:06PM +0900, ISHIKAWA,chiaki wrote: On 2019/08/20 9:11, Dave Townsend wrote: Thanks to a tip I've tracked this down. This seems to only be the case when I have sccache enabled. Disabling it gives me nice quick incremental builds again. Of course that isn't an ideal

Re: Must we rebuild all our rust code constantly?

2019-08-19 Thread ISHIKAWA,chiaki
On 2019/08/20 9:11, Dave Townsend wrote: Thanks to a tip I've tracked this down. This seems to only be the case when I have sccache enabled. Disabling it gives me nice quick incremental builds again. Of course that isn't an ideal solution but it will do for now. On Mon, Aug 19, 2019 at 1:55 PM

Re: Must we rebuild all our rust code constantly?

2019-08-19 Thread Adam Gashlin
Is this https://bugzilla.mozilla.org/show_bug.cgi?id=1427313 ? On Mon, Aug 19, 2019 at 5:27 PM Kris Maglione wrote: > This is apparently a known bug that no-one seems to be able to > track down the cause of. It suddenly started happening to me one > night for every build, even if I changed

Re: Must we rebuild all our rust code constantly?

2019-08-19 Thread Kris Maglione
This is apparently a known bug that no-one seems to be able to track down the cause of. It suddenly started happening to me one night for every build, even if I changed nothing. Then, just as suddenly, stopped happening after a couple of hours. On Mon, Aug 19, 2019 at 05:11:19PM -0700, Dave

Re: Must we rebuild all our rust code constantly?

2019-08-19 Thread Dave Townsend
Thanks to a tip I've tracked this down. This seems to only be the case when I have sccache enabled. Disabling it gives me nice quick incremental builds again. Of course that isn't an ideal solution but it will do for now. On Mon, Aug 19, 2019 at 1:55 PM Dave Townsend wrote: > For a couple of

Re: Must we rebuild all our rust code constantly?

2019-08-19 Thread Simon Sapin
On 20/08/2019 00:20, Simon Sapin wrote: It would be good to have steps to reproduce the issue. Then Cargo’s debug logs should show what it thinks is out of date. Running with a CARGO_LOG=cargo::core::compiler::fingerprint environment variable should show some relevant information. -- Simon

Re: Must we rebuild all our rust code constantly?

2019-08-19 Thread Simon Sapin
On 19/08/2019 22:55, Dave Townsend wrote: For a couple of weeks now I've seen that any attempt to build Firefox, even incremental builds seem to rebuild an awful lot of rust code. I found this in the source which seems to suggest why:

PSA: Removing display:-moz-inline-grid and -moz-inline-stack

2019-08-19 Thread Mats Palmgren
In bug 1574994, I'm removing the display:-moz-inline-grid/stack values. (They are inline-level versions of display:-moz-grid/stack XUL boxes which we continue to support, for now). These values are not exposed to web-content and there are no internal uses in mozilla-central nor comm-central.

Must we rebuild all our rust code constantly?

2019-08-19 Thread Dave Townsend
For a couple of weeks now I've seen that any attempt to build Firefox, even incremental builds seem to rebuild an awful lot of rust code. I found this in the source which seems to suggest why: https://searchfox.org/mozilla-central/source/config/makefiles/rust.mk#238. But, this means that now an

Re: Intent to ship: multi-keyword values on the CSS 'display' property

2019-08-19 Thread Mats Palmgren
On 8/14/19 6:52 PM, Boris Zbarsky wrote: On 8/14/19 12:37 PM, Mats Palmgren wrote: This first patch set adds support for the new syntax only, but no new box types (I'll add those separately in a bit). In general, it seems like we should think about how to integrate this stuff into layout in

MOZ_LOG_FILE filename intended to be automatically and irrevocably appended `.mozlog` extension

2019-08-19 Thread Honza Bambas
I'm about to land a patch that will automatically add `mozlog` extension to all log files from all processes produced with MOZ_LOG/_FILE env vars, command line args or via about:networking#logging.  It **will not** be possible to remove that extension by setting custom extensions, like

Re: Fission Newsletter #2

2019-08-19 Thread Henrik Skupin
Nika Layzell wrote on 09.08.19 19:33: >Wait for document loads to complete before trying to run code inside the >target window, as a process switch may occur after the frame or browser is >created. For frames in content, this usually means waiting for the load >event. While

[desktop] Bugs logged by Desktop Release QA in the last 7 days

2019-08-19 Thread Mihai Boldan
Hello, Here's the list of new issues found and filed by the Desktop Release QA team in the last 7 days. Additional details on the team's priorities last week, as well as the plans for the current week are available at: https://tinyurl.com/y28kjp78. Bugs logged by Desktop Release QA in the