Re: Does mozilla allow modification of Strings

2019-02-01 Thread Kris Maglione
On Tue, Jan 29, 2019 at 02:08:59AM -0800, Nanday Dan wrote: On Tuesday, January 29, 2019 at 12:22:08 AM UTC+5:30, Kris Maglione wrote: >Is it possible to add an extra variable to mozilla string(nsTStringRepr). > > >I added a bool variable to nsTStringRepr class in Xpcom/Strings/

Re: Intent to ship: Devirtualizing IPC method calls (bug 1512990)

2019-02-04 Thread Kris Maglione
On Mon, Feb 04, 2019 at 04:29:54PM -0500, Alex Gaynor wrote: b) Memory -- we no longer need to emit vtables for all of these methods (~20 KB per process) \o/ c) Ergonomics -- implementing classes will now have control over whether they take arguments by value or reference \o/ Thank you :)

Re: Change to preferences via StaticPrefs, tremoval of gfxPrefs

2019-05-15 Thread Kris Maglione
On Wed, May 15, 2019 at 07:02:58PM -0400, Botond Ballo wrote: On Wed, May 15, 2019 at 6:54 PM Jean-Yves Avenard wrote: It is then up to each process to handle preference modifications and pass that change. There's no automatic or universal method on how this is done unfortunately. Will

Re: Running C++ early in shutdown without an observer

2019-06-07 Thread Kris Maglione
On Fri, Jun 07, 2019 at 09:18:38AM +0300, Henri Sivonen wrote: For late shutdown cleanup, we have nsLayoutStatics::Shutdown(). Do we have a similar method for running things as soon as we've decided that the application is going to shut down? (I know there are observer topics, but I'm trying to

Re: Running C++ early in shutdown without an observer

2019-06-07 Thread Kris Maglione
On Fri, Jun 07, 2019 at 11:40:05AM -0700, Chris Peterson wrote: Note that on Android, you may never get an opportunity for a clean shutdown because the OS can kill your app at any time. I don't know what is the recommendation for shutdown activities on Android. The GeckoView team has had some

Re: Resolving URLs in c++

2019-07-12 Thread Kris Maglione
On Thu, Jul 11, 2019 at 10:57:05PM -0700, mcace...@mozilla.com wrote: Was looking at how WebKit implements the WebShare API, and they have this nice method `completeURL(str)` [1] that resolved URLs relative to, I guess, the `Document` object (or whatever context is). So they can basically do

Re: PSA: mozilla::Result is about to understand move semantics

2019-08-13 Thread Kris Maglione
Kris Maglione wrote: On Mon, Aug 12, 2019 at 10:14:19PM -0700, Bryce Seager van Dyk wrote: >>But either way, that's going to result in a copy when the >>Result is constructed (unless the compiler is really clever). > >Is it the data being moved into the Result which is incurr

Re: PSA: mozilla::Result is about to understand move semantics

2019-08-13 Thread Kris Maglione
On Mon, Aug 12, 2019 at 10:14:19PM -0700, Bryce Seager van Dyk wrote: But either way, that's going to result in a copy when the Result is constructed (unless the compiler is really clever). Is it the data being moved into the Result which is incurring the copy here, or the actual Result

Re: PSA: mozilla::Result is about to understand move semantics

2019-08-12 Thread Kris Maglione
On Mon, Aug 12, 2019 at 11:16:17PM +0200, Emilio Cobos Álvarez wrote: On 8/12/19 10:38 PM, Bryce Seager van Dyk wrote: On Monday, August 12, 2019 at 8:41:26 AM UTC-7, Emilio Cobos Álvarez wrote: Neat! Thanks for doing this. It should allow for broader use of Result in media code. Are there

Re: Must we rebuild all our rust code constantly?

2019-08-19 Thread Kris Maglione
This is apparently a known bug that no-one seems to be able to track down the cause of. It suddenly started happening to me one night for every build, even if I changed nothing. Then, just as suddenly, stopped happening after a couple of hours. On Mon, Aug 19, 2019 at 05:11:19PM -0700, Dave

Re: Must we rebuild all our rust code constantly?

2019-08-19 Thread Kris Maglione
On Tue, Aug 20, 2019 at 02:23:06PM +0900, ISHIKAWA,chiaki wrote: On 2019/08/20 9:11, Dave Townsend wrote: Thanks to a tip I've tracked this down. This seems to only be the case when I have sccache enabled. Disabling it gives me nice quick incremental builds again. Of course that isn't an ideal

Re: Nika Layzell and Kris Maglione are now XPCOM peers

2019-09-05 Thread Kris Maglione
On Wed, Sep 4, 2019, 11:33 Nathan Froyd Kris noticed that Nika was going to become an XPCOM peer and, not > wanting to be left out, volunteered (yes, really). Kris has worked on > modernizing the component manager and various thread-related > improvements. > To be clear, I volunteered because

Re: Native actor refcounting support in IPDL

2019-08-01 Thread Kris Maglione
\o/ This is going to get rid of so much (often buggy, potentially leaky, and slightly varying) boilerplate from most of our IPC code. Thanks! On Thu, Aug 01, 2019 at 03:11:00PM -0400, Nika Layzell wrote: Bug 1550560 (https://bugzilla.mozilla.org/show_bug.cgi?id=1550560) landed recently,

Re: Non-header-only headers shared between SpiderMonkey and the rest of Gecko

2019-08-06 Thread Kris Maglione
On Tue, Aug 06, 2019 at 10:56:55AM +0300, Henri Sivonen wrote: Do we have some #ifdef for excluding parts of mfbt/ when mfbt/ is being used in a non-SpiderMonkey/Gecko context? #ifdef MOZ_HAS_MOZGLUE ___ dev-platform mailing list

Re: Fission Newsletter #2

2019-08-09 Thread Kris Maglione
On Fri, Aug 09, 2019 at 01:33:31PM -0400, Nika Layzell wrote: Tests which do not currently successfully pass are marked as fail-if = Fission or skip-if = Fission. To be slightly pedantic, they're marked as `fail-if = fission` or `skip-if = fission`. mozinfo expression matching should be case

PSA: Fission mochitests will soon run on integration branches

2019-07-26 Thread Kris Maglione
Within the next few days, mochitests will run with Fission enabled (in the M-fis job) on every check-in. The tests will run as Tier 2, so new failures will not cause immediate backout, but will still need to be fixed. In order to get tests running as soon as possible, so that we can spot new

Re: Intent to remove: Fennec

2019-09-24 Thread Kris Maglione
, again, that would just not be a good use of resources. -- Kris Maglione UNIX is simple. It just takes a genius to understand its simplicity. --Dennis Ritchie ___ dev-platform mailing list dev-platform@lists.mozilla.org https

Fission Mochitests moving to tier 1 and must all† pass by October 31st

2019-10-01 Thread Kris Maglione
Fission Milestone 4 is focused on getting all mochitests running and passing with Fission enabled. The deadline for the end of this milestone is October 31st, approximately one month from today, and we still have a significant amount of work to do, with about 350 mochitests skipped and about

Re: Consider avoiding allSettled in tests (was: Re: Intent to ship: Promise.allSettled)

2019-11-01 Thread Kris Maglione
On Thu, Oct 31, 2019, 06:02 Jason Orendorff wrote: > Ignoring the awaited value here is like using `catch {}` to squelch all > exceptions, or ignoring the return value of an async function or method, or > any other expression that produces a Promise. Do we have lints for those > pitfalls? I'm

Re: How best to do async functions and XPCOM?

2019-12-12 Thread Kris Maglione
On Fri, Dec 06, 2019 at 11:20:12AM +1300, Geoff Lankow wrote: Hi all I'm redesigning a bunch of Thunderbird things to be asynchronous. I'd like to use Promises but a lot of the time I'll be far from a JS context so that doesn't really seem like an option. The best alternative I've come up

Re: How best to do async functions and XPCOM?

2019-12-12 Thread Kris Maglione
On Sun, Dec 08, 2019 at 11:40:52PM -0500, Joshua Cranmer  wrote: The problem with MozPromise is that it doesn't integrate well if you use XPIDL interfaces, so you have this annoying issue that if you want to use XPIDL integration, you have to use mozilla::dom::Promise, which is annoying to

PSA: Please clear weak reference to cycle collected objects on unlink

2020-02-25 Thread Kris Maglione
Accessing an object after it has been unlinked by the cycle collector is a certain way to cause trouble. Usually, that trouble is just in the form of null pointer crashes, but it can potentially be much worse. And the most common cause of those types of issues comes from accessing a weak

Intent to Unship: in content

2020-02-14 Thread Kris Maglione
in non-chrome documents has been unsupported in production environments for some time. Maintaining support for it in content processes has become increasingly difficult in the light of Fission, to the point that we've decided it is time to fully remove support. Since support is disabled by

Re: How best to do async functions and XPCOM?

2020-01-08 Thread Kris Maglione
On Thu, Dec 12, 2019 at 09:30:06AM -0500, Boris Zbarsky wrote: On 12/10/19 3:31 PM, Kris Maglione wrote: In what way is dom::Promise annoying to use from C++? The one thing I know about that's pretty annoying is if you receive the promise from someone else and want to add reactions

<    1   2   3