Re: Commit messages in Phabricator

[Piotr Zalewa]

Hi Emilio,

Landing using upcoming "Lando" will use the following format
(taken from
https://github.com/mozilla-conduit/lando-api/blob/master/landoapi/commit_message.py#L21)
:

```
 -  r=,r=



Differential Revision: 
```

"Test Plan" is describing the steps to test the patch by the reviewer.

"Subscribers" is a list of users author would like to subscribe to the
revision.

zalun

On Sun, Feb 11, 2018 at 9:57 PM Emilio Cobos Álvarez 
wrote:

> Hey,
>
> So I've been testing Phabricator for a while and I've noticed that the
> arc tool uses different formatting for the commit messages than what
> usually lands on mozilla-central.
>
> In particular I usually lay out my commits like:
>
> ---
> Bug XXX: Short summary. r=
>
> Long description, if needed.
> ---
>
> Arc wants to use something like:
>
> ---
> Short summary.
>
> Summary:
> Long description (I assume?).
>
> Test Plan: (what goes here?)
>
> Reviewers: 
>
> Subscribers: (what goes here?)
>
> Bug #: XXX
>
> Differential revision: https://phabricator.services.mozilla.com/D574
> ---
>
> I've been manually fixing them up before committing them so they have
> the usual format when landing.
>
> My question is: Are commits that are going to land to autoland from
> phabricator directly going to land with the new format?
>
> Should we keep fixing them up before pushing to autoland / inbound, or
> should we start pushing commits with the new commit message formatting?
>
> Also, knowing an answer for the (what goes here?) questions would be
> super-helpful.
>
> Thanks a lot!
>
>   -- Emilio
> ___
> dev-platform mailing list
> dev-platform@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-platform
>
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Git supported in moz-phab

[Piotr Zalewa]

We've just added Git support to moz-phab. The tool uses Arcanist to submit
a stack of commits to the Phabricator for further review.

For Phabricator and Arcanist instructions see the "Mozilla Phabricator User
Guide" - https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

moz-phab determines the commit range automatically and asks you for
confirmation before proceeding. If you're not happy with the result, you
can either use the `--upstream` attribute to specify the remote or specify
the range using the commit SHA1. Please read the installation and usage
directions - https://github.com/mozilla-conduit/review/blob/master/README.md

Bugs can be filed under "Conduit :: Review Wrapper" -
https://bugzilla.mozilla.org/enter_bug.cgi?product=Conduit=Review%20Wrapper

#phabricator (IRC/Slack) for direct support.

Please keep in mind the current version has still some limitations which we
are actively working on, some of which are:

   -

   Allow for history splits within the stack. (bug 1497714)
   -

   Add support for group reviewers (bug 1488108)
   -

   moz-phab changes r= to r? after review is granted  (bug 1494850)


We are also continuing to investigate performance issues (bugs 1491267 and
1494697).

A full list of moz-phab bugs:
https://bugzilla.mozilla.org/buglist.cgi?component=Review+Wrapper=Conduit
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Secure revisions can be landed with Lando

[Piotr Zalewa]

We've just added support for landing secure revisions to Lando.

To access a secure revision in Lando, you need to provide an API token.
Lando will save it for the login session only. The API token allows anybody
with access to it to perform actions on your behalf. It is important not to
store your API token anywhere but in Lando or on the Phabricator site.

See the manual for instructions -
https://moz-conduit.readthedocs.io/en/latest/lando-user.html#viewing-a-confidential-revision


-- 
Piotr Zalewa (zalun)
Mozilla
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Using MozPhab without Arcanist

[Piotr Zalewa]

Hi all,

Since today MozPhab does not require Arcanist to submit patches in all
supported VCS's. It's an optional and experimental feature. Add the
`--no-arc` option to switch it on.

Feel free to use it and report any bugs the usual way -
https://bugzilla.mozilla.org/enter_bug.cgi?product=Conduit=moz-phab

Let's all hope not using Arcanist will soon become the default.
-- 
Piotr Zalewa (zalun)
Mozilla
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform