Intent to prototype and ship: make width and height map to aspect-ratio for , and

2021-03-24 Thread Emilio Cobos Álvarez
Summary: We do this for already, and HTML was changed a while ago to do this for / / . It seems like an uncontroversial change. Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1700640 Standard: https://html.spec.whatwg.org/#attributes-for-embedded-content-and-images > The width and

Re: printf_stderr now works out of the box on Windows

2021-03-19 Thread Emilio Cobos Álvarez
On 3/19/21 21:12, Jeff Muizelaar wrote: 15 years ago we landed a change to make printf_stderr reopen fd 2 instead of using stderr directly to work around a linking issue. This prevented printf_stderr from showing up in the console on Windows. I landed

Intent to prototype and ship: Make mac mouse focus model closer to other platforms

2021-03-17 Thread Emilio Cobos Álvarez
Summary: Mac currently doesn't focus form controls (like buttons) with the mouse. This follows Safari's platform convention, however it also means that Firefox behaves inconsistently for web developers across platforms. I plan to enable the accessibility.mouse_focuses_formcontrol pref (only

Re: Intent to ship: Return pixel deltas in wheel event if deltaMode is not checked by authors

2021-03-09 Thread Emilio Cobos Álvarez
On 3/9/21 20:36, James Graham wrote: It seems like having all browsers have the same behaviour is going to be better in the long run than having some weird heuristic in gecko that acts as a footgun for authors going forward. Do we have any way to assess the compat impact of switching to

Re: Intent to ship: Return pixel deltas in wheel event if deltaMode is not checked by authors

2021-03-09 Thread Emilio Cobos Álvarez
On 3/9/21 17:10, Anne van Kesteren wrote: On Tue, Mar 9, 2021 at 4:45 PM Emilio Cobos Álvarez wrote: Let me know if you have any concerns with this or what not. So if I understand it correctly we'll have a getter with side effects. Is the expectation that we can eventually remove

Intent to ship: Return pixel deltas in wheel event if deltaMode is not checked by authors

2021-03-09 Thread Emilio Cobos Álvarez
Hi, In bug 1696384, I plan to enable dom.event.wheel-deltaMode-lines.disabled on all channels. This is a compat intervention for sites that check WheelEvent.delta{X,Y,Z} before checking WheelEvent.deltaMode, generally assuming that the deltas are going to be pixels. These deltas are

Intent to prototype: CSS color-mix() function.

2021-02-26 Thread Emilio Cobos Álvarez
Summary: Hi, In bug 1695376, if all goes well, I plan to land a basic version of the color-mix() function. This is a trimmed down version of the spec (link below). Firefox engineers requested this, and I also think this minimal version is super-useful on its own, without being blocked on

Re: Intent to prototype and ship: :user-valid and :user-invalid pseudo-classes.

2021-02-23 Thread Emilio Cobos Álvarez
On 2/23/21 09:24, Anne van Kesteren wrote: On Mon, Feb 22, 2021 at 2:59 PM Emilio Cobos Álvarez wrote: Let me know if you have any objections about this change, but I think having a prefixed pseudo-class for this is not a great state of affairs. This seems reasonable, but I think we should

Re: Intent to prototype and ship: :user-valid and :user-invalid pseudo-classes.

2021-02-23 Thread Emilio Cobos Álvarez
On 2/23/21 11:52, Xidorn Quan wrote: Please head up in CSS working group about this, and probably ask for a resolution on no objection for us to ship it, as this spec is still in draft. Hmm, is it? https://www.w3.org/TR/selectors-4/#user-pseudos has had :user-invalid for quite a while, and

Intent to ship: make outlines follow border-radius automatically

2021-02-22 Thread Emilio Cobos Álvarez
to the original change it should ship in Firefox 88. -- Emilio On 2/9/21 00:37, Emilio Cobos Álvarez wrote: Summary: Hi, In bug 315209 I landed a patch to get outlines to follow the border-radius of the element automatically. It should be enabled in Nightly for now. There's some (a lot

Intent to prototype and ship: :user-valid and :user-invalid pseudo-classes.

2021-02-22 Thread Emilio Cobos Álvarez
Hi, In bug 1694141 I plan to unprefix :-moz-ui-valid and :-moz-ui-invalid pseudo-classes. These are useful pseudo-classes to determine when to show feedback to the user about a form control being invalid. Standard: https://drafts.csswg.org/selectors/#user-pseudos Platform coverage: all

Intent to unship: :-moz-submit-invalid pseudo-class.

2021-02-22 Thread Emilio Cobos Álvarez
No other browser supports anything like this, and we don't even have internal uses of this pseudo-class. Only uses of this I've found on the wild were just resetting the box shadow internal styling we added in bug 582277 (and since removed in bug 600151). I plan to put this behind a

Intent to unship: Non-standard values of caption-side property

2021-02-16 Thread Emilio Cobos Álvarez
Hi, In bug 1688695 we've added a pref to unship the non-standard values of caption-side property: left | right | top-outside | bottom-outside These values are not implemented by any other engine, and are not in any specification as of today. There was some discussion on here as of 2016

Intent to prototype and ship: Make elements not traversable

2021-02-08 Thread Emilio Cobos Álvarez
(I forgot to send an intent for this a couple weeks ago) Summary: This is a bit of a mess, see [1][2]. TLDR: * Gecko treated elements like anchors, in the sense that if you display them, we allowed you to click around, etc. This meant also supporting :link / :visited on them, and such. We

Intent to prototype: make outlines follow border-radius automatically

2021-02-08 Thread Emilio Cobos Álvarez
Summary: Hi, In bug 315209 I landed a patch to get outlines to follow the border-radius of the element automatically. It should be enabled in Nightly for now. There's some (a lot) of context in the bug, but TLDR: * Long-standing request. * Safari does this for outline-style: auto, and

PSA: Non-native theme turned on for Linux Nightlies

2021-01-30 Thread Emilio Cobos Álvarez
(+firefox-dev for visibility, but please reply to dev-platform), Hey, Just a PSA that the themed form controls on Linux Nightly are going to change soonish (when bug 1689359[1] is merged to central). This is controlled by the widget.disable-native-theme-for-content pref. You can turn it on

Intent to ship: Unprefixed :autofill pseudo-class, :-webkit-autofill alias.

2021-01-08 Thread Emilio Cobos Álvarez
AM, Emilio Cobos Álvarez wrote: Summary: I plan to prototype a standard :autofill pseudo-class, for two reasons  * We have an internal :-moz-autofill pseudo-class, and webkit-based browsers have a publicly-exposed :-webkit-autofill counter-part.  * We have a fair amount of compat reports

Intent to prototype: CanvasRenderingContext2D.createConicGradient.

2020-12-31 Thread Emilio Cobos Álvarez
Sending this on behalf of the contributor that submitted the patch. Summary: Implement a method analogous to createLinearGradient and createRadialGradient for canvas. Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1627014 Standard: https://github.com/whatwg/html/issues/5431 Platform

Intent to prototype: Standard :autofill pseudo-class, :-webkit-autofill alias.

2020-12-09 Thread Emilio Cobos Álvarez
Summary: I plan to prototype a standard :autofill pseudo-class, for two reasons * We have an internal :-moz-autofill pseudo-class, and webkit-based browsers have a publicly-exposed :-webkit-autofill counter-part. * We have a fair amount of compat reports of people forgetting

Intent to Ship: :focus-visible pseudo-class

2020-11-18 Thread Emilio Cobos Álvarez
Summary: Implement the :focus-visible pseudo-class and effectively make :-moz-focusring an alias of it. This is intended to simplify the way authors deal with outlines to improve accessibility. In particular, authors seem to hate outlines when users focus stuff with the mouse, generally and

Re: Intent to Ship: Make wheel event listeners passive by default on the root

2020-10-28 Thread Emilio Cobos Álvarez
On 10/28/20 11:18 AM, Anne van Kesteren wrote: On Mon, Oct 26, 2020 at 5:45 PM Emilio Cobos Álvarez wrote: Standard: None, this is an intervention, though https://w3c.github.io/uievents/#cancelability-of-wheel-events is loosely related. I'm not sure "it's an intervention" is

Intent to Ship: Make wheel event listeners passive by default on the root

2020-10-26 Thread Emilio Cobos Álvarez
Summary: Make wheel / DOMMouseScroll / MozMousePixelScroll event listeners on the root passive by default. This effectively aligns with Chromium (see [1]), and with touchstart / touchmove events. Bug: 1673278 Standard: None, this is an intervention, though

Re: Intent to ship: Implement :-moz-any() as an alias of :is()

2020-09-21 Thread Emilio Cobos Álvarez
. Once :-moz-any usage is removed from the codebase (there's a patch under review) I can add a use counter and see how often it's hit on content, to consider removing it eventually if feasible. -- Emilio -tom On Sat, Sep 19, 2020 at 3:36 PM Emilio Cobos Álvarez wrote: Summary: Implement

Intent to ship: Implement :-moz-any() as an alias of :is()

2020-09-19 Thread Emilio Cobos Álvarez
Summary: Implement the legacy :-moz-any selector as an alias of :is(). This means that it'll be more powerful, and also simpler to maintain for us. This has been enabled in 81 beta/nightly and for the whole 82 cycle with no regriessions so far, see bug 561154. This means that it will accept

Intent to prototype: Allow :is() and :where() to have better selector error recovery.

2020-09-13 Thread Emilio Cobos Álvarez
Summary: Allow invalid selectors inside :is() and :where() to be ignored, rather than making the whole selector list invalid. This would allow to have some sort of escape hatch for the usual footgun of "one invalid selector in the list makes the whole style rule invalid", which is generally

Intent to Ship: ::file-selector-button pseudo-element

2020-09-01 Thread Emilio Cobos Álvarez
See the original intent to implement for ::file-chooser-button here: https://groups.google.com/g/mozilla.dev.platform/c/70ODk1Gqrzs/m/CBLgePEkAAAJ I plan to rename it and enable it by default for Firefox 82 (it's enabled in Nightly / Beta only right now) as per the resolution in:

Intent to unship: ::-moz-focus-outer pseudo-element.

2020-07-28 Thread Emilio Cobos Álvarez
Hi, In bug 1655859, I intend to disable parsing for ::-moz-focus-outer on all channels. This pseudo-element used to be an specific pseudo-element to show some focus outlines, but it does literally nothing anymore (other than being parsed), after the changes in bug 1636998. As part of

Re: New Bugzilla component for keeping comm-central in sync with mozilla-central

2020-07-07 Thread Emilio Cobos Álvarez
On 7/7/20 4:11 PM, Tom Ritter wrote: Hey Geoff - what sorts of things would be appropriate to file there? Or perhaps as a more basic question - what *is* comm-central? Is it 'mozilla-central with constantly-rebased Thunderbird patches on top?' Is it an old fork of mozilla-central where a lot (or

Re: Proposal: remove support for running desktop Firefox in single-process mode (e10s disabled) anywhere but in tests

2020-06-10 Thread Emilio Cobos Álvarez
What is the situation of Thunderbird? I think they don't have e10s enabled yet, and it may be worth at least knowing what their plans are. -- Emilio On Wed, Jun 10, 2020, 8:44 PM Dave Townsend wrote: > Non-e10s is such a different environment that I don't think we have any > hope of keeping

Intent to unship: prefers-color-scheme:no-preference value.

2020-06-09 Thread Emilio Cobos Álvarez
Following this CSS resolution[1], I intend to remove the no-preference value for the prefers-color-scheme media query in bug 1643656[2]. For context, this value never matches in any browser (unless the user overrides a hidden pref), and was relatively recently introduced, so the idea is that

Intent to prototype: ::file-chooser-button

2020-05-20 Thread Emilio Cobos Álvarez
*Summary:* Add a pseudo-element to file inputs in order to expose the internal "Browse" button. Since there's no spec yet, and the name might change, I plan to /not/ ship it just yet, and keep it Nightly / Dev Edition only for now until the dust settles. *Bug:* bug 1635675

Re: Cargo.lock in hg repository?

2020-05-19 Thread Emilio Cobos Álvarez
/6db4b71d0c20 -- Emilio Chiaki On 2020/05/18 1:08, Emilio Cobos Álvarez wrote: I see this too, I think it's a rebase messup between bug 1631630 and bug 1636068.  -- Emilio On 5/17/20 2:44 PM, ISHIKAWA,chiaki wrote: I am developing TB patches locally on my linux PC. Have anyone noticed

Re: Cargo.lock in hg repository?

2020-05-17 Thread Emilio Cobos Álvarez
I see this too, I think it's a rebase messup between bug 1631630 and bug 1636068.  -- Emilio On 5/17/20 2:44 PM, ISHIKAWA,chiaki wrote: I am developing TB patches locally on my linux PC. Have anyone noticed mozilla/Cargo.lock seems to be in mercurial repository and that it got updated

Re: Intent to ship: :read-only / :read-write pseudo-classes

2020-05-13 Thread Emilio Cobos Álvarez
/ breaking changes.  -- Emilio On 5/14/20 2:19 AM, Emilio Cobos Álvarez wrote: *Summary: *Make our :-moz-read-only / :-moz-read-write pseudo-classes match the spec, and un-prefix them. *Bug: *Bug 312971 <https://bugzil.la/312971> *Standard: *https://html.spec.whatwg.org/#selector-rea

Intent to ship: :read-only / :read-write pseudo-classes

2020-05-13 Thread Emilio Cobos Álvarez
*Summary: *Make our :-moz-read-only / :-moz-read-write pseudo-classes match the spec, and un-prefix them. *Bug: *Bug 312971 *Standard: *https://html.spec.whatwg.org/#selector-read-only // *Platform coverage: *All

Re: Intent to prototype and ship: CSS :is() and :where() pseudo-classes.

2020-04-17 Thread Emilio Cobos Álvarez
On 4/18/20 1:49 AM, Emilio Cobos Álvarez wrote:  * Safari: Implemented in TP. They have shipped since forever an outdated version of the spec (:matches instead of :is). Clarification: It seems WebKit only supports :is(), not :where(). -- Emilio

Intent to prototype and ship: CSS :is() and :where() pseudo-classes.

2020-04-17 Thread Emilio Cobos Álvarez
Someone nerd-sniped me this week, sorry :) Summary: Implements the :is() and :where() pseudo-classes from the CSS selectors level 4 spec. These allow to adjust the specificity of selectors and write selectors that weren't possible before. Bug:

Re: Editor / IDE integration docs

2020-04-13 Thread Emilio Cobos Álvarez
/CodingStandards [4]: https://wiki.mozilla.org/WebExtensions/Hacking#Vim On 4/13/20 11:52 PM, Emilio Cobos Álvarez wrote: Hey, A semi-frequent question in #developers or #introduction is to ask about which IDE or editor people use, or how to get X working on Y editor, etc. I've sent a patch

Editor / IDE integration docs

2020-04-13 Thread Emilio Cobos Álvarez
Hey, A semi-frequent question in #developers or #introduction is to ask about which IDE or editor people use, or how to get X working on Y editor, etc. I've sent a patch to document what I know to: https://bugzilla.mozilla.org/show_bug.cgi?id=1629445 Which is already on autoland. But I

Re: Intent to implement and ship: Ignore navigation to unknown protocol

2020-03-30 Thread Emilio Cobos Álvarez
that information. I just filed bug 1626068 to potentially try to minimize this. -- Emilio Thanks! On Sun, Mar 29, 2020 at 12:29 AM Emilio Cobos Álvarez wrote: On 3/29/20 9:11 AM, Emilio Cobos Álvarez wrote: Doing a bit of digging, https://bugzilla.mozilla.org/show_bug.cgi?id=680300 contains

Re: Intent to implement and ship: Ignore navigation to unknown protocol

2020-03-29 Thread Emilio Cobos Álvarez
On 3/29/20 9:11 AM, Emilio Cobos Álvarez wrote: Doing a bit of digging, https://bugzilla.mozilla.org/show_bug.cgi?id=680300 contains some more interesting context... We apparently used to sync-throw when assigning location.href to an unknown protocol URI in the past, there we changed

Re: Intent to implement and ship: Ignore navigation to unknown protocol

2020-03-29 Thread Emilio Cobos Álvarez
to an error page... I'll try to look at when behavior changed around here... Though the sync-throwing clearly makes no sense as it doesn't account for redirects or what not. -- Emilio On 3/29/20 8:23 AM, Emilio Cobos Álvarez wrote: Hey, a quick web-observable change that may deserve a bit more

Intent to implement and ship: Ignore navigation to unknown protocol

2020-03-29 Thread Emilio Cobos Álvarez
Hey, a quick web-observable change that may deserve a bit more visibility / an intent. I'd welcome some feedback, specially from the fingerprinting / privacy angle (where I'm clearly not an expert). Summary: A page redirecting / navigating to an unknown protocol will be silently ignored

Intent to prototype and ship: Make

2020-03-20 Thread Emilio Cobos Álvarez
This is more of a bugfix but I think an intent is warranted. Summary: Defer

Intent to prototype: :focus-visible pseudo-class.

2020-02-24 Thread Emilio Cobos Álvarez
Hi, In bug 1617600 I plan to land a patch to implement :focus-visible, behind a pref, on by default on Nightly / Early Beta. Summary: Implement the :focus-visible pseudo-class, which is like :focus, but with heuristics about when _not_ to show focus rings, for example. This is similar in

Re: Intent to prototype and ship: CSS comparison functions: min() / max() / clamp()

2020-02-21 Thread Emilio Cobos Álvarez
On 2/21/20 11:46 AM, James Graham wrote: On 21/02/2020 01:42, Emilio Cobos Álvarez wrote: web-platform-tests: There's a variety of tests in: https://wpt.fyi/results/css/css-values?label=master=experimental=minmax%7Cclamp Do we have any sense of how good the test coverage is? Pretty good

Intent to prototype and ship: CSS comparison functions: min() / max() / clamp()

2020-02-20 Thread Emilio Cobos Álvarez
Hi, In bug 1519519 I plan to enable the min() / max() / clamp() CSS functions by default. Summary: These functions allow authors to do what their name says :-) Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1519519 Standard: https://drafts.csswg.org/css-values-4/#comp-func Platform

Re: [blink-dev] Re: What to do about scroll anchoring?

2020-02-20 Thread Emilio Cobos Álvarez
on crbug.com/920289 <http://crbug.com/920289>. Let's discuss there. On Tue, Oct 29, 2019 at 3:03 PM Emilio Cobos Álvarez <mailto:emi...@mozilla.com>> wrote: Hi all,   10/18/19 7:19 PM, Chris Harrelson wrote: > Hi, > > Another quick update: Emi

Re: Intent to ship: native rendering of outline-style: auto

2020-01-16 Thread Emilio Cobos Álvarez
happy to hook outline-style: auto into them or what not. -- Emilio Emilio Cobos Álvarez mailto:emi...@mozilla.com>> schrieb am Mi., 15. Jan. 2020, 19:27: Hi, In bug 1031664 I plan to enable the themed rendering of outline-style: auto. Standard: https://www.w3.org/TR/

Intent to ship: native rendering of outline-style: auto

2020-01-15 Thread Emilio Cobos Álvarez
Hi, In bug 1031664 I plan to enable the themed rendering of outline-style: auto. Standard: https://www.w3.org/TR/css-ui/#outline-style (sorry for the TR version, but I have problems to access the current draft without building it locally :/) Platform coverage: Linux, Mac, Windows

Re: PSA: You can use UTF8String from WebIDL

2020-01-06 Thread Emilio Cobos Álvarez
On 1/6/20 11:12 AM, Jan de Mooij wrote: On Mon, Jan 6, 2020 at 2:51 AM Emilio Cobos Álvarez <mailto:emi...@mozilla.com>> wrote: If it's not, it could be optimized teaching JSStrings to store UTF-8 instead of / on top of Latin1 or such, or returning more information from t

PSA: You can use UTF8String from WebIDL

2020-01-05 Thread Emilio Cobos Álvarez
If you need UTF-8 inputs from WebIDL (for example if you are passing the input to Rust), chances are you're doing an extra copy from JS. In bug 1449861 I've added an UTF8String so that you can convert a JSString to UTF-8 in a single operation, instead of going through UTF-16. I can't think

Re: Intent to unship: @media (-moz-touch-enabled)

2019-12-09 Thread Emilio Cobos Álvarez
On 10/17/19 9:22 AM, Emilio Cobos Álvarez wrote: Hi all, In bug 1588737 I plan to remove access to the -moz-touch-enabled media feature. This is a non-standard media-query feature that predates the standard hover and any-hover media features. It seems that Modernizr (a fairly popular

Intent to Ship: CSS Shadow Parts.

2019-11-20 Thread Emilio Cobos Álvarez
As of soon (whenever the patches are reviewed) I intend to turn CSS Shadow Parts on by default on all platforms. It has been developed behind the layout.css.shadow-parts.enabled preference. Blink has shipped it for a while and Safari implements it in the latest TP and is enabled by default on

Re: PSA: changes to numerous DOM components on Bugzilla

2019-11-08 Thread Emilio Cobos Álvarez
On 11/8/19 10:26 AM, Anne van Kesteren wrote: Heya, In https://bugzilla.mozilla.org/show_bug.cgi?id=1594717 the DOM team requested quite a number of changes to their various components in Mozilla's Bugzilla. Those components are now prefixed with either "DOM:" or "Storage:". Please keep this in

Re: Upcoming changes to hg.mozilla.org access

2019-11-03 Thread Emilio Cobos Álvarez
On 11/2/19 12:53 PM, Andreas Tolfsen wrote: Documentation changes have historically been well served by a “wiki editing”/micro adjustments approach. I wonder if there is anything we can do with Phabricator to ease review requirements for documentation changes from peers? I think you can land

Re: [blink-dev] Re: What to do about scroll anchoring?

2019-10-29 Thread Emilio Cobos Álvarez
Hi all, 10/18/19 7:19 PM, Chris Harrelson wrote: Hi, Another quick update: Emilio, Navid, Nick, Stefan and I met today and discussed which issues are important to fix and why. We now have a list of spec issues, and WPT tests to fix that are Chromium bugs, that should substantially improve

Intent to unship: window.mozPaintCount.

2019-10-28 Thread Emilio Cobos Álvarez
In bug 1591968 I'm trying to add a default-off preference for window.mozPaintCount. This Gecko-only API returns the amount of times that a page has been painted to the window (sorta, it's a bit unclear what it is exactly counting, given the point of the code where the count is incremented[1],

Re: To what extent is sccache's distributed compilation usable?

2019-10-26 Thread Emilio Cobos Álvarez
On 10/25/19 2:54 AM, Marcos Caceres wrote: Do you know if it's possible to cross compile on one of those for to target MacOS? I'd like to build on, and for, MacOS. Our official mac builds are cross-compiled from Linux, IIRC. So yeah, it should be possible to do that. Cross-compiling to

Re: Using MozPhab without Arcanist

2019-10-23 Thread Emilio Cobos Álvarez
On 10/23/19 10:24 PM, Emma Humphries wrote: Will this make it easier for non-staff contributors to get their change sets reviewed and landed? What else should we be doing for that. I have some ideas I'm working on for views in Bugzilla to help with that so that contributors can see what's

Re: Intent to ship: CSS subgrid

2019-10-17 Thread Emilio Cobos Álvarez
On 10/18/19 12:31 AM, ikilpatr...@chromium.org wrote: ::marker (which seems like it was only shipped recently) probably should have been restricted to secure contexts by this policy? FWIW (regardless of my opinion about the policy which I've stated on another post) Safari does ship ::marker

Re: Intent to ship: CSS subgrid

2019-10-17 Thread Emilio Cobos Álvarez
On 10/17/19 10:02 PM, ikilpatr...@chromium.org wrote: On Thursday, October 17, 2019 at 12:47:27 PM UTC-7, Mats Palmgren wrote: On 10/17/19 8:12 PM, ikilpatr...@chromium.org wrote: On Thursday, October 17, 2019 at 11:06:48 AM UTC-7, Mats Palmgren wrote: As far as I know, we never constrain new

Intent to unship: @media (-moz-touch-enabled)

2019-10-17 Thread Emilio Cobos Álvarez
Hi all, In bug 1588737 I plan to remove access to the -moz-touch-enabled media feature. This is a non-standard media-query feature that predates the standard hover and any-hover media features. It seems that Modernizr (a fairly popular library to do feature detection) bogusly uses it to

Re: Finding windows and docshells leaked until shutdown

2019-10-02 Thread Emilio Cobos Álvarez
Not an expert in leak-hunting, but generally this happens every time you leave something like an observer or such registered and you don't de-register it where the page goes away. It'd keep all the window alive. Probably can also happen with some native event listeners or what not... A recent

Re: Range-based for and STL-style iterators for nsClassHashtable, nsDataHashtable, nsInterfaceHashtable

2019-10-02 Thread Emilio Cobos Álvarez
for that? Cheers, -- Emilio [1]: https://searchfox.org/mozilla-central/rev/f372e8a46ef7659ef61be9938ec2a3ea34d343c6/layout/style/Loader.cpp#673 On 10/2/19 3:02 PM, Emilio Cobos Álvarez wrote: This is great, thanks for doing this!  -- Emilio On 10/2/19 12:15 PM, Simon Giesecke wrote: Hi, I

Re: Range-based for and STL-style iterators for nsClassHashtable, nsDataHashtable, nsInterfaceHashtable

2019-10-02 Thread Emilio Cobos Álvarez
This is great, thanks for doing this! -- Emilio On 10/2/19 12:15 PM, Simon Giesecke wrote: Hi, I recently [1] added STL-style iterators and begin/cbegin/end/cend member functions to nsBaseHashtable. This means that it is now possible to use range-based for and STL algorithms operating on

Intent to ship: Infer aspect-ratio from img width and height attributes.

2019-10-02 Thread Emilio Cobos Álvarez
Hi, As of today I intend to turn this feature on for release and beta channels (it was enabled only on Nightly until now). It's been developed behind the layout.css.width-and-height-map-to-aspect-ratio.enabled pref. Bug to turn on by default:

Intent to unship: Negative radii in radial gradients.

2019-10-01 Thread Emilio Cobos Álvarez
These were always invalid per spec, but every browser parsed them. Chromium was fixing a few of their bugs in the area (see https://github.com/w3c/csswg-drafts/issues/4042), and they made the change to reject negative lengths as well in: *

Re: [blink-dev] Re: What to do about scroll anchoring?

2019-09-29 Thread Emilio Cobos Álvarez
On 9/29/19 5:07 AM, Rick Byers wrote: On Fri, Sep 27, 2019 at 10:16 AM Emilio Cobos Álvarez mailto:emi...@mozilla.com>> wrote: Hi Steve, On 9/27/19 4:03 PM, Steve Kobes wrote: > Hi Emilio, > > My recollection is that scroll anchoring was, in fact, a

Re: What to do about scroll anchoring?

2019-09-27 Thread Emilio Cobos Álvarez
On 9/27/19 3:30 PM, twisniew...@mozilla.com wrote: I suspect that if we can give our compat addon an easy way to specify sites which need an opt-out, that might ease the pain. Likewise, as obnoxious as the thought is, perhaps giving sites a standard way to opt out of anchoring could be a

Re: [blink-dev] What to do about scroll anchoring?

2019-09-27 Thread Emilio Cobos Álvarez
ction. -- Emilio [1]: https://bugzilla.mozilla.org/attachment.cgi?id=9087497 On Fri, Sep 27, 2019, 21:23 Emilio Cobos Álvarez <mailto:emi...@mozilla.com>> wrote: Hi, (cc'ing webkit-dev@ and blink-dev@ in case they have feedback or opinions, as WebKit is the only engine

Re: What to do about scroll anchoring?

2019-09-27 Thread Emilio Cobos Álvarez
the user dispatches, the timing of these events relative to other events, etc... -- Emilio [1]: https://docs.google.com/document/d/1nQAO4MYCDMn0rTkn_-WI6gjumk3Qi2Bn-MGuB3NlVxE/edit On 9/27/19 2:23 PM, Emilio Cobos Álvarez wrote: Hi, (cc'ing webkit-dev@ and blink-dev@ in case they have feedback or

What to do about scroll anchoring?

2019-09-27 Thread Emilio Cobos Álvarez
Hi, (cc'ing webkit-dev@ and blink-dev@ in case they have feedback or opinions, as WebKit is the only engine which does not implement scroll anchoring, though I don't know if they plan to, and Blink is the only other engine that does implement it. Please reply to dev-platform@ though.) TLDR:

Intent to Ship: line-height returns normal as a resolved value.

2019-09-09 Thread Emilio Cobos Álvarez
Summary: Return "normal" for line-height's resolved value (the value returned from getComputedStyle()) rather than a concrete pixel value, if the computed value is "normal". This aligns us with Blink, and seems the best option according to various working group discussions, see below. In

Re: Coding style: Naming parameters in lambda expressions

2019-09-05 Thread Emilio Cobos Álvarez
Yeah, let's not add a new prefix please. I don't like aFoo either, though it's everywhere so consistency is better than nothing :/. That being said, it shouldn't be hard to write some clang plugin or such that automatically renames function arguments to stop using aFoo, should we want to do

Re: Intent to ship: multi-keyword values on the CSS 'display' property

2019-08-22 Thread Emilio Cobos Álvarez
On 8/22/19 11:28 AM, 一丝 wrote: Is there a plan to implement multi-valued table | flex | grid? E.g display: inline flex. That should work, afaict. ___ dev-platform mailing list dev-platform@lists.mozilla.org

Re: PSA: mozilla::Result is about to understand move semantics

2019-08-12 Thread Emilio Cobos Álvarez
On 8/12/19 10:38 PM, Bryce Seager van Dyk wrote: On Monday, August 12, 2019 at 8:41:26 AM UTC-7, Emilio Cobos Álvarez wrote: Neat! Thanks for doing this. It should allow for broader use of Result in media code. Are there any footguns to watch out for when moving into the Result? Looking

PSA: mozilla::Result is about to understand move semantics

2019-08-12 Thread Emilio Cobos Álvarez
If you don't use mozilla::Result, then you can stop reading now. Result always returned the ok / errors by value. That's fine when the ok or error values are cheap / small, like integers, but over time we've been using Result> / Result / Result, etc. Furthermore Result never worked with

PSA: Ensure your favorite components are up-to-date in codetribute

2019-08-10 Thread Emilio Cobos Álvarez
I was wondering why some of the bugs which I mark as good first bugs / mentored weren't appearing in codetribute[1]. Turns out that the recent (ish, :/) reorg of the Layout and DOM components made them just silently disappear from the tool, which is pretty unfortunate (as it both makes bugs

Re: Intent to ship: Make elements always unvisited.

2019-08-09 Thread Emilio Cobos Álvarez
On 8/9/19 1:29 PM, Anne van Kesteren wrote: On Thu, Aug 8, 2019 at 8:39 PM Emilio Cobos Álvarez wrote: Standard: https://drafts.csswg.org/selectors-4/#location (though note https://github.com/w3c/csswg-drafts/issues/3817). So the real standard for this is https://html.spec.whatwg.org/#pseudo

Intent to ship: Make elements always unvisited.

2019-08-08 Thread Emilio Cobos Álvarez
Summary: Make HTML elements not query the browser history. This is unnecessary work, and matches other browsers (kinda, see below in the "Other browsers" section). The TLDR is that even though this is technically required per spec as of today, it's a fairly obscure feature where there's no

Intent to ship: font-size: xxx-large

2019-08-08 Thread Emilio Cobos Álvarez
Summary: Expose the xxx-large value for the font-size property, as resolved in https://github.com/w3c/csswg-drafts/issues/3907. This value was previously accessible only via `` in HTML. Sending an intent on behalf of the patch author. Bug:

Re: Intent to Implement: CSS backdrop-filter

2019-07-11 Thread Emilio Cobos Álvarez
On 7/10/19 11:01 PM, Connor Brewster wrote: Hi David, It's not clear to me what this option means in terms of what you're proposing to implement and ship. @supports is a feature that web developers can use -- and it should clearly match whether the feature is supported. However, I think

Intent to experiment: infer aspect-ratio from width and height attributes in images

2019-06-27 Thread Emilio Cobos Álvarez
Hi, In bug 1547231 I've landed a change to how we determine the intrinsic aspect ratio of an image so that it's used from the width and height attributes, even if the width and height are overridden via CSS. This means that we can get a proper intrinsic size while the image is loading, for

Re: Intent to Ship: @supports selector()

2019-06-26 Thread Emilio Cobos Álvarez
Err, sorry, forgot to link to the bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1513643 -- Emilio On 6/27/19 12:31 AM, Emilio Cobos Álvarez wrote: I plan to turn on @supports selector() function for all release channels. See the following link for the intent to implement and relevant

Intent to Ship: @supports selector()

2019-06-26 Thread Emilio Cobos Álvarez
I plan to turn on @supports selector() function for all release channels. See the following link for the intent to implement and relevant discussion: https://groups.google.com/d/msg/mozilla.dev.platform/JNLPcIZRd2w/r6Boq0h2BQAJ There are various WPT tests for this in css/css-conditional and

Re: Intent to implement and ship: Unprefix -moz-user-select, unship mozilla-specific values.

2019-05-20 Thread Emilio Cobos Álvarez
that the soft-freeze is over. -- Emilio On 11/11/2018 18:57, Emilio Cobos Álvarez wrote: Summary: Unprefix the -moz-user-select property, so that it works without the -moz- prefix. We happen to be supporting the -webkit- prefixed version of the property, but other browsers support it also

Intent to Implement and Ship: CSSStyleSheet.rules, CSSStyleSheet.removeRule, CSSStyleSheet.addRule

2019-05-08 Thread Emilio Cobos Álvarez
Summary: Implement and spec some non-standard CSSOM APIs to converge with every other browser, since they're unlikely to ever remove their implementations and the lack of them causes compat issues for us, see the bug, the CSSWG issue [1] and everything cross-linked from there. Bug:

Intent to Implement and Ship: , reflected by HTMLLinkElement.disabled

2019-04-17 Thread Emilio Cobos Álvarez
Summary: Make the disabled attribute on link elements do something useful, and the disabled IDL attribute reflect this attribute instead of forwarding to the style sheet object (if present). This is mostly compat work, but should also do less work in pages that use it already. See below for the

Re: To what extent is sccache's distributed compilation usable?

2019-04-01 Thread Emilio Cobos Álvarez
pilation artifacts, or also compiling stuff in remote machines (like icecc does), or both, but afaik even in a local network it could still be a pretty nice build-time / productivity improvement. -- Emilio > On Mon, Apr 1, 2019 at 12:23 PM Emilio Cobos Álvarez > wrote: > >> Hi,

To what extent is sccache's distributed compilation usable?

2019-04-01 Thread Emilio Cobos Álvarez
Hi, Over in #layout people were ranting about how much of a pain it was to set up icecc on MacOS. I pointed out that sccache in theory does support distributed compilation[1] and in theory also supports MacOS clients. Does anybody know to what extent is it in a usable state? Can it replace

Intent to Unship: -moz-block-height value for line-height

2019-03-27 Thread Emilio Cobos Álvarez
Hi, In bug 1536871, where I'm sorting out various interop issues related to line-height (intents for those coming probably in a couple weeks when issues with the CSSWG and other implementors are sorted out) I plan to make the -moz-block-height value of the line-height property not available to

Re: Intent to implement and ship: built-in CSS counter 'list-item'

2019-03-26 Thread Emilio Cobos Álvarez
On 25/03/2019 06:21, Domenic Denicola wrote: > Some time ago we spent some effort documenting a cross-browser > mostly-interoperable behavior for list-item-like behaviors, in > https://github.com/whatwg/html/pull/2002 and linked threads. The result is > the spec at >

Intent to unship: Some Shadow DOM v0 APIs

2019-03-15 Thread Emilio Cobos Álvarez
Hi, In bug 1535438 I intend to remove three Shadow DOM v0 APIs that slipped through when we shipped Shadow DOM v1: * ShadowRoot.getElementsByTagName * ShadowRoot.getElementsByTagNameNS * ShadowRoot.getElementsByClassName These were implemented in bug 806506 as part of the initial Shadow DOM

Re: Intent to Ship: Ignore custom cursors over 32 pixels intersecting UI

2019-03-13 Thread Emilio Cobos Álvarez
On 13/03/2019 01:46, flor...@rivoal.net wrote: > On Wednesday, March 13, 2019 at 8:36:17 AM UTC+9, Emilio Cobos Álvarez wrote: >> On 13/03/2019 00:22, Florian Rivoal wrote: >>> Given that this is not merely setting a limit because you find that >>> implementation mo

Re: Intent to Ship: Ignore custom cursors over 32 pixels intersecting UI

2019-03-12 Thread Emilio Cobos Álvarez
Window.cpp#1465 > —Florian > > On Wednesday, March 13, 2019 at 4:50:01 AM UTC+9, Emilio Cobos Álvarez wrote: >> Hi, just some email I forgot to send a while ago. >> >> Summary: Block cursor images larger than 32 pixels wide that intersect >> the Browser UI, by falling back

Intent to Ship: Ignore custom cursors over 32 pixels intersecting UI

2019-03-12 Thread Emilio Cobos Álvarez
Hi, just some email I forgot to send a while ago. Summary: Block cursor images larger than 32 pixels wide that intersect the Browser UI, by falling back to the default cursor (as if no cursor image could be loaded). This prevents malware sites from hijacking the cursor and look as if the cursor

Intent to Implement and Ship: CSS revert keyword.

2019-03-03 Thread Emilio Cobos Álvarez
Summary: The CSS `revert` wide-keyword allows authors to ignore all CSS rules in a given cascade origin[1], while applying rules from other cascade origins. Trivial example would be: div { display: inline; } // somewhere further down... div { display: revert; /* Goes back to display: block

Re: PSA: Min clang / libclang requirement was updated not long ago...

2019-02-26 Thread Emilio Cobos Álvarez
gt; On Tue, Feb 26, 2019 at 12:23 PM Emilio Cobos Álvarez > wrote: >> >> ... so if you don't use the mozilla-provided libclang (or are using a >> very old one), and you see an error like: >> >>> error[E0277]: the trait bound >> `values::generics::rect::Rect

PSA: Min clang / libclang requirement was updated not long ago...

2019-02-26 Thread Emilio Cobos Álvarez
... so if you don't use the mozilla-provided libclang (or are using a very old one), and you see an error like: > error[E0277]: the trait bound `values::generics::rect::Rect>: std::convert::From, Please re-run mach bootstrap, or update your libclang. Thanks! -- Emilio

  1   2   3   >