Re: More ThinkStation P710 Nvidia tips (was Re: Faster gecko builds with IceCC on Mac and Linux)

2017-11-07 Thread Jeff Muizelaar
for sure in real world testing. :) > > > > On Tue, Nov 7, 2017 at 12:30 PM, Kris Maglione <kmagli...@mozilla.com> > wrote: >> >> On Tue, Nov 07, 2017 at 03:07:55PM -0500, Jeff Muizelaar wrote: >>> >>> On Mon, Nov 6, 2017 at 1:32 PM, Sophana "

Re: More ThinkStation P710 Nvidia tips (was Re: Faster gecko builds with IceCC on Mac and Linux)

2017-11-07 Thread Jeff Muizelaar
On Mon, Nov 6, 2017 at 1:32 PM, Sophana "Soap" Aik wrote: > Hi All, > > I'm in the middle of getting another evaluation machine with a 10-core > W-Series Xeon Processor (that is similar to the 7900X in terms of clock > speed and performance) but with ECC memory support. > > I'm

Re: Default Rust optimization level decreased from 2 to 1

2017-10-31 Thread Jeff Muizelaar
On Tue, Oct 31, 2017 at 3:21 PM, Gregory Szorc <g...@mozilla.com> wrote: > On Tue, Oct 31, 2017 at 12:02 PM, Jeff Muizelaar <jmuizel...@mozilla.com> > wrote: >> >> As another piece of evidence in support opt-level=1 being the wrong >> default, Glenn also got bit

Re: Default Rust optimization level decreased from 2 to 1

2017-10-31 Thread Jeff Muizelaar
As another piece of evidence in support opt-level=1 being the wrong default, Glenn also got bitten profiling with the wrong options. https://github.com/servo/webrender/issues/1817#issuecomment-340553613 -Jeff On Thu, Oct 26, 2017 at 2:51 PM, Jeff Muizelaar <jmuizel...@mozilla.com> wrote:

Re: More ThinkStation P710 Nvidia tips (was Re: Faster gecko builds with IceCC on Mac and Linux)

2017-10-26 Thread Jeff Muizelaar
On Thu, Oct 26, 2017 at 7:02 PM, Gregory Szorc wrote: > I also share your desire to not issue fancy video cards in these machines > by default. If there are suggestions for a default video card, now is the > time to make noise :) Intel GPUs are the best choice if you want to be

Re: More ThinkStation P710 Nvidia tips (was Re: Faster gecko builds with IceCC on Mac and Linux)

2017-10-26 Thread Jeff Muizelaar
On Thu, Oct 26, 2017 at 7:02 PM, Gregory Szorc wrote: > Unless you have requirements that prohibit using a > VM, I encourage using this setup. rr doesn't work in hyper-v. AFAIK the only Windows VM it works in is VMWare -Jeff ___

Re: Default Rust optimization level decreased from 2 to 1

2017-10-26 Thread Jeff Muizelaar
On Thu, Oct 26, 2017 at 3:08 PM, Gregory Szorc wrote: > Would it help if we had a separate --enable-optimize-rust (or similar) > option to control Rust optimizations so we have separate knobs? If we did > that, --disable-optimize-rust could be opt-level 0 or 1 and >

Re: Default Rust optimization level decreased from 2 to 1

2017-10-26 Thread Jeff Muizelaar
FWIW, WebRender becomes unusable opt-level=1. It also looks like style performance takes quite a hit as well which means that our default developer builds become unusable for performance work. I worry that people will forget this and end up rediscovering only when they look at profiles (as mstange

Re: More ThinkStation P710 Nvidia tips (was Re: Faster gecko builds with IceCC on Mac and Linux)

2017-10-26 Thread Jeff Muizelaar
Yeah. I'd suggest anyone who's running Linux on these machines just go out and buy a $100 AMD GPU to replace the Quadro. Even if you don't expense the new GPU and just throw the Quadro in the trash you'll probably be happier. -Jeff On Thu, Oct 26, 2017 at 9:34 AM, Henri Sivonen

Re: Threadsafe URLs - MozURL

2017-10-23 Thread Jeff Muizelaar
For the curious among us, what made nsIURI not thread safe in the first place? -Jeff On Mon, Oct 23, 2017 at 10:01 AM, Valentin Gosu wrote: > Hi everyone, > > Threadsafe URLs have been high on everybody's wishlist for a long while. > The fact that our nsIURI

Re: Canonical cinnabar repository

2017-09-20 Thread Jeff Muizelaar
I would recommend https://github.com/glandium/git-cinnabar/wiki/Mozilla:-A-git-workflow-for-Gecko-development. The other places should probably be updated to point at that. -Jeff On Wed, Sep 20, 2017 at 12:57 PM, Ethan Glasser-Camp wrote: > Sorry if this is a bit

Re: Canonical cinnabar repository

2017-09-19 Thread Jeff Muizelaar
On Mon, Sep 18, 2017 at 5:02 PM, Ehsan Akhgari wrote: > On 09/18/2017 03:30 PM, Bobby Holley wrote: >> >> CVS history feels like an odd bar for cinnabar. The goal of cinnabar is to >> enable seamless integration between git and mercurial with reproducible, 1:1 >> commit

Re: Canonical cinnabar repository

2017-09-18 Thread Jeff Muizelaar
FWIW, https://github.com/jrmuizel/gecko-cinnabar doesn't have the CVS history so is no better than https://github.com/mozilla/gecko. Having a canonical repo that includes the CVS history will make the SHA's incompatible with doing a direct conversion of hg which is a disadvantage. I'm not sure

Re: Canonical cinnabar repository

2017-09-18 Thread Jeff Muizelaar
I agree having a canonical version would be very valuable. In the mean time if you want to avoid having to do the entire conversion locally you can start by cloning the cinnabar branch of https://github.com/jrmuizel/gecko-cinnabar which is a local full conversion that I painfully uploaded to

Re: Linking with lld instead of ld/gold

2017-08-14 Thread Jeff Muizelaar
I believe all three linkers (bfd, gold and lld) can currently do LTO on LLVM bitcode. Naively I'd assume getting cross-compilation-unit optimization combining rust and clang compile units is more of a build system issue than a linker one. -Jeff On Mon, Aug 14, 2017 at 2:16 AM, Henri Sivonen

Re: Firefox and clang-cl

2017-08-12 Thread Jeff Muizelaar
On Sat, Aug 12, 2017 at 9:40 PM, Ehsan Akhgari wrote: > Last but not least, you may ask yourself why would we want to spend this > much effort to switch to clang-cl on Windows? I believe this is an > important long term shift that is beneficial for us. First and

Re: More Rust code

2017-08-08 Thread Jeff Muizelaar
On Mon, Aug 7, 2017 at 6:12 PM, Mike Hommey wrote: > Note that the tp5n main_startup_fileio reflects the resulting size of > xul.dll, which also impacts the installer size: > 32-bits 64-bits > MSVC (PGO): 37904383 40803170 > clang-cl: 39537860

Re: OS/2 still supported ?

2017-07-25 Thread Jeff Muizelaar
On Tue, Jul 25, 2017 at 11:25 PM, Steve Wendt <spam...@forgetit.org> wrote: > On 7/25/2017 7:28 AM, Jeff Muizelaar wrote: > >>>> The only remaining in-tree references to the XP_OS2 macros are in >>>> NSPR and NSS, which are technically separate projects, and h

Re: OS/2 still supported ?

2017-07-25 Thread Jeff Muizelaar
On Tue, Jul 25, 2017 at 4:04 AM, Enrico Weigelt, metux IT consult wrote: > On 25.07.2017 02:04, Kris Maglione wrote: > >> The only remaining in-tree references to the XP_OS2 macros are in NSPR >> and NSS, which are technically separate projects, and have their own >> sets

Re: Profiling nightlies on Mac - what tools are used?

2017-06-20 Thread Jeff Muizelaar
Very much so yes. Even if having unstripped builds were universally slower (they only seem to be only slower on the ci machines) any performance impact is likely to not impact the distribution of samples substantially. On Tue, Jun 20, 2017 at 2:09 PM, Chris Peterson wrote:

Re: Profiling nightlies on Mac - what tools are used?

2017-06-19 Thread Jeff Muizelaar
Yes. I use Instruments on Nightly builds extensively. It would really be a loss to lose this functionality. I think it's important to weigh the performance improvements that we get from easy profiling against any advantage we get from stripping the symbols. -Jeff On Mon, Jun 19, 2017 at 6:07 PM,

Re: Is it OK to make allocations that intentionally aren't freed? (was: Re: Is Big5 form submission fast enough?)

2017-05-19 Thread Jeff Muizelaar
We use functions like cairo_debug_reset_static_data() on shutdown to handle cases like this. -Jeff On Fri, May 19, 2017 at 1:44 AM, Henri Sivonen wrote: > On Tue, May 16, 2017 at 7:03 AM, Tim Guan-tin Chien > wrote: >> According to Alexa top 100

Re: new configure option: --enable-debug-rust

2017-05-11 Thread Jeff Muizelaar
On Fri, Apr 14, 2017 at 10:46 AM, Nathan Froyd wrote: > With these options, you get a browser that runs quickly (i.e. no DEBUG > assertions in C++ code), but still lets you debug the Rust code you > might be working on, ideally with faster compile times than you might > get

Re: Quantum Flow Engineering Newsletter #4

2017-04-07 Thread Jeff Muizelaar
We also got rid of some needless work that was happening every refresh driver tick. This should help cpu usage during the throbber spinning above and generally gives the main thread of the parent process more time to do useful things during animation.

Re: Tier 3 win64 ASan builds on try

2017-04-06 Thread Jeff Muizelaar
Glorious. Thanks to everyone who made this happen. -Jeff On Thu, Apr 6, 2017 at 10:11 PM, Ting-Yu Chou wrote: > Just a heads up that now we have win64 ASan builds on try. The try format: > > try: -b o -p win64-asan -u none -t none > > Bug 1347793 is tracking the failed

Re: Faster gecko builds with IceCC on Mac and Linux

2017-03-23 Thread Jeff Muizelaar
On Thu, Mar 23, 2017 at 11:42 PM, Robert O'Callahan wrote: > On Fri, Mar 24, 2017 at 1:12 PM, Ehsan Akhgari > wrote: >> On Thu, Mar 23, 2017 at 7:51 PM, Jeff Gilbert wrote: >> >>> I'm interested to find out how the new Ryzen

Re: Faster gecko builds with IceCC on Mac and Linux

2017-03-23 Thread Jeff Muizelaar
I have a Ryzen 7 1800 X and it does a Windows clobber builds in ~20min (3 min of that is configure which seems higher than what I've seen on other machines). This compares pretty favorably to the Lenovo p710 machines that people are getting which do 18min clobber builds and cost more than twice

Re: Future of out-of-tree spell checkers?

2017-03-22 Thread Jeff Muizelaar
On Wed, Mar 22, 2017 at 11:08 AM, Henri Sivonen wrote: > > dlopening libvoikko, if installed, and having thin C++ glue code > in-tree seems much simpler, except maybe for sandboxing. What are the > sandboxing implications of dlopening a shared library that will want > to

Re: Please write good commit messages before asking for code review

2017-03-09 Thread Jeff Muizelaar
On Thu, Mar 9, 2017 at 5:43 PM, Ben Kelly wrote: > Personally I prefer looking at the bug for the full context and single > point of truth. Also, security bugs typically can't have extensive commit > messages and moving a lot of context to commit messages might paint a >

Re: Is there a way to improve partial compilation times?

2017-03-07 Thread Jeff Muizelaar
On Tue, Mar 7, 2017 at 2:29 PM, wrote: > So, > > I'm on Dell XPS 13 (9350), and I don't think that toying with MOZ_MAKE_FLAGS > will help me here. "-j4" seems to be a bit high and a bit slowing down my > work while the compilation is going on, but bearable. > > I was

Re: Is there a way to improve partial compilation times?

2017-03-07 Thread Jeff Muizelaar
Perhaps you need a faster computer(s). Are you building on Windows? With icecream on Linux I can do a full clobber build in ~5 minutes. -Jeff On Tue, Mar 7, 2017 at 1:59 PM, wrote: > I'm on Linux (Arch), with ccache, and I work on mozilla-central, rebasing my >

Re: Intent to ship: CSS 'transform-box' property

2017-03-01 Thread Jeff Muizelaar
What is the status of this property in other browsers? -Jeff On Wed, Mar 1, 2017 at 4:25 PM, Jonathan Watt wrote: > In bug 1208550[1] we plan to allow the 'transform-box' property[2] to ride > the > trains to release. > > Summary: This property solves a common SVG authoring

Re: Intent to implement: Frames timing functions

2017-02-23 Thread Jeff Muizelaar
The linked bug suggests that Chrome implements this but this email suggests it doesn't. What's the truth? -Jeff On Thu, Feb 23, 2017 at 2:45 AM, Boris Chiou wrote: > *Summary*: > A frames timing function is a type of timing function that divides the > input time into a

Re: Changing the representation of rectangles in platform code

2017-02-09 Thread Jeff Muizelaar
It's not very easy to reason about overflow issues with our current representation. This means that we currently just pretend that they don't happen. The idea for changing the representation came up in response to a security bug where we didn't really have a better solution. Changing to x1, x2,

Re: Intent to Implement: adding vector effects non-scaling-size, non-rotation and fixed-position to SVG

2016-12-29 Thread Jeff Muizelaar
I'm concerned about the complexity this will add to the SVG implementation as we're looking to transition to WebRender. Can the desired effects be achieved by interleaving HTML and SVG content today? e.g. It seems like introductory notes example could just use a separate SVG element that had

Re: DXR problem?

2016-07-05 Thread Jeff Muizelaar
Is this what you're looking for? https://dxr.mozilla.org/mozilla-central/search?q=voice -Jeff On Sun, Jul 3, 2016 at 5:52 AM, Richard Z wrote: > Hi, > > tried dxr as replacement for lxr yesterday and today and it > does not seem to work for me. > Whatever I type into the

Re: Intent to ship: Canvas CSS/SVG filters

2016-06-01 Thread Jeff Muizelaar
gt; Firefox Developer Edition: Skia-GL: 10fps > Skia: 3fps > CG: 10fps > Cairo:8fps > > Chrome Canary 53: 3fps > > > On Tue, May

Re: Intent to ship: Canvas CSS/SVG filters

2016-05-31 Thread Jeff Muizelaar
How does performance compare to Chrome? -Jeff On Thu, May 26, 2016 at 12:40 PM, Tobias Schneider wrote: > I intend to turn Canvas CSS/SVG filters on by default on all platforms. It > has been developed behind the canvas.filters.enabled preference. Google's > Chrome is

Re: Reverting to VS2013 on central and aurora

2016-05-11 Thread Jeff Muizelaar
Or mozglue/build/SSE.cpp -Jeff On Wed, May 11, 2016 at 9:35 AM, Ehsan Akhgari wrote: > On 2016-05-10 10:01 PM, Robert Strong wrote: > > On Tue, May 10, 2016 at 6:55 PM, Lawrence Mandel > > wrote: > > > >> On Fri, May 6, 2016 at 12:39 PM, Benjamin

Re: ICU proposing to drop support for WinXP (and OS X 10.6)

2016-04-28 Thread Jeff Muizelaar
On Thu, Apr 28, 2016 at 1:39 PM, Jonathan Kew <jfkth...@gmail.com> wrote: > On 28/4/16 18:11, Jeff Muizelaar wrote: > >> Do we use any of the OS specific parts of ICU? >> > > I don't know. > > But even if we don't, I suspect that once they drop support for

Re: ICU proposing to drop support for WinXP (and OS X 10.6)

2016-04-28 Thread Jeff Muizelaar
Do we use any of the OS specific parts of ICU? -Jeff On Thu, Apr 28, 2016 at 1:00 PM, Jonathan Kew wrote: > We make considerable (and growing) use of ICU for various aspects of i18n > support in Gecko.† > > The ICU project is proposing to drop support for Windows XP and OS

Re: Dump frame tree in real time

2016-04-08 Thread Jeff Muizelaar
Check out https://developer.mozilla.org/en-US/docs/Mozilla/Debugging/Layout_Debugger. I expect it gets the information that you're looking for. -Jeff On Fri, Apr 8, 2016 at 1:38 PM, Jip de Beer wrote: > Hi all, > > I would like to inspect the Frame Tree (or Render Tree:

Re: Intent to enable e10s by default when running tests locally

2016-03-24 Thread Jeff Muizelaar
We fork a process to test gfx early on so 'set follow-for-mode child' might end up following that. 'set detach-on-fork off' will keep you attached to everything though. -Jeff On Thu, Mar 24, 2016 at 1:21 PM, Paul Adenot wrote: > Do we know whether `set follow-fork-mode child` in

Re: C++ Core Guidelines

2016-03-24 Thread Jeff Muizelaar
On Wed, Jan 6, 2016 at 7:15 AM, Henri Sivonen wrote: > On Thu, Oct 1, 2015 at 9:58 PM, Jonathan Watt wrote: >> For those who are interested in this, there's a bug to consider integrating >> the Guidelines Support Library (GSL) into the tree: >> >>

Re: APNG and Accept-Encoding

2016-02-18 Thread Jeff Muizelaar
Is there a response to the criticism of Accept outlined here: https://wiki.whatwg.org/wiki/Why_not_conneg#Negotiating_by_format -Jeff On Wed, Feb 17, 2016 at 6:08 PM, Mike Lawther wrote: > Hi Mozilla developers! > > tl,dr; can Firefox send an Accept-Encoding heading

Re: Does SSE2 usage still need to be conditional?

2016-02-01 Thread Jeff Muizelaar
I don't think there are any compilers that support x64 without SSE2. SSE2 registers are required for passing float parameters in both MS and System V ABIs. -Jeff On Mon, Feb 1, 2016 at 6:00 PM, Xidorn Quan wrote: > On Tue, Feb 2, 2016 at 7:04 AM, Benjamin Smedberg

Re: Use of C++11 std::unique_ptr for the WOFF2 module

2016-02-01 Thread Jeff Muizelaar
Lee Salzman came up with a hacky solution to this problem for the Skia update that he's working on. I haven't seen it yet, but apparently it builds. -Jeff On Mon, Feb 1, 2016 at 4:29 AM, Frédéric Wang wrote: > Dear all, > > I'm trying to upgrade our local copy of OTS to

Re: Turning on WebGL2 on Nightly

2015-12-21 Thread Jeff Muizelaar
Bug 1232864 -Jeff On Mon, Dec 21, 2015 at 7:59 AM, Sylvestre Ledru <sle...@mozilla.com> wrote: > Le 16/12/2015 23:44, Jeff Muizelaar a écrit : >> Jeff Gilbert is planing on landing patches very soon that will flip >> the webgl.enable-prototype-webgl2 pref to true on

Turning on WebGL2 on Nightly

2015-12-16 Thread Jeff Muizelaar
Jeff Gilbert is planing on landing patches very soon that will flip the webgl.enable-prototype-webgl2 pref to true on Nightly. This change will stay on Nightly for now. There are lots of tests from the conformance suite that we don't pass but we're looking to get more web developers to try out

Re: Firefox Nightly keeps crashing on Windows 10

2015-09-21 Thread Jeff Muizelaar
Can you post some links from your about:crashes? -Jeff On Mon, Sep 21, 2015 at 7:31 PM, Dhon Buenaventura wrote: > Why does Firefox Nightly keep crashing randomly? I am currently using the > latest build but I still experience random crashes. >

Re: Alternative to Bonsai?

2015-09-16 Thread Jeff Muizelaar
Blame does work on those files locally. FWIW, fugitive vim's Gblame command has the ability to jump back to the blame of parent revision of the current line which makes it much easier to navigate history than any web based blame tool that I've seen. Even if you only use vim for GBlame I'd say it's

Re: Firefox graphics issues on Windows 10 + Firefox 40

2015-08-13 Thread Jeff Muizelaar
AMD bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1189266 Nvidia bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1189940 -Jeff On Thu, Aug 13, 2015 at 5:22 AM, Tom Schuster t...@schuster.me wrote: Hey, people on reddit.com/r/firefox are reporting a fair amount of graphics related

Re: Allowing web apps to delay layout/rendering on startup

2015-07-30 Thread Jeff Muizelaar
Can't you just make everything display:none until you're ready to show it? -Jeff On Thu, Jul 30, 2015 at 4:20 PM, James Burke jbu...@mozilla.com wrote: There are some forces at play in a web app that point to wanting to delay layout and rendering until a web app gives a signal that it should

Re: GTK3 linux builds

2015-07-20 Thread Jeff Muizelaar
Benjamin, Do you still have any opposition to the plan suggested by Roc? -Jeff On Mon, Jul 20, 2015 at 9:30 AM, Robert O'Callahan rob...@ocallahan.org wrote: On Tue, Jul 21, 2015 at 1:04 AM, Jeff Muizelaar jmuizel...@mozilla.com wrote: I believe Flash does. OK, I can't get it to work

Re: Hash table iterators, and a call for help

2015-07-13 Thread Jeff Muizelaar
I did not see nsTHashtable and nsBasHashtable define stl style iterators for use in range-based for loops. Is this intentional? -Jeff On Mon, Jul 13, 2015 at 1:36 AM, Nicholas Nethercote n.netherc...@gmail.com wrote: Hi, Last week I landed patches that remove PL_DHashTableEnumerate() from

Re: Proposal to remove `aFoo` prescription from the Mozilla style guide for C and C++

2015-07-07 Thread Jeff Muizelaar
FWIW, I did a quick poll of the people in our Gfx daily. Here are the results: For aArguments: Bas Milan Matt Kats Against aArguments: Me No strong opinion: Sotoro Lee Benoit Nical Mason -Jeff On Tue, Jul 7, 2015 at 11:12 AM, Nick Fitzgerald nfitzger...@mozilla.com wrote: (Posted

Re: GTK3 linux builds

2015-06-17 Thread Jeff Muizelaar
On Wed, Jun 17, 2015 at 11:22 AM, Benjamin Smedberg benja...@smedbergs.us wrote: On 6/16/15 4:16 PM, Jeff Muizelaar wrote: We're working on making all of the tests green for GTK3. This means that we could be changing the default linux configuration to GTK3 as early as FF42. What

Re: Intent to implement and ship: Unprivilaged WEBGL_debug_renderer_info

2015-06-16 Thread Jeff Muizelaar
low success and it seems like we could do something to make it better. -Jeff On Mon, Jun 15, 2015 at 9:18 PM, Jeff Muizelaar jmuizel...@mozilla.com wrote: I'm concerned this will discourage websites from reporting WebGL issues because it will be easier just to block whatever device has

Re: GTK3 linux builds

2015-06-16 Thread Jeff Muizelaar
Is there any reason not to support all the way back to the version of GTK (3.4) on the test machines? -Jeff On Tue, Jun 16, 2015 at 5:11 PM, Mike Hommey m...@glandium.org wrote: On Tue, Jun 16, 2015 at 04:16:13PM -0400, Jeff Muizelaar wrote: We're working on making all of the tests green

GTK3 linux builds

2015-06-16 Thread Jeff Muizelaar
We're working on making all of the tests green for GTK3. This means that we could be changing the default linux configuration to GTK3 as early as FF42. If anyone has any reasons for us not to make this change it would be good to know now. FWIW, I believe Fedora is already shipping GTK3 builds of

Re: Intent to implement and ship: Unprivilaged WEBGL_debug_renderer_info

2015-06-15 Thread Jeff Muizelaar
I'm concerned this will discourage websites from reporting WebGL issues because it will be easier just to block whatever device has the problem they're running in to. This creates an additional burden on the web developer and essentially creates the user agent problem all over again, but at much

Re: DXR 2.0 staged. Feedback please!

2015-06-04 Thread Jeff Muizelaar
It looks like finding of overrides of virtual methods is missing from DXR 2.0. Is this intentional? -Jeff On Wed, Jun 3, 2015 at 3:10 PM, Erik Rose e...@mozilla.com wrote: DXR 2.0 is about to land! This is a major revision touching every part of the system, swapping out SQLite for

Re: fx-team repository stripped

2015-04-22 Thread Jeff Muizelaar
Should we have a hook to catch this kind of thing? -Jeff On Wed, Apr 22, 2015 at 1:44 PM, Gregory Szorc g...@mozilla.com wrote: 2 files summing to 90 MB of binary data (a Firefox installer) were checked into fx-team a few hours ago. While Mercurial (and Git) can handle binary files of this

Re: Is MOZ_SHARK still used?

2015-04-02 Thread Jeff Muizelaar
I don't think Shark runs on any modern macs. -Jeff On Thu, Apr 2, 2015 at 4:22 PM, Robert Strong rstr...@mozilla.com wrote: I filed Bug 1150312 to remove it if it is no longer used so please speak up if it is. https://bugzilla.mozilla.org/show_bug.cgi?id=1150312 Thanks, Robert

Re: Propose to remove nsAString::AssignLiteral(const char (aStr)[N])

2015-03-02 Thread Jeff Muizelaar
It looks like the current one should already be as the the AssignASCII will be inlined into the caller and then the strlen can be inlined as well. -Jeff On Sun, Mar 1, 2015 at 7:04 PM, smaug sm...@welho.com wrote: On 03/02/2015 01:11 AM, Xidorn Quan wrote: On Mon, Mar 2, 2015 at 9:50 AM,

Re: Intent to ship: MouseEvent.offsetX/Y

2015-02-27 Thread Jeff Muizelaar
On Fri, Feb 27, 2015 at 2:21 PM, Robert O'Callahan rob...@ocallahan.org wrote: Oh, another issue is that I've followed the spec and made offsetX/Y doubles, whereas Blink is integers, which introduces a small amount compat risk. IE also uses integers. Wouldn't it be better to change the spec

Re: Enhancing Gecko as a WebGL game platform

2015-01-14 Thread Jeff Muizelaar
On Wed, Jan 14, 2015 at 4:29 AM, Mike de Boer mdeb...@mozilla.com wrote: On 13 Jan 2015, at 21:52, Jeff Muizelaar jmuizel...@mozilla.com wrote: On Tue, Jan 13, 2015 at 10:56 AM, Mike de Boer mdeb...@mozilla.com wrote: 2. Optionally bypass the browser compositor when a WebGL context

Re: Enhancing Gecko as a WebGL game platform

2015-01-13 Thread Jeff Muizelaar
On Tue, Jan 13, 2015 at 10:56 AM, Mike de Boer mdeb...@mozilla.com wrote: 2. Optionally bypass the browser compositor when a WebGL context is in fullscreen mode. In this mode, WebGL draw calls would write to the OS back buffer directly, increasing performance. Of course, this would never be

Re: Getting rid of already_AddRefed?

2014-12-22 Thread Jeff Muizelaar
We were talking about this problem and it was a bunch of work to figure out the conclusion so I decided to write a summary: Replacing already_AddRefed with nsRefPtr causes allows two new things: nsRefPtrT getT(); 1. T* p = getT(); // this is unsafe because the destructor runs immediately and

Re: Serious performance regression when setting the background of window to be transparent under win32.

2014-12-17 Thread Jeff Muizelaar
X64, when the background of the window is transparent. CanvasMark Score: 4538 (Mozilla 31 on Windows) Without transparent background: CanvasMark Score: 5366 (Mozilla 31 on Windows) Tweet this result. 2014-12-16 23:30 GMT+08:00 Jeff Muizelaar jmuizel...@mozilla.com: Or rather than what

Compiler version expectations

2014-10-16 Thread Jeff Muizelaar
After some discussion some IRC it was clear that our compiler deprecation schedule is not very clear. Now that we’re using VS2013 on trunk and will soon not being using GCC 4.4 for B2G, I expect we’ll be dropping support for building with VS2010 and GCC 4.4 in the near term. This is

Re: Compiler version expectations

2014-10-16 Thread Jeff Muizelaar
On Oct 16, 2014, at 3:57 PM, Ehsan Akhgari ehsan.akhg...@gmail.com wrote: On 2014-10-16, 3:49 PM, Jeff Muizelaar wrote: After some discussion some IRC it was clear that our compiler deprecation schedule is not very clear. Now that we’re using VS2013 on trunk and will soon not being using

Re: Compiler version expectations

2014-10-16 Thread Jeff Muizelaar
require? There's a number of people building with VS2012, would that still be supported? David - Original Message - From: Jeff Muizelaar jmuizel...@mozilla.com To: Ehsan Akhgari ehsan.akhg...@gmail.com Cc: dev-platform@lists.mozilla.org list dev-platform@lists.mozilla.org Sent

Re: Using protobuf in m-c

2014-09-29 Thread Jeff Muizelaar
On Sep 24, 2014, at 1:38 PM, Fitzgerald, Nick nfitzger...@mozilla.com wrote: Hey folks, We already have the protobuf library in the tree, and it seems to be used for layer scope and webrtc. I'd like to use it for serializing heap snapshots in devtools code, but I have a couple

Re: Studying Lossy Image Compression Efficiency

2014-03-07 Thread Jeff Muizelaar
On Feb 23, 2014, at 5:17 PM, evacc...@gmail.com wrote: On Monday, October 21, 2013 8:54:24 AM UTC-6, tric...@accusoft.com wrote: - I suppose that the final lossless step used for JPEGs was the usual Huffman encoding and not arithmetic coding, have you considered testing the later one

Re: How to efficiently walk the DOM tree and its strings

2014-03-03 Thread Jeff Muizelaar
On Mar 3, 2014, at 2:28 PM, Felipe G fel...@gmail.com wrote: Hi everyone, I'm working on a feature to offer webpage translation in Firefox. Translation involves, quite unsurprisingly, a lot of DOM and strings manipulation. Since DOM access only happens in the main thread, it brings the

Re: Tagging legitimate main thread I/O

2014-02-07 Thread Jeff Muizelaar
On Feb 7, 2014, at 10:31 AM, David Rajchenbach-Teller dtel...@mozilla.com wrote: When we encounter main thread I/O, most of the time, it is something that should be rooted out. However, in a few cases (e.g. early during startup, late during shutdown), these pieces of I/O should actually be

Re: Subpixel AA text rendering on OSX

2014-01-21 Thread Jeff Muizelaar
On Jan 20, 2014, at 5:48 PM, Matt Woodrow m...@mozilla.com wrote: Hi, Currently in gecko we have code to determine if text being drawn into a transparent surface has opaque content underneath it. In the case where it doesn't we ask moz2d/cairo [1] to disable subpixel AA text rendering

Re: Studying Lossy Image Compression Efficiency

2013-10-19 Thread Jeff Muizelaar
- Original Message - On Saturday, October 19, 2013 12:12:14 AM UTC+1, Ralph Giles wrote: On 2013-10-18 1:57 AM, Yoav Weiss wrote: Do you have such a sample? For what it's worth here's an image I made quite awhile ago showing the results of my own blind subjective comparison

Re: Introducing Brotli - an alternative to LZMA

2013-09-11 Thread Jeff Muizelaar
On 2013-09-11, at 5:55 AM, Mike Hommey wrote: On Wed, Sep 11, 2013 at 06:49:58AM +0100, Jonathan Kew wrote: However, several concerns regarding LZMA (lack of formal specification combined with complexity of the code, making careful security review and maintenance difficult; relatively slow

Re: Introducing Brotli - an alternative to LZMA

2013-09-11 Thread Jeff Muizelaar
On 2013-09-11, at 9:43 AM, Jonathan Kew wrote: On 11/9/13 14:12, Jeff Muizelaar wrote: Brotli increases the window size and thus memory requirement to 4MB which is quite a bit. It's also larger than the cache size on mobile devices which is currently around 1MB so it would be interesting

Re: Should we build a new in-process unwind library?

2013-08-30 Thread Jeff Muizelaar
On 2013-08-30, at 4:58 AM, Julian Seward wrote: I am very tempted to create a new custom unwind library designed specifically to support SPS. It needs to be fast, lower-footprint, and multithreaded. Unlike Breakpad, it will -- at least initially -- avoid supporting all Tier 1 targets, and

Re: vsync proposal

2013-08-13 Thread Jeff Muizelaar
On 2013-08-12, at 11:05 PM, Robert O'Callahan wrote: Tell me what you think. https://wiki.mozilla.org/User:Roc/VsyncProposal A couple things that are not clear to me from this proposal: - when the vsync event is sent? - how does it deal with a blocking swapbuffers()? - what happens in the

Re: Removing support for OS/2

2013-08-01 Thread Jeff Muizelaar
On 2013-08-01, at 7:38 PM, Mike Hommey wrote: On Thu, Aug 01, 2013 at 04:13:23PM -0700, Gregory Szorc wrote: We have a number of references to OS/2 throughout the build system and source tree. According to Kyle Huey OS/2 has likely broken since we removed --disable-ipc (bug 638755) in March

Re: Rethinking the amount of system JS we use in Gecko on B2G

2013-04-22 Thread Jeff Muizelaar
On 2013-04-22, at 2:15 PM, Bill McCloskey wrote: I can't agree with you more, Justin. I think Boris is right that we should make these decisions on a case-by-case basis. But in the case of these workers, it seems clear that converting them to C++ is the way to go, assuming we have the

Re: Rethinking the amount of system JS we use in Gecko on B2G

2013-04-22 Thread Jeff Muizelaar
On 2013-04-22, at 3:44 PM, Terrence Cole wrote: On 04/22/2013 12:12 PM, Jeff Muizelaar wrote: On 2013-04-22, at 2:15 PM, Bill McCloskey wrote: I can't agree with you more, Justin. I think Boris is right that we should make these decisions on a case-by-case basis. But in the case

Re: Virtual Memory fragmentation issues

2013-04-09 Thread Jeff Muizelaar
On 2013-04-08, at 7:46 PM, Benjamin Smedberg wrote: In stability-land we're starting to see some interesting problems relating to virtual memory usage in Firefox on Windows. Either our code or the ATI driver is leaking mapped memory references in a way that chews up VM space without

Re: WebP support

2013-04-08 Thread Jeff Muizelaar
No decision has been made yet. We are still evaluating the format. -Jeff On 2013-04-08, at 5:09 AM, David Bruant wrote: Hi, (I'm not 100% sure this is the proper mailing list to ask this question, but I can't think of a more relevant mailing-list at this time. Please forward if

Re: WebP support

2013-04-08 Thread Jeff Muizelaar
:06 AM, Jeff Muizelaar wrote: No decision has been made yet. We are still evaluating the format. I think the concern is that none of that re-evaluation has been on a public list or bug I've seen. Can you clarify what Andreas meant by, new data that shows that WebP has valid use cases

Re: improving access to telemetry data

2013-02-28 Thread Jeff Muizelaar
On 2013-02-28, at 10:44 AM, Benjamin Smedberg wrote: On 2/28/2013 10:33 AM, Benoit Jacob wrote: Please, please make your plans include the ability to get raw text files (CSV or JSON or something else, I don't care as long as I can easily parse it). Could you be more specific? Note that