Re: new code to help with cross-process windows/workers (and Clients API)

2017-12-08 Thread Mike Conley
This all sounds great! >> I personally think this would be useful, and will (probably) only happen if >> you do it now, before you move on to the next thing. +1 for documentation! I concur. ___ dev-platform mailing list dev-platform@lists.mozilla.org

Re: --verify option added to mochitest, reftest, xpcshell test harnesses

2017-10-03 Thread Mike Conley
This is super cool! Thanks Geoffrey! On 2017-10-02 1:08 PM, Geoffrey Brown wrote: > The mochitest, reftest, and xpcshell test harnesses now support a > --verify option. For example: > > mach mochitest > docshell/test/test_anchor_scroll_after_document_open.html --verify > > In verify mode, the

Re: Quantum Flow Engineering Newsletter #25

2017-09-21 Thread Mike Conley
t;> Another super important goal of mine was to give credit where it's due. >> What we have accomplished for Quantum Flow (and Firefox 57) so far >> couldn't >> have been accomplished without the help of many wonderful people in the >> community.  I often think that we need to ta

TabChild visibility

2017-09-20 Thread Mike Conley
Hello dev-platform, TL;DR: TabChild's don't seem to care about the nsIBaseWindow visibility attribute that they implement. In fact, they often lie about it. What should we do about that? What's the best way to detect and tell the TabChild that it's visible or invisible? Also, what's the

Re: Proposal: Unified Bootstrap Stages for Gecko

2017-09-05 Thread Mike Conley
Hey gandalf, Using WICG for browser start-up makes sense to me. We should also consider adding a milestone for the "hero element" for the browser. There's some discussion fragments in bug 1369417 about this (which I see you're already involved in! Great!), captured from a very caffeinated

Photon Engineering Newsletter #14

2017-08-24 Thread Mike Conley
(via https://mikeconley.ca/blog/2017/08/24/photon-engineering-newsletter-14/ - I suggest visiting that post directly if you want to see the animated GIFs inline) Just like jaws did last week , I'm taking over for dolske

Re: Quantum Flow Engineering Newsletter #18

2017-08-08 Thread Mike Conley
> > Mike Conley ported scrollbox to use smooth scrolling instead of JS driven > scrolling <https://bugzilla.mozilla.org/show_bug.cgi?id=1356705>. This > affects most importantly scrolling the tab bar, and should make it more > smooth by removing a lot of slow code that used t

Re: Firefox startup code coverage (ts_paint talos test)

2017-08-02 Thread Mike Conley
This is great, thanks so much Marco! This will likely be a useful way for us to find more opportunities to make start-up faster. Thanks for your work! On 2017-08-02 10:28 AM, Marco Castelluccio wrote: > Hello all, > at https://marco-c.github.io/ts_paint_startup_coverage_report/ you can > find a

The Joy of Profiling

2017-06-16 Thread Mike Conley
(cross-posted between dev-platform and firefox-dev - please send responses to the dev-platform list). TL;DR: New show on AirMo - Joy of Profiling, examining Profiles: https://air.mozilla.org/search/?q=the+joy+of+profiling . Want your profile up on the show? Submit it via

Re: Gecko Profiler Win64 stability

2017-05-18 Thread Mike Conley
Tremendous work here. Thank you so much, dmajor! On 2017-05-18 3:04 PM, David Major wrote: > Hi, > > The Gecko Profiler used to be notoriously unstable on 64-bit Windows. > (If you're curious: it's mostly because the unwinding rules for Win64 > require the system libraries to do a lot of

window.find dialog feature broken in Firefox 53 (a.k.a., Late Intent to Unship: window.find's dialog support)

2017-04-18 Thread Mike Conley
Hello release-drivers (with dev-platform cc'd), TL;DR: The non-standard window.find feature[1] has, historically, been able to open up a dialog for the user to enter more strings to find on the page[2]. It turns out that the dialog portion of that API has been broken for all users with e10s

Re: Please write good commit messages before asking for code review

2017-03-09 Thread Mike Conley
Incidentally, MozReview now allows you to provide feedback on the commit message in the diffviewer. On Mar 9, 2017 2:47 PM, "Ehsan Akhgari" wrote: > I review a large number of patches on a typical day, and usually I have to > spend a fair amount of time to just

Re: Project Stockwell - February 2017 update

2017-02-10 Thread Mike Conley
There's good feedback in here. Are some of these known, jmaher? Are any intentional choices, or should we just start turning these into bugs to get fixed? On 08/02/2017 12:33 AM, Bill McCloskey wrote: > Hi Joel, > I spent about an hour tonight trying to debug a test failure, and I'm > writing

Re: Content process launch time distribution

2017-02-07 Thread Mike Conley
> Also, is there a way to get numbers for the >> time from process launch to the point when we start loading the first URL I think there is. There's this "startup timeline" stuff that we record timestamps for:

Re: Intent to disable service workers and push in 52 ESR

2017-01-18 Thread Mike Conley
> I would expect not, though, since we are >> still rolling it out to the full population. I do believe the plan is to enable e10s on 52 ESR, but with the Firefox 50 restrictions (e10s enabled by default, disabled if a11y APIs used, disabled if non-WebExtension, non-mpc=true add-ons enabled).

Re: PSA: The return type of IPDL Recv* methods changed from bool to mozilla::ipc::IPCResult

2016-11-16 Thread Mike Conley
This is _fantastic_. Thank you Kanru! On 16/11/2016 9:57 AM, Kan-Ru Chen wrote: > Hello, > > In bug 1314254 the return type of IPDL Recv* methods was changed from > bool to mozilla::ipc::IPCResult in order to make crash reports to have > better stack information. There are now three choices to

Re: Intent to make Form Autocomplete popups use richlistbox's instead of trees

2016-10-17 Thread Mike Conley
<gijskruitbo...@gmail.com> wrote: > On 19/08/2016 16:25, Mike Conley wrote: > >> Summary says it all. See >> https://bugzilla.mozilla.org/show_bug.cgi?id=1296638 for details and >> rationale. >> >> I have a working version of this on my local machine, and

Re: Requesting Help

2016-09-19 Thread Mike Conley
Hi Amila! Welcome! We can absolutely help you out. There are a _lot_ of things going on that you can contribute to, depending on your current skillset, and also depending on what skills you'd like to grow. jdm wrote a tool to let you know about some of the things you might want to contribute

Re: PSA: mozilla/unused.h renamed to mozilla/Unused.h

2016-08-27 Thread Mike Conley
Yes, thank you Kan-Ru! On Aug 27, 2016 2:10 PM, "Nick Fitzgerald" wrote: > Thanks Kan-Ru! I've personally tried to include the header with the wrong > case multiple times, so I appreciate this change a lot. > > On Fri, Aug 26, 2016 at 7:54 PM, Kan-Ru Chen

Re: Intent to make Form Autocomplete popups use richlistbox's instead of trees

2016-08-19 Thread Mike Conley
ike, > > I'm not much into that topic, though I'm wondering why you don't try to > switch to HTML already as the DevTools team started to do[1] recently. > > Sebastian > > [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1263750 > > On 19 August 2016 at 17:25, Mi

Intent to make Form Autocomplete popups use richlistbox's instead of trees

2016-08-19 Thread Mike Conley
(Cross-posted to dev-platform and firefox-dev) Hey folks, If you don't work on front-endy things, you can safely ignore this. Summary says it all. See https://bugzilla.mozilla.org/show_bug.cgi?id=1296638 for details and rationale. I have a working version of this on my local machine, and will

Re: Increased number of e10s related crashes for firefox-ui-tests on mozilla-central and integration branches

2016-08-02 Thread Mike Conley
Might be unexpected fallout from bug 1261842 which landed on central on Monday (July 25th). Does that correspond to your timeline of when this started showing up? I'm seeing this in the log for at least one of these: "JavaScript error: chrome://marionette/content/listener.js, line 1017:

Re: How to measure performance impact of l10n on UI

2016-07-25 Thread Mike Conley
me to the test you've written so far? That might help me to better understand what you're attempting to measure and how you're going about it. -Mike On 22/07/2016 8:47 PM, zbranie...@mozilla.com wrote: > On Friday, July 22, 2016 at 6:53:45 AM UTC-7, Mike Conley wrote: >> Is the fi

Re: PSA - With e10s enabled, initial browser in new windows will soon be remote by default

2016-07-25 Thread Mike Conley
p. > > Thanks. > > Ben > > On Mon, Jul 25, 2016 at 10:29 AM, Mike Conley <mcon...@mozilla.com> wrote: > >> After much toil, this has finally landed on central. Hopefully it sticks. >> >> Big thanks to all of my reviewers - especially smaug, who reviewed

Re: PSA - With e10s enabled, initial browser in new windows will soon be remote by default

2016-07-25 Thread Mike Conley
After much toil, this has finally landed on central. Hopefully it sticks. Big thanks to all of my reviewers - especially smaug, who reviewed the bulk of the weirder stuff. -Mike On 9 June 2016 at 14:21, Mike Conley <mcon...@mozilla.com> wrote: > If you don’t write tests that ope

Re: How to measure performance impact of l10n on UI

2016-07-22 Thread Mike Conley
Is the firstPaint timestamp in nsIAppStartup's getStartupInfo[1] not sufficient? It's apparently recording the time that firstPaint occurred. I think you're already aware of this, but I'm in the process of modifying ts_paint to record the delta between the firstPaint timestamp and the process

PSA - With e10s enabled, initial browser in new windows will soon be remote by default

2016-06-09 Thread Mike Conley
If you don’t write tests that open browser windows or work on the front-end of Firefox, you can probably ignore this. The initial browser in browser.xul is non-remote by default. This means that as soon as it browses to some URL that can be loaded in the content process (about:home, for

Re: Top crash list is odd right now

2016-06-03 Thread Mike Conley
I reviewed the patch. Currently, the feature is only enabled on Nightly, Aurora and Beta. We originally wanted the beta unsubmitted crashes due to the content process crashes we were getting there with e10s that we didn't understand. Now that we have a better handle on those content process

Re: pushPrefEnv/popPrefEnv/flushPrefEnv now return Promises

2016-05-20 Thread Mike Conley
This is great, thank you! On 19/05/2016 7:09 PM, Matthew N. wrote: > Hello, > > One of the reasons developers have been avoiding pushPrefEnv compared to > the synchronous set*Pref (with a registerCleanupFunction) is because > pushPrefEnv required using a callback function to wait for the >

Re: Moving XP to ESR?

2016-04-20 Thread Mike Conley
The people on this thread might find chutten's recent blog post interesting: https://chuttenblog.wordpress.com/2016/04/19/firefoxs-windows-xp-users-upgrade-path/ Juicy chunk: "Between 40% and 53% of Firefox users running Windows XP are Stuck" -Mike On 18/04/2016 9:04 AM, Henri Sivonen wrote: >

Re: PSA: Cancel your old Try pushes

2016-04-17 Thread Mike Conley
> Generally speaking, Firefox's stability has not been good for me for 2-3 months. I'd like to file a bug, > but I've already used up my quota of unactionable bugs, and if I dug into all of my idiosyncratic > issues I'd never get any work done. I seem to do things differently, in some problematic

Re: PSA: Cancel your old Try pushes

2016-04-17 Thread Mike Conley
If I had to guess, I'd say that it's just consuming more and more memory as more and more nodes are getting added to the DOM, and more AngularJS stuff gets instantiated. I would put good money on those multi-second pauses being attempts to GC / CC On 16 April 2016 at 05:50, Gijs Kruitbosch

On using MozAfterPaint properly

2016-04-15 Thread Mike Conley
Hello dev-platform, TL;DR: MozAfterPaint and nsIDOMWindowUtils has been given some extra stuff to make it easier to be sure that something you care about has been painted. This is good, at the very least, for Talos tests. Full-details: I've recently made a change to MozAfterPaint that some of

Re: Just Autoland It

2016-01-29 Thread Mike Conley
I respect everybody talking in this thread a great deal, but I thought I might gently suggest that folks exercise a bit of empathy for what the MozReview team[1] are trying to accomplish, and how difficult that work actually is. Trying to build a tool that satisfies such a wide spectrum of

Re: Just Autoland It

2016-01-29 Thread Mike Conley
erdiffs are sometimes wrong", which is clearly something to fix ASAP On 29/01/2016 11:18 AM, Boris Zbarsky wrote: > On 1/29/16 10:42 AM, Mike Conley wrote: >> most of the feedback is via negativa[2] > > That's definitely no good, I agree. > > Attacking the MozReview team is a

Re: Unsafe CPOWs are about to be outlawed in browser code

2016-01-28 Thread Mike Conley
de? (I presume and also support that > add-ons > > should be fixed here.) > > > > Thanks. > > > > -hb- > > > > > > On 1/27/2016 17:42, Mike Conley wrote: > >> > >> The spaghetti was put in the machine last night - this work has no

Re: Unsafe CPOWs are about to be outlawed in browser code

2016-01-27 Thread Mike Conley
The spaghetti was put in the machine last night - this work has now landed on mozilla-central. If you start seeing "unsafe CPOW usage forbidden" in the Browser Console for various things, please mark them blocking bug 1233497. Thanks all, -Mike On 20/01/2016 3:54 PM, Mike Co

Re: Just Autoland It

2016-01-26 Thread Mike Conley
FWIW, adding r- abilities is bug 1197879[1]. There's a prototype patch that adds the UI, but I believe the MozReview team was still trying to sort out the best terminology to use. [1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1197879 On 26/01/2016 10:46 AM, Benjamin Smedberg wrote: > > >

Re: Just Autoland It

2016-01-25 Thread Mike Conley
I should point out that these interdiff issues are being actively worked on. At least one of them, bug 1238000[1], already has a patch that's under review to land in core[2]. Just be sure to file them. Having talked to the MozReview team about these types of bugs, I do know that trust-worthiness

Re: Proposed changes to Talos (performance) alerting

2016-01-20 Thread Mike Conley
>> >> As Joel mentioned, it's pretty easy to schedule profiling runs for talos >> using trychooser. Scheduling a profiling run as part of the >> regression-filing process is something we could consider doing, if >> there's a broad consensus it would be useful (I'm always wary of putting >> extra

Unsafe CPOWs are about to be outlawed in browser code

2016-01-20 Thread Mike Conley
(cross-posted to both dev-platform and firefox-dev) TL;DR: Shortly, I’ll be flipping a pref to outlaw unsafe CPOWs in almost all browser code. Unsafe CPOWs inside add-on scopes should continue to work properly. If you start seeing "unsafe CPOW usage forbidden” errors being throw for a feature

Re: Too many oranges!

2015-12-22 Thread Mike Conley
I would support scheduled time[1] to do maintenance[2] and help improve our developer tooling and documentation. I'm less sure how to integrate such a thing in practice. [1]: A day, a week, heck maybe even a release cycle [2]: Where maintenance is fixing oranges, closing out papercuts,

Re: Too many oranges!

2015-12-22 Thread Mike Conley
fixing tests, > bug triaging, no feature development at all). > > Thoughts? > > On Tue, Dec 22, 2015 at 7:41 AM Mike Conley <mcon...@mozilla.com > <mailto:mcon...@mozilla.com>> wrote: > > I would support scheduled time[1] to do maintenance[2] and help >

Re: SPS Profiles are now captured for entire subprocess lifetime

2015-12-04 Thread Mike Conley
es was a prerequisite for being able to do that. > > On Thu, Dec 3, 2015 at 4:52 PM, Mike Conley <mcon...@mozilla.com> wrote: > > Just a heads up that there have been recent developments with regards to > > gathering SPS profiles from multiple processes. > > > > B

SPS Profiles are now captured for entire subprocess lifetime

2015-12-03 Thread Mike Conley
Just a heads up that there have been recent developments with regards to gathering SPS profiles from multiple processes. Bug 1103094[1] recently landed in mozilla-central, which makes it so that if a subprocess starts up _after_ profiling has already been started in the parent, then the

Re: Faster Windows builds on Try

2015-11-19 Thread Mike Conley
This is the greatest! Thank you so much! On 19/11/2015 3:23 PM, Chris AtLee wrote: > Over the past months we've been working on migrating our Windows builds > from the legacy hardware machines into Amazon. > > I'm very happy to announce that we've wrapped up the initial work here, and > all our

Re: Proposal to converge with Chromium / Blink for not firing events on ’s from dropdowns

2015-10-16 Thread Mike Conley
56 PM, Ehsan Akhgari wrote: > On 2015-10-16 12:16 PM, Justin Dolske wrote: >> On 10/16/15 7:20 AM, Ehsan Akhgari wrote: >>> On 2015-10-15 5:00 PM, Mike Conley wrote: >>>> Note that this should not affect Gecko’s behaviour when the is >>>> displayed “inline”

Re: Proposal to converge with Chromium / Blink for not firing events on ’s from dropdowns

2015-10-16 Thread Mike Conley
that all browsers seem to fire events for mouseover, mousedown, keyup, keydown, etc. It's only the dropdown case that seems to be special for each browser - likely due to the fact that the spec is vague for that case. On 2015-10-16 10:20 AM, Ehsan Akhgari wrote: > On 2015-10-15 5:00 PM, Mike

Re: Proposal to converge with Chromium / Blink for not firing events on ’s from dropdowns

2015-10-16 Thread Mike Conley
rhaps I'll work with you to hammer out that part of the spec. On 2015-10-16 4:12 AM, Anne van Kesteren wrote: > On Thu, Oct 15, 2015 at 11:00 PM, Mike Conley <mcon...@mozilla.com> wrote: >> Are there any objections or thoughts about this plan? > > You should check what the

Proposal to converge with Chromium / Blink for not firing events on ’s from dropdowns

2015-10-15 Thread Mike Conley
Hey dev-platform, TL;DR: I want Gecko to stop firing events on ’s on dropdowns. Context: Bug 1090602 was filed way back in the day by someone who used the old Treestatus app, because they noticed it was broken once e10s was flipped on by default. The problem was that the old Treestatus app

Intent to unship: dialog=1 for window.open from web content

2015-10-09 Thread Mike Conley
One of the arguments to window.open[1] is a “feature string” that is used to do things like set the size of the newly opened window, to set whether or not it is resizable, etc. Gecko currently supports a “dialog” feature that is really only evident on Windows platforms. This dialog feature

Re: dialog=1 for window.open from content

2015-10-05 Thread Mike Conley
Unfortunately, it looks like the kind of counter I would need is not yet supported[1]. Even if some bank in the world is using dialog=1, what does it give them? It doesn't change the behaviour of the window like showModalDialog (which runs in a nested event loop), it just changes the buttons

dialog=1 for window.open from content

2015-10-01 Thread Mike Conley
Hello dev-platform, I'm currently working on bug 1095236 - that's an e10s bug for us failing to open any windows if the features string includes dialog=1 (or dialog=yes). According to [1], setting dialog=1 makes a popup window that removes the min/max/restore buttons, and no "command" menu (the

Re: Is there any events before loading a URL to a docshell.

2015-09-14 Thread Mike Conley
Hey Yonggang, You might find nsIWebProgressListener useful: https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIWebProgressListener Specifically the onLocationChange method. This is fired once we've determined that we're going to load a new URI for a DOM Window.

Re: Proposal to remove `aFoo` prescription from the Mozilla style guide for C and C++

2015-07-07 Thread Mike Conley
I suspect that knowing what things were passed into a method or function is something that can be divined via static analysis. Aren't there tools for our (admittedly varied) editors / IDEs to make the readability that people are getting from aFoo readily available, but that don't also require us

Re: Shutdown hangs are very common

2015-07-06 Thread Mike Conley
Should fixing shutdown hangs be higher priority? Starting and shutting down properly (and quickly), IMO, fall into the core quality / no compromise / we have to get this right bucket. So making it higher priority sounds aligned with the Three Pillars. And if so, should we allow features with

Re: Is there an e10s plan for multiple content processes?

2015-05-05 Thread Mike Conley
not going to ship The Spinner Experience, because shipping it as-is is beyond ill-advised. :D -Mike On 05/05/2015 10:49 AM, Ehsan Akhgari wrote: On 2015-05-05 10:30 AM, Mike Conley wrote: The e10s team is currently only focused on getting things to work with a single content process at this time. We

Re: Is there an e10s plan for multiple content processes?

2015-05-05 Thread Mike Conley
Funny folks should bring this up - I recently wrote a blog post about this: http://mikeconley.ca/blog/2015/05/04/electrolysis-and-the-big-tab-spinner-of-doom/ Funny how things cluster. :) I suggest reading that top to bottom before you continue reading this post. ... Welcome back! :D The e10s

Re: Is there an e10s plan for multiple content processes?

2015-05-05 Thread Mike Conley
ship-worthy instead of resorting to heroics to get processCount=1 ship-worthy? On Tue, May 5, 2015 at 10:41 AM, Mike Conley mcon...@mozilla.com mailto:mcon...@mozilla.com wrote: Is there a more detailed description of what the issues with multiple content processes are that e10s itself

Cleopatra can take larger profiles now.

2015-04-30 Thread Mike Conley
Good news everybody! TL;DR: Cleopatra used to have a limitation where it would only accept profiles of around 10MB. We've now made it so that Cleopatra can accept much, much larger profiles. This is going to become increasingly important as more profile-able processes get added. As an added

Re: How to use review-board to post a set of changes?

2015-04-19 Thread Mike Conley
Hey Yonggang, Your best bet is push your changesets to the MozReview repo - it'll do the job of creating your review requests for you. There is a little bit of setup involved in order to make it possible, however - you need to install a Mercurial extension, and you need to configure Mercurial so

Re: Press Me! Button

2014-07-31 Thread Mike Conley
A quick scan through DXR doesn't show any reference to Press Me! or Press Me in our strings, except for a likely coincidental match in some accessibility test[1]. Can you show us a screenshot of this button? [1]:

Re: e10s startup?

2014-07-29 Thread Mike Conley
At least for xul:browser where remote=true, we behave as you describe; namely, we use the remote-browser binding defined in toolkit/content/widgets/remote-browser.xml, which on construction, injects a browser-child.js frame script via the message manager. On 29/07/2014 4:58 AM, Neil wrote: How

Re: Update on sheriff-assisted checkin-needed bugs

2014-05-21 Thread Mike Conley
I try to mentor as many bugs as possible. My ideal workflow would be to grant r+, suggest a try: string, and set checkin-needed in a single act, without having to determine whether the contributor has try access and/or editbugs. If we already have people scanning for checkin-needed and looking

Re: Recommendations on source control and code review

2014-04-11 Thread Mike Conley
SmartBear's tools, of course.) Mozillian Mike Conley reviewed SmartBear's study on his blog [2]. The results are interesting and actionable. Some highlights: * Review fewer than 200-400 lines of code at a time. * Spend no more than 60-90 minutes per review session. * Authors should pre-review

Re: Poll: What do you need in MXR/DXR?

2013-10-02 Thread Mike Conley
I love DXR for mozilla-central, and would love it if the UX branch (https://mxr.mozilla.org/projects-central/source/ux/) was indexed there as well! Keep up the great work, -Mike On 02/10/2013 3:33 PM, Erik Rose wrote: What features do you most use in MXR and DXR? Over in the recently

Re: Code Review Session

2013-05-24 Thread Mike Conley
Sounds like we're talking about code review. But I want to qualify integration into bugzilla: I explicitly do not want a tool that is tightly coupled to bugzilla. In fact, I want a tool that has as little to do with bugzilla as feasible. I'm a contributor to the Review Board project[1],