Re: How to reliably make an ArrayBufferView wrapped?

2019-03-25 Thread violet . bugreport
Thank you for the detailed explanation! It works.

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: How to reliably make an ArrayBufferView wrapped?

2019-03-25 Thread violet . bugreport
> Are you trying to write a JS shell test or a browser test?

I think it should be a browser test, because I need to call IndexedDB.
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


How to reliably make an ArrayBufferView wrapped?

2019-03-25 Thread violet . bugreport
When solving this bug https://phabricator.services.mozilla.com/D24009. I need 
to write a test. The bug is basically caused by overlooking the possible 
wrapper around an ArrayBufferView that is checked by 
JS_IsArrayBufferViewObject().

See 
https://searchfox.org/mozilla-central/source/js/src/vm/ArrayBufferViewObject.cpp#164,
 the check will return true if canUnwrapAs(), it's 
possible that the object itself is not an ArrayBufferView.

In the test, I want to make sure the object is indeed a wrapped one. Is there a 
reliable way to write JavaScript code to achieve this?

Thanks!
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: android-em-4-3-armv7-api16 possibly falsy timeout

2019-03-19 Thread violet . bugreport
It's clean now that the tests were successfully passed, the problem is on the 
testing platform.

I've filed a new bug for the problem and marked these intermittent timeout 
failure as duplicates.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1536696
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


android-em-4-3-armv7-api16 possibly falsy timeout

2019-03-18 Thread violet . bugreport
Hi,

There are some strange intermittent timeout reports on 
android-em-4-3-armv7-api16 platform, I suspect there is something wrong on this 
test platform.

https://bugzilla.mozilla.org/show_bug.cgi?id=1533737
https://bugzilla.mozilla.org/show_bug.cgi?id=1535286
https://bugzilla.mozilla.org/show_bug.cgi?id=1534079

All of the tests are recently added, they are completely unrelated to each 
other, and there are no other failures on these tests.

But they have one or two intermittent failure on "android-em-4-3-armv7-api16". 
I'm familiar with 2 of the testcases, they are impossible to cause a timeout. 
Especially Bug 1535286 is just a patch to remove a bogus assertion with a 
trivial testcase ``, which literally is impossible to timeout.

Could anyone investigate whether there are some problems on 
"android-em-4-3-armv7-api16" to cause newly added testcase to timeout?

Thanks.
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Where to put timeout test?

2019-03-06 Thread violet . bugreport
On Tuesday, March 5, 2019 at 10:12:48 PM UTC-8, Cameron McCormack wrote:

> You can use a crashtest for this under layout/svg/crashtests/.  crashtests 
> are like reftests that don't actually check against a reference, but will 
> just fail if the test crashes, or causes some assertions, or times out.

Thanks, it works!
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Where to put timeout test?

2019-03-05 Thread violet . bugreport
Hi,

When fixing [this](https://phabricator.services.mozilla.com/D20947) bug, I need 
to add a test. If the patch is not applied, the test will spend almost infinite 
time to render a SVG; while if the patch is applied, it can be rendered 
instantly.

However, both the reviewer and me don't know how to put a timeout test. It 
won't crash in any case, so it's not a crash test. But the mochitest can only 
be used to check JavaScript assertion, if I use mochitest, the test utility 
will hang waiting for JavaScript stuff, then eventually timeout because there 
is nothing to assert.

Where to put a testcase like this?

Thanks!
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform