On Mon, Dec 17, 2018 at 1:22 PM Steve Fink wrote:
> In theory, I would definitely prefer if all the code were auto-formatted
> during regular development(*), but in practice the performance means
> it's not as transparent as it needs to be -- I have noticed that since
> enabling the format-source
On Fri, Dec 14, 2018 at 4:55 PM Kartikaya Gupta wrote:
> On Fri, Dec 14, 2018 at 1:58 PM Sylvestre Ledru
> wrote:
> > We have more and more tools at review phase (clang-format, flake8,
> eslint, clang-tidy, codespell, etc) which propose some auto-fixes.
>
> Honestly I find it quite annoying when
In theory, I would definitely prefer if all the code were auto-formatted
during regular development(*), but in practice the performance means
it's not as transparent as it needs to be -- I have noticed that since
enabling the format-source extension, rebasing my patch stacks is
significantly sl
Le 14/12/2018 à 22:55, Kartikaya Gupta a écrit :
On Fri, Dec 14, 2018 at 1:58 PM Sylvestre Ledru wrote:
We have more and more tools at review phase (clang-format, flake8, eslint,
clang-tidy, codespell, etc) which propose some auto-fixes.
Honestly I find it quite annoying when I'm trying to r
Hi
> On 14 Dec 2018, at 7:57 pm, Sylvestre Ledru wrote:
>
> I think we should aim at option b) (updated automatically by bots after
> submission to Phabricator)
>
>
I don’t particularly fancy this idea. Finding yourself with different code on
Phabricator and locally is a good way to shoot y
I think we should aim at option b) (updated automatically by bots after
submission to Phabricator)
We have more and more tools at review phase (clang-format, flake8,
eslint, clang-tidy, codespell, etc) which propose some auto-fixes.
Currently, the turn around time of the tools is 14m on avera
On Fri, Dec 14, 2018 at 1:58 PM Sylvestre Ledru wrote:
> We have more and more tools at review phase (clang-format, flake8, eslint,
> clang-tidy, codespell, etc) which propose some auto-fixes.
Honestly I find it quite annoying when I'm trying to review a patch
and the phabricator diff is filled
7 matches
Mail list logo
