Re: Finding windows and docshells leaked until shutdown

2019-10-04 Thread Greg Tatum
I started a section on dealing with leaks on the MDN mochitest page. Feel free to contribute to it with any tips that may be useful to others. I got pointed to this thread when I was asking for some help on leaks yesterday. I couldn't find any details when searching online for anything around the

Re: Finding windows and docshells leaked until shutdown

2019-10-03 Thread smaug
On 10/3/19 1:18 AM, Andrew McCreight wrote: On Wed, Oct 2, 2019 at 2:35 PM Geoff Lankow wrote: Hi all, I need some advice. I'm trying to enable Mochitest on debug builds of Thunderbird. It works fine, except for the leak check, which finds a number of leaked windows and docshells. Obviously

Re: Finding windows and docshells leaked until shutdown

2019-10-02 Thread Andrew McCreight
On Wed, Oct 2, 2019 at 2:35 PM Geoff Lankow wrote: > Hi all, I need some advice. > > I'm trying to enable Mochitest on debug builds of Thunderbird. It works > fine, except for the leak check, which finds a number of leaked windows > and docshells. Obviously we don't want to leak these things,

Re: Finding windows and docshells leaked until shutdown

2019-10-02 Thread Emilio Cobos Álvarez
Not an expert in leak-hunting, but generally this happens every time you leave something like an observer or such registered and you don't de-register it where the page goes away. It'd keep all the window alive. Probably can also happen with some native event listeners or what not... A recent

Finding windows and docshells leaked until shutdown

2019-10-02 Thread Geoff Lankow
Hi all, I need some advice. I'm trying to enable Mochitest on debug builds of Thunderbird. It works fine, except for the leak check, which finds a number of leaked windows and docshells. Obviously we don't want to leak these things, but I can't find what's holding onto them. I've ruled out