Re: Please don't use functions from ctype.h and strings.h

2020-06-26 Thread Jason Orendorff
This turns out to be super easy to do in clang-tidy, so I took bug 1485588. -j On Wed, Jun 24, 2020 at 2:35 PM Chris Peterson wrote: > On 8/27/2018 7:00 AM, Henri Sivonen wrote: > > I think it's worthwhile to have a lint, but regexps are likely to have > > false positives, so using clang-tidy i

Re: Please don't use functions from ctype.h and strings.h

2020-06-25 Thread Henri Sivonen
On Wed, Jun 24, 2020 at 10:35 PM Chris Peterson wrote: > > On 8/27/2018 7:00 AM, Henri Sivonen wrote: > > I think it's worthwhile to have a lint, but regexps are likely to have > > false positives, so using clang-tidy is probably better. > > > > A bug is on file:https://bugzilla.mozilla.org/show_b

Re: Please don't use functions from ctype.h and strings.h

2020-06-24 Thread Chris Peterson
On 8/27/2018 7:00 AM, Henri Sivonen wrote: I think it's worthwhile to have a lint, but regexps are likely to have false positives, so using clang-tidy is probably better. A bug is on file:https://bugzilla.mozilla.org/show_bug.cgi?id=1485588 On Mon, Aug 27, 2018 at 4:06 PM, Tom Ritter wrote: I

Re: Please don't use locale-dependent C standard library functions (was: Re: Please don't use functions from ctype.h and strings.h)

2020-06-15 Thread Frederik Braun
I'm in the process of setting up documentation & examples on how to implement new static analysis checks. If we're OK with turning new usages of these functions into errors, I can help whoever is volunteering to do this. Am 12.06.20 um 22:40 schrieb Jeff Gilbert: > It would be great to have CI li

Re: Please don't use locale-dependent C standard library functions (was: Re: Please don't use functions from ctype.h and strings.h)

2020-06-12 Thread Jeff Gilbert
It would be great to have CI linting for these! On Fri, Jun 12, 2020 at 2:19 AM Henri Sivonen wrote: > > This is an occasional re-reminder that anything in the C standard > library that is locale-sensitive is fundamentally broken and should > not be used. > > Today's example is strerr(), which re

Please don't use locale-dependent C standard library functions (was: Re: Please don't use functions from ctype.h and strings.h)

2020-06-12 Thread Henri Sivonen
This is an occasional re-reminder that anything in the C standard library that is locale-sensitive is fundamentally broken and should not be used. Today's example is strerr(), which returns a string that is meant to be rendered to the user, but the string isn't guaranteed to be UTF-8. On Mon, Aug

Re: Please don't use functions from ctype.h and strings.h

2018-08-27 Thread Henri Sivonen
I think it's worthwhile to have a lint, but regexps are likely to have false positives, so using clang-tidy is probably better. A bug is on file: https://bugzilla.mozilla.org/show_bug.cgi?id=1485588 On Mon, Aug 27, 2018 at 4:06 PM, Tom Ritter wrote: > Is this something worth making a lint over?

Re: Please don't use functions from ctype.h and strings.h

2018-08-27 Thread Tom Ritter
Is this something worth making a lint over? It's pretty easy to make regex-based lints, e.g. yml-only based lint: https://searchfox.org/mozilla-central/source/tools/lint/cpp-virtual-final.yml yml+python for slightly more complicated regexing: https://searchfox.org/mozilla-central/source/tools/li

Please don't use functions from ctype.h and strings.h

2018-08-27 Thread Henri Sivonen
Please don't use the functions from ctype.h and strings.h. See: https://daniel.haxx.se/blog/2018/01/30/isalnum-is-not-my-friend/ https://daniel.haxx.se/blog/2008/10/15/strcasecmp-in-turkish/ https://stackoverflow.com/questions/2898228/can-isdigit-legitimately-be-locale-dependent-in-c In addition