Re: #include sorting: case-sensitive or -insensitive?

Any reason not to adopt SpiderMonkey's check_spidermonkey_style.py? It deals almost exclusively with header and include related things, and not indent levels, line lengths, or other things that gecko style disagrees with.

Re: #include sorting: case-sensitive or -insensitive?

a) It's explained in the style docs: 1. The main header: Foo.h in Foo.cpp 2. Standard library includes: #include 3. Mozilla includes: #include "mozilla/dom/Element.h" Thus you'd want the second b) I'm assuming it includes the path. That's what I've seen most of the code do too and it

Re: #include sorting: case-sensitive or -insensitive?

David Keeler: > The style guidelines at > https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style > indicate that #includes are to be sorted. It does not say whether or not > to consider case when doing so (and if so, which case goes first?). That > is, should it be: > >

Re: #include sorting: case-sensitive or -insensitive?

On Mon, Mar 28, 2016 at 3:31 PM, Masatoshi Kimura wrote: > On 2016/03/29 7:18, Jared Wein wrote: > > We need to be careful with shuffling around #includes as there can be > > ordering dependencies that are not obvious at a glance. > > Especially, #include "Foo.h" should be

Re: #include sorting: case-sensitive or -insensitive?

On 2016/03/29 7:18, Jared Wein wrote: > We need to be careful with shuffling around #includes as there can be > ordering dependencies that are not obvious at a glance. Especially, #include "Foo.h" should be put first in Foo.cpp regardless of the alphabetical order to avoid introducing such

Re: #include sorting: case-sensitive or -insensitive?

We need to be careful with shuffling around #includes as there can be ordering dependencies that are not obvious at a glance. Further, I don't think this is something worthwhile until we have a script that enforces said ordering. Thanks, Jared On Mon, Mar 28, 2016 at 5:20 PM, Nicholas Alexander

Re: #include sorting: case-sensitive or -insensitive?

On Mon, Mar 28, 2016 at 1:28 PM, David Keeler wrote: > (Everyone, start your bikesheds.) > > The style guidelines at > > https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style > indicate that #includes are to be sorted. It does not say whether or not >

#include sorting: case-sensitive or -insensitive?

(Everyone, start your bikesheds.) The style guidelines at https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style indicate that #includes are to be sorted. It does not say whether or not to consider case when doing so (and if so, which case goes first?). That is, should it