On Fri, Nov 27, 2015 at 02:53:35PM -0800, Dave Townsend wrote:
Going forwards we'd like to enable it in more directories and turn on
more rules. You can help! If there is a directory you work in a lot
try removing it from the top-level .eslintignore file and see what
fails, then fix it. Mostly it
I've additionally filed
https://bugzilla.mozilla.org/show_bug.cgi?id=1229106 to get an
ESLint-powered mozreviewbot[1] written.
[1]: An automated reviewing bot that bug 1196263 added infrastructure for.
On 30/11/2015 2:13 PM, Dave Townsend wrote:
> Over in https://bugzilla.mozilla.org/show_bug.cgi
The plan in general for chrome JS is to switch from #ifdefs to having
things defined in AppConstants.jsm
Fabrice
On 11/30/2015 01:05 AM, Tim Guan-tin Chien wrote:
> The Gecko JavaScript is also littered with #ifdef and # is really not a
> token for comment in JS... is there any plan to mi
Over in https://bugzilla.mozilla.org/show_bug.cgi?id=1229097 I'm
proposing a default set of rules that browser and toolkit code should
aspire to. It's based on flagging obvious mistakes and things that
will confuse and then following what I've seen to be the rough
consensus coding style we use.
It
On Mon, Nov 30, 2015 at 6:34 AM, Tim Guan-tin Chien
wrote:
> Thanks, bug 1150859 only covers ./browser/.
> Is this a done deal which we want to get rid of #ifdef in all JS code
> everywhere?
>
> (My particular interest would be obviously ./dom/ and ./b2g/)
>
Make this happen! Fennec (mobile/and
Thanks, bug 1150859 only covers ./browser/.
Is this a done deal which we want to get rid of #ifdef in all JS code
everywhere?
(My particular interest would be obviously ./dom/ and ./b2g/)
On Mon, Nov 30, 2015 at 5:44 PM, Gijs Kruitbosch
wrote:
> Yes. See bug 1150859 and friends.
>
> ~ Gijs
>
>
On 30.11.2015 10:29, Patrick Brosset wrote:
> I don't how much work is involved with getting rid of non-standard
> spidermonkey syntax and pre-processors, but if it's a lot, then one option
> would be to fork the espree parser (used by eslint), make it support those,
> and configure eslint to use o
Yes. See bug 1150859 and friends.
~ Gijs
On 30/11/2015 09:05, Tim Guan-tin Chien wrote:
The Gecko JavaScript is also littered with #ifdef and # is really not a
token for comment in JS... is there any plan to migrate that away since
there is ESLint present?
On Sun, Nov 29, 2015 at 10:37 PM, Viv
I don't how much work is involved with getting rid of non-standard
spidermonkey syntax and pre-processors, but if it's a lot, then one option
would be to fork the espree parser (used by eslint), make it support those,
and configure eslint to use our fork:
http://eslint.org/docs/user-guide/configuri
The Gecko JavaScript is also littered with #ifdef and # is really not a
token for comment in JS... is there any plan to migrate that away since
there is ESLint present?
On Sun, Nov 29, 2015 at 10:37 PM, Vivien Nicolas
wrote:
> On Sun, Nov 29, 2015 at 2:30 PM, David Bruant wrote:
>
> > Hi,
> >
>
On Sun, Nov 29, 2015 at 2:30 PM, David Bruant wrote:
> Hi,
>
> Just a drive-by comment to inform folks that there is an effort to
> transition Mozilla JavaScript codebase to standard JavaScript.
> Main bugs is: https://bugzilla.mozilla.org/show_bug.cgi?id=867617
>
> And https://bugzilla.mozilla.o
Hi,
Just a drive-by comment to inform folks that there is an effort to
transition Mozilla JavaScript codebase to standard JavaScript.
Main bugs is: https://bugzilla.mozilla.org/show_bug.cgi?id=867617
And https://bugzilla.mozilla.org/show_bug.cgi?id=1103158 is about
removing non-standard featu
Thanks to some speedy work by Mark Banner and help from Mike Conley,
Felipe Gomes and Gijs Kruitbosch we've now landed the changes to make
it possible to run "mach eslint" on any directory in the tree.
The default rules for the tree are almost non-existent so this is
mostly checking for syntax err
13 matches
Mail list logo
