Re: Follow up on clang-format

2017-09-29 Thread Jeff Gilbert
Now instead we will get to try to phrase code in a way that clang-format will preserve readably? I should think "it doesn't always produce nice formatting, but it's at least consistent" sounds like a major warning sign, particularly given that we definitely have tricky code for which we have made

Re: Follow up on clang-format

2017-09-29 Thread Sylvestre Ledru
Le 28/09/2017 à 23:21, Randell Jesup a écrit : >> On Thursday, September 28, 2017 at 10:15:05 AM UTC+2, Chris Pearce wrote: >> Oh d'oh! Looks like I replied to an old thread, and the plan now is in fact >> to clang-format the entire tree after 57. Sweet as! > Where did you find that? Was this

Re: Follow up on clang-format

2017-09-28 Thread Randell Jesup
>On Thursday, September 28, 2017 at 10:15:05 AM UTC+2, Chris Pearce wrote: >Oh d'oh! Looks like I replied to an old thread, and the plan now is in fact >to clang-format the entire tree after 57. Sweet as! Where did you find that? Was this plan communicated? It's not in this thread... (which

Re: Follow up on clang-format

2017-09-28 Thread Chris Pearce
On Thursday, September 28, 2017 at 10:15:05 AM UTC+2, Chris Pearce wrote: > On Friday, May 23, 2014 at 3:29:48 AM UTC+2, Anthony Jones wrote: > > Some of you may remember the discussion on clang-format and the `mach > > clang-format` command. What we have in place right now is very temporary > >

Re: Follow up on clang-format

2017-09-28 Thread Chris Pearce
On Friday, May 23, 2014 at 3:29:48 AM UTC+2, Anthony Jones wrote: > Some of you may remember the discussion on clang-format and the `mach > clang-format` command. What we have in place right now is very temporary > but it is functional enough to give it a try. I have not put the effort > into

Re: Follow up on clang-format

2017-09-26 Thread Martin Thomson
On Wed, Sep 27, 2017 at 7:34 AM, Mike Hommey wrote: > And then you end up with something like: > > class Foo { > Type MethodA() { do_something(); } > Type MethodB() > { > do_something_that_happens_to_be_long_enough_not_to_fit_on_the_same_line(); > } > Type

Re: Follow up on clang-format

2017-09-26 Thread Martin Thomson
On Tue, Sep 26, 2017 at 10:49 PM, Sylvestre Ledru wrote: >> clang-format messes up really badly many macros. >> For example nsElementTable.cpp becomes unreadable. > > Yeah, for this kind of structure & presentation layout, we should just ignore the formatting on these. > > It

Re: Follow up on clang-format

2017-09-26 Thread Mike Hommey
On Tue, Sep 26, 2017 at 02:49:56PM +0200, Sylvestre Ledru wrote: > Le 26/09/2017 à 14:33, smaug a écrit : > > On 05/23/2014 04:29 AM, Anthony Jones wrote: > >> Some of you may remember the discussion on clang-format and the `mach > >> clang-format` command. What we have in place right now is very

Re: Follow up on clang-format

2017-09-26 Thread Sylvestre Ledru
Le 26/09/2017 à 14:33, smaug a écrit : > On 05/23/2014 04:29 AM, Anthony Jones wrote: >> Some of you may remember the discussion on clang-format and the `mach >> clang-format` command. What we have in place right now is very temporary >> but it is functional enough to give it a try. I have not put

Re: Follow up on clang-format

2017-09-26 Thread smaug
On 05/23/2014 04:29 AM, Anthony Jones wrote: Some of you may remember the discussion on clang-format and the `mach clang-format` command. What we have in place right now is very temporary but it is functional enough to give it a try. I have not put the effort into upstreaming my changes.

Re: Follow up on clang-format

2014-06-26 Thread Sylvestre Ledru
On 22/05/2014 18:29, Anthony Jones wrote: Some of you may remember the discussion on clang-format and the `mach clang-format` command. What we have in place right now is very temporary but it is functional enough to give it a try. I have not put the effort into upstreaming my changes.

Re: Follow up on clang-format

2014-05-23 Thread Kartikaya Gupta
I tried using clang-format on entire files and I noticed two things (there might be others, I didn't look too closely): 1) When it reformats comments to fit in the line length, it just inserts linebreaks rather than rewrapping the text. So you end up with text like this, where the last couple

Follow up on clang-format

2014-05-22 Thread Anthony Jones
Some of you may remember the discussion on clang-format and the `mach clang-format` command. What we have in place right now is very temporary but it is functional enough to give it a try. I have not put the effort into upstreaming my changes. Depending on the feedback I receive I will either: *