Re: Intent to implement HTMLMediaElement.srcObject partially

2015-07-20 Thread Jonas Sicking
On Mon, Jul 20, 2015 at 12:27 AM, Robert O'Callahan wrote: > On Mon, Jul 20, 2015 at 6:33 PM, Jonas Sicking wrote: >> >> Good point. We also need to call >> URL.revokeObjectURL(this.mOldObjectURL); in the .src setter and in the >> dtor. > > > OK, but we still leak if someone saves a reference to

Re: Intent to implement HTMLMediaElement.srcObject partially

2015-07-20 Thread Robert O'Callahan
On Mon, Jul 20, 2015 at 6:33 PM, Jonas Sicking wrote: > Good point. We also need to call > URL.revokeObjectURL(this.mOldObjectURL); in the .src setter and in the > dtor. > OK, but we still leak if someone saves a reference to the HTMLMediaElement as an expando property of the Blob/File. It woul

Re: Intent to implement HTMLMediaElement.srcObject partially

2015-07-19 Thread Jonas Sicking
On Sun, Jul 19, 2015 at 2:45 PM, Robert O'Callahan wrote: > On Thu, Jul 16, 2015 at 5:09 PM, Jonas Sicking wrote: >> >> On Wed, Jul 15, 2015 at 12:42 PM, Jan-Ivar Bruaroey >> wrote: >> > This means it will throw TypeError on set of: MediaSource objects, Blob >> > objects, and File objects, for n

Re: Intent to implement HTMLMediaElement.srcObject partially

2015-07-19 Thread Robert O'Callahan
On Thu, Jul 16, 2015 at 5:09 PM, Jonas Sicking wrote: > On Wed, Jul 15, 2015 at 12:42 PM, Jan-Ivar Bruaroey > wrote: > > This means it will throw TypeError on set of: MediaSource objects, Blob > > objects, and File objects, for now. > > For what it's worth, I think implementing Blob/File support

Re: Intent to implement HTMLMediaElement.srcObject partially

2015-07-19 Thread Karl Tomlinson
> AFAIK there is no webkitSrcObject, and Chrome/Opera use: > > video.src = URL.createObjectURL(stream); > > which works, but as I understand it leaves blobs around to be > garbage collected. In Gecko, object URLs from MediaStreams are currently not auto-revoked, so the MediaStream will not be

Re: Intent to implement HTMLMediaElement.srcObject partially

2015-07-19 Thread Jan-Ivar Bruaroey
On 7/15/15 11:50 PM, Boris Zbarsky wrote: On 7/15/15 3:42 PM, Jan-Ivar Bruaroey wrote: This means it will support get/set of: MediaStream objects. This means it will throw TypeError on set of: MediaSource objects, Blob objects, and File objects, for now. Jan-Ivar, Do you happen to know wheth

Re: Intent to implement HTMLMediaElement.srcObject partially

2015-07-16 Thread Martin Thomson
This sounds like a good idea. On Jul 15, 2015 10:10 PM, "Jonas Sicking" wrote: > On Wed, Jul 15, 2015 at 12:42 PM, Jan-Ivar Bruaroey > wrote: > > This means it will throw TypeError on set of: MediaSource objects, Blob > > objects, and File objects, for now. > > For what it's worth, I think imple

Re: Intent to implement HTMLMediaElement.srcObject partially

2015-07-15 Thread Jonas Sicking
On Wed, Jul 15, 2015 at 12:42 PM, Jan-Ivar Bruaroey wrote: > This means it will throw TypeError on set of: MediaSource objects, Blob > objects, and File objects, for now. For what it's worth, I think implementing Blob/File support would be quite trivial. Just make elem.srcObject = blob; interna

Re: Intent to implement HTMLMediaElement.srcObject partially

2015-07-15 Thread Boris Zbarsky
On 7/15/15 3:42 PM, Jan-Ivar Bruaroey wrote: This means it will support get/set of: MediaStream objects. This means it will throw TypeError on set of: MediaSource objects, Blob objects, and File objects, for now. Jan-Ivar, Do you happen to know whether other UAs support this unprefixed and if

Re: Intent to implement HTMLMediaElement.srcObject partially

2015-07-15 Thread Jan-Ivar Bruaroey
On 7/15/15 9:28 PM, jyaven...@mozilla.com wrote: I need to complete bug 886194 then (that add MSE supports). Yes, or at least rename the subject slightly. ;) PS: We have the same first name in different language. awesome. Hey, that's rare for us! .: Jan-Ivar :. ___

Re: Intent to implement HTMLMediaElement.srcObject partially

2015-07-15 Thread jyavenard
On Thursday, July 16, 2015 at 5:42:39 AM UTC+10, Jan-Ivar Bruaroey wrote: > Hi, > > We intend to un-prefix HTMLMediaElement.srcObject (it currently exists > as HTMLMediaElement.mozSrcObject), even though it only supports a subset > of the types mandated in the spec. [1] > > This means it will s

Re: Intent to implement HTMLMediaElement.srcObject partially

2015-07-15 Thread smaug
On 07/15/2015 10:42 PM, Jan-Ivar Bruaroey wrote: Hi, We intend to un-prefix HTMLMediaElement.srcObject (it currently exists as HTMLMediaElement.mozSrcObject), even though it only supports a subset of the types mandated in the spec. [1] It is a bit unfortunate to expose the property without su

Re: Intent to implement HTMLMediaElement.srcObject partially

2015-07-15 Thread Robert O'Callahan
Hooray! Rob -- lbir ye,ea yer.tnietoehr rdn rdsme,anea lurpr edna e hnysnenh hhe uresyf toD selthor stor edna siewaoeodm or v sstvr esBa kbvted,t rdsme,aoreseoouoto o l euetiuruewFa kbn e hnystoivateweh uresyf tulsa rehr rdm or rnea lurpr .a war hsrer holsa rodvted,t nenh hneireseoouo

Intent to implement HTMLMediaElement.srcObject partially

2015-07-15 Thread Jan-Ivar Bruaroey
Hi, We intend to un-prefix HTMLMediaElement.srcObject (it currently exists as HTMLMediaElement.mozSrcObject), even though it only supports a subset of the types mandated in the spec. [1] This means it will support get/set of: MediaStream objects. This means it will throw TypeError on set of: