Re: Intent to make Form Autocomplete popups use richlistbox's instead of trees

[Mike Conley]

Resurrecting this old thread to let you all know that this autolanded last
night, and (if all goes well) should merge to mozilla-central soon. Thanks
to MattN for the reviews!

Dirty details are in https://bugzilla.mozilla.org/show_bug.cgi?id=1296638

On 20 August 2016 at 06:10, Gijs Kruitbosch 
wrote:

> On 19/08/2016 16:25, Mike Conley wrote:
>
>> Summary says it all. See
>> https://bugzilla.mozilla.org/show_bug.cgi?id=1296638 for details and
>> rationale.
>>
>> I have a working version of this on my local machine, and will likely put
>> it up for review today or early next week.
>>
>
> I probably don't need to tell you this, but just in case: please make sure
> this continues to be accessible to users who need a11y tools to whatever
> extent it works today. Not sure how much the a11y reflection of that popup
> is tied to the current implementation. Marco Zehe can probably help with
> testing/feedback if necessary.
>
> ~ Gijs
>
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Intent to make Form Autocomplete popups use richlistbox's instead of trees

[Gijs Kruitbosch]

On 19/08/2016 16:25, Mike Conley wrote:

Summary says it all. See
https://bugzilla.mozilla.org/show_bug.cgi?id=1296638 for details and
rationale.

I have a working version of this on my local machine, and will likely put
it up for review today or early next week.


I probably don't need to tell you this, but just in case: please make 
sure this continues to be accessible to users who need a11y tools to 
whatever extent it works today. Not sure how much the a11y reflection of 
that popup is tied to the current implementation. Marco Zehe can 
probably help with testing/feedback if necessary.


~ Gijs
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Intent to make Form Autocomplete popups use richlistbox's instead of trees

[Mike Conley]

Hey Sebastian,

Great question. The reason I'm choosing richlistbox is mostly for speed
and convenience, because a binding already exists
(autocomplete.xml#autocomplete-rich-result-popup) that will do what I
want (with some minor CSS tweaks), and I didn't want to write something
new from scratch.

I'm all for rewriting stuff in HTML where possible. I'll touch base with
the devtools team to see if I can use anything they've built instead. I
know, for example, that debugger.html seems to be using some kind of
React-based tree[1], but I'm still reasonably certain that a tree is not
what we want to use from these popups. A simple (but styleable) list
popup API would suffice.

Thanks,

-Mike

[1]:
https://github.com/devtools-html/debugger.html/blob/2f62b57660e257f8c952ea6e627577a652357377/public/js/components/SourcesTree.js


On 19/08/2016 12:52 PM, Sebastian Zartner wrote:
> Hi Mike,
> 
> I'm not much into that topic, though I'm wondering why you don't try to
> switch to HTML already as the DevTools team started to do[1] recently.
> 
> Sebastian
> 
> [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1263750
> 
> On 19 August 2016 at 17:25, Mike Conley  > wrote:
> 
> (Cross-posted to dev-platform and firefox-dev)
> 
> Hey folks,
> 
> If you don't work on front-endy things, you can safely ignore this.
> 
> Summary says it all. See
> https://bugzilla.mozilla.org/show_bug.cgi?id=1296638
>  for details
> and rationale.
> 
> I have a working version of this on my local machine, and will
> likely put it up for review today or early next week.
> 
> Mostly doing this shout-out for the other XUL apps out there that
> might be making use of Form Autocomplete, and might have some
> tree-specific stuff. Hoping they can weigh in if there's a problem.
> Fennec should be unaffected. TB and SM might be affected.
> 
> If there are any concerns with this plan, please respond to this
> thread on dev-platform and we can hash it out.
> 
> Thanks!
> 
> -Mike
> 
> ___
> firefox-dev mailing list
> firefox-...@mozilla.org 
> https://mail.mozilla.org/listinfo/firefox-dev
> 
> 
> 
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Intent to make Form Autocomplete popups use richlistbox's instead of trees

[Sebastian Zartner]

Hi Mike,

I'm not much into that topic, though I'm wondering why you don't try to
switch to HTML already as the DevTools team started to do[1] recently.

Sebastian

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1263750

On 19 August 2016 at 17:25, Mike Conley  wrote:

> (Cross-posted to dev-platform and firefox-dev)
>
> Hey folks,
>
> If you don't work on front-endy things, you can safely ignore this.
>
> Summary says it all. See https://bugzilla.mozilla.org/
> show_bug.cgi?id=1296638 for details and rationale.
>
> I have a working version of this on my local machine, and will likely put
> it up for review today or early next week.
>
> Mostly doing this shout-out for the other XUL apps out there that might be
> making use of Form Autocomplete, and might have some tree-specific stuff.
> Hoping they can weigh in if there's a problem. Fennec should be unaffected.
> TB and SM might be affected.
>
> If there are any concerns with this plan, please respond to this thread on
> dev-platform and we can hash it out.
>
> Thanks!
>
> -Mike
>
> ___
> firefox-dev mailing list
> firefox-...@mozilla.org
> https://mail.mozilla.org/listinfo/firefox-dev
>
>
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Intent to make Form Autocomplete popups use richlistbox's instead of trees

[Mike Conley]

(Cross-posted to dev-platform and firefox-dev)

Hey folks,

If you don't work on front-endy things, you can safely ignore this.

Summary says it all. See
https://bugzilla.mozilla.org/show_bug.cgi?id=1296638 for details and
rationale.

I have a working version of this on my local machine, and will likely put
it up for review today or early next week.

Mostly doing this shout-out for the other XUL apps out there that might be
making use of Form Autocomplete, and might have some tree-specific stuff.
Hoping they can weigh in if there's a problem. Fennec should be unaffected.
TB and SM might be affected.

If there are any concerns with this plan, please respond to this thread on
dev-platform and we can hash it out.

Thanks!

-Mike
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform