Re: Intent to unprefix grid-gap, grid-row-gap, and grid-column-gap and updating them to spec

2018-06-28 Thread Daniel Holbert
On Thu, Mar 29, 2018 at 8:19 AM, Mats Palmgren  wrote:

> Hi,
>
> In bug 1398482 I'm unprefixing the grid-gap, grid-row-gap, and
> grid-column-gap properties
>
[...]

>
> These properties also applies to Flexbox:
> https://drafts.csswg.org/css-align-3/#gap-flex
> We haven't implemented layout for that yet
>

Followup: Mihir Iyer has now landed a patch to make these properties work
in flexbox layout, over in
https://bugzilla.mozilla.org/show_bug.cgi?id=1398483

This functionality is in today's Nightly build. (See testcase on that bug
for an example.)
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Intent to unprefix grid-gap, grid-row-gap, and grid-column-gap and updating them to spec

2018-03-31 Thread Mats Palmgren

Hi,

In bug 1398482 I'm unprefixing the grid-gap, grid-row-gap, and
grid-column-gap properties.  The old names becomes aliases for
the respective unprefixed property.
I'm also adding support for the 'normal' keyword to these properties
and making it the initial value, per spec [1].

I'm also adding support for percentages to the existing unprefixed
column-gap property (which is only supported in multi-column layout
until now) in bug 1398537.  It already supports 'normal', so with
these changes it has the same syntax as the updated grid-column-gap
property so we can now "merge" them.

These properties also applies to Flexbox:
https://drafts.csswg.org/css-align-3/#gap-flex
We haven't implemented layout for that yet[2], so one could argue
that we shouldn't unprefix the grid-* properties until we do.
I think we should anyway, for two reasons:
1. Chrome decided to ship them[3] without Flexbox layout support,
   so it will likely lead to Grid web-compat issues soon unless we
   do the same
2. column-gap is already in the wild, so the problem already exists
   for this property with the spec generalizing it to Grid/Flexbox


/Mats

[1]
https://drafts.csswg.org/css-align-3/#column-row-gap

[2]
https://bugzilla.mozilla.org/show_bug.cgi?id=1398483

[3]
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/UViBfJuuIq8/w7_2W7lLAgAJ
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform