Re: Non-header-only headers shared between SpiderMonkey and the rest of Gecko

2019-08-12 Thread Henri Sivonen
On Tue, Aug 6, 2019 at 8:54 PM Kris Maglione wrote: > > On Tue, Aug 06, 2019 at 10:56:55AM +0300, Henri Sivonen wrote: > > Do we have some #ifdef for excluding parts of mfbt/ when mfbt/ is being used > > in a non-SpiderMonkey/Gecko context? > > #ifdef MOZ_HAS_MOZGLUE Thanks. This appears to be

Re: Non-header-only headers shared between SpiderMonkey and the rest of Gecko

2019-08-06 Thread Kris Maglione
On Tue, Aug 06, 2019 at 10:56:55AM +0300, Henri Sivonen wrote: Do we have some #ifdef for excluding parts of mfbt/ when mfbt/ is being used in a non-SpiderMonkey/Gecko context? #ifdef MOZ_HAS_MOZGLUE ___ dev-platform mailing list

Re: Non-header-only headers shared between SpiderMonkey and the rest of Gecko

2019-08-06 Thread Henri Sivonen
On Tue, Aug 6, 2019 at 10:15 AM Henri Sivonen wrote: > In general, it seems problematic to organize headers based on whether > they have associated .cpp or crate code. I'd expect developers to look > for stuff under mfbt/ instead of some place else, since developers > using the header shouldn't

Re: Non-header-only headers shared between SpiderMonkey and the rest of Gecko

2019-08-06 Thread Henri Sivonen
On Mon, Aug 5, 2019 at 4:14 PM Gabriele Svelto wrote: > On 05/08/19 12:04, Henri Sivonen wrote: > > I has come to my attention that that putting non-header-only code > > under mfbt/ is something we're trying to get away from: > > https://bugzilla.mozilla.org/show_bug.cgi?id=1554062 > > > > Do we

Non-header-only headers shared between SpiderMonkey and the rest of Gecko

2019-08-05 Thread Henri Sivonen
I has come to my attention that that putting non-header-only code under mfbt/ is something we're trying to get away from: https://bugzilla.mozilla.org/show_bug.cgi?id=1554062 Do we have an appropriate place for headers that declare entry points for non-header-only functionality (in my case,