Re: PSA: Array.prototype.contains is going away again

2014-10-02 Thread Philip Chee
On 02/10/2014 00:52, Till Schneidereit wrote: Unfortunately, it turns out that Array.prototype.contains breaks the web. Or, the MooTools-using parts of the web, at least. So I'm preparing a backout right now. Can we not reach out to the MooTools people and work together unbreak the web?

Re: PSA: Array.prototype.contains is going away again

2014-10-02 Thread James Graham
On 02/10/14 09:06, Philip Chee wrote: On 02/10/2014 00:52, Till Schneidereit wrote: Unfortunately, it turns out that Array.prototype.contains breaks the web. Or, the MooTools-using parts of the web, at least. So I'm preparing a backout right now. Can we not reach out to the MooTools people

Re: PSA: Array.prototype.contains is going away again

2014-10-02 Thread David Rajchenbach-Teller
Is there even a solution to that problem? Could, say, `Array.prototype.contains` be instantiated lazily when called and only if no `Array.prototype.contains` has been defined by web code? On 02/10/14 10:49, James Graham wrote: Unfortunately js libraries aren't like web browsers; you can't just

Re: PSA: Array.prototype.contains is going away again

2014-10-02 Thread Philip Chee
On 02/10/2014 17:30, David Rajchenbach-Teller wrote: On 02/10/14 10:49, James Graham wrote: Unfortunately js libraries aren't like web browsers; you can't just ship a new version and upgrade all existing users in a matter of weeks. Instead usage of the broken versions may continue for years,

Re: PSA: Array.prototype.contains is going away again

2014-10-02 Thread Till Schneidereit
On Thu, Oct 2, 2014 at 2:24 PM, Philip Chee philip.c...@gmail.com wrote: On 02/10/2014 17:30, David Rajchenbach-Teller wrote: On 02/10/14 10:49, James Graham wrote: Unfortunately js libraries aren't like web browsers; you can't just ship a new version and upgrade all existing users in a

Re: PSA: Array.prototype.contains is going away again

2014-10-02 Thread Till Schneidereit
On Wed, Oct 1, 2014 at 7:51 PM, Ehsan Akhgari ehsan.akhg...@gmail.com wrote: On 2014-10-01, 1:20 PM, Till Schneidereit wrote: That's a great point. It would be great if we can adopt https://wiki.mozilla.org/WebAPI/ExposureGuidelines for new JS fatures as well. Yes, I think we

Re: PSA: Array.prototype.contains is going away again

2014-10-02 Thread Ehsan Akhgari
On 2014-10-02, 9:58 AM, Till Schneidereit wrote: On Wed, Oct 1, 2014 at 7:51 PM, Ehsan Akhgari ehsan.akhg...@gmail.com mailto:ehsan.akhg...@gmail.com wrote: On 2014-10-01, 1:20 PM, Till Schneidereit wrote: That's a great point. It would be great if we can adopt

Re: PSA: Array.prototype.contains is going away again

2014-10-02 Thread Bobby Holley
On Thu, Oct 2, 2014 at 4:51 PM, Ehsan Akhgari ehsan.akhg...@gmail.com wrote: (Of course, I have no idea whether you'd be OK with just calling the Preferences API inside the js code or if we need to invent some kind of a way to mask that away, and just pass the necessary info into the JS engine

Re: PSA: Array.prototype.contains is going away again

2014-10-02 Thread Till Schneidereit
On Thu, Oct 2, 2014 at 4:51 PM, Ehsan Akhgari ehsan.akhg...@gmail.com wrote: On 2014-10-02, 9:58 AM, Till Schneidereit wrote: The full answer to that is actually ridiculously complicated. The part relevant here is, though: very early on in at least some cases. Too early to rely on

Re: PSA: Array.prototype.contains is going away again

2014-10-02 Thread Boris Zbarsky
On 10/2/14, 4:06 AM, Philip Chee wrote: Can we not reach out to the MooTools people and work together unbreak the web? Already done. Now you just have to get the several million sites using old MooTools versions to update. -Boris ___ dev-platform

PSA: Array.prototype.contains is going away again

2014-10-01 Thread Till Schneidereit
Unfortunately, it turns out that Array.prototype.contains breaks the web. Or, the MooTools-using parts of the web, at least. So I'm preparing a backout right now. What's more pressingly unfortunate is that Array.prototype.contains enjoys a surprisingly spectacular popularity: it's already used in

Re: PSA: Array.prototype.contains is going away again

2014-10-01 Thread Ehsan Akhgari
On Wed, Oct 1, 2014 at 12:52 PM, Till Schneidereit t...@tillschneidereit.net wrote: Unfortunately, it turns out that Array.prototype.contains breaks the web. Or, the MooTools-using parts of the web, at least. So I'm preparing a backout right now. What's more pressingly unfortunate is that

Re: PSA: Array.prototype.contains is going away again

2014-10-01 Thread Till Schneidereit
That's a great point. It would be great if we can adopt https://wiki.mozilla.org/WebAPI/ExposureGuidelines for new JS fatures as well. Yes, I think we should consider that. The situation is somewhat different in that we usually only implement features that are stable, specced, and agreed

Re: PSA: Array.prototype.contains is going away again

2014-10-01 Thread Ehsan Akhgari
On 2014-10-01, 1:20 PM, Till Schneidereit wrote: That's a great point. It would be great if we can adopt https://wiki.mozilla.org/WebAPI/ExposureGuidelines for new JS fatures as well. Yes, I think we should consider that. The situation is somewhat different in that we usually only

Re: PSA: Array.prototype.contains is going away again

2014-10-01 Thread Mike Taylor
On 10/1/14, 11:52, Till Schneidereit wrote: Unfortunately, it turns out that Array.prototype.contains breaks the web. Or, the MooTools-using parts of the web, at least. It looks like apps using Ember.js are affected as well: https://github.com/emberjs/ember.js/issues/5670 -- Mike Taylor Web

Re: PSA: Array.prototype.contains is going away again

2014-10-01 Thread trek . glowacki
The Ember core team is incredibly willing to work with browser developers to make sure whatever aspects of future prototypes we polyfill remain up-to-date with the official current versions of spec and planned releases. This might take a bit of planning/coordination because we're on a 6-week

Re: PSA: Array.prototype.contains is going away again

2014-10-01 Thread wycats
It looks like apps using Ember.js are affected as well: https://github.com/emberjs/ember.js/issues/5670 I would like to clarify that Ember is not actually affected by this. The specific problem was related not simply to an extension of A.p.contains, but also a reliance on that