Hi,

If you've written patches for configure in the past few years to add
some flag to use in mozconfig with `ac_add_options`, you may have seen
that while in most cases, you may do that with `option()`, in some cases,
for weird reasons, you had to use `js_option()`. That's finally not the
case anymore.

If you have patches pending that are using `js_option()`, they will
fail. You just need to replace it with `option()`.

The downside, though, is that these patches may cause subtle problems if
they are uplifted, so if you can avoid uplifting patches adding
`option()` for a few cycles, that would be better (though a quick look
at the history of the beta branch suggests no such patch has ever been
uplifted so far).

The underlying reason why it is finally this way is that when running
configure for Firefox, we now don't run configure again for Spidermonkey. At
least not for the python parts of configure. Hopefully, this makes
configure a little faster. The autoconf parts, however, are still executed.

For the curious, the bugs involved are #1669633 and #1520395.

Cheers,

Mike
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to