Re: PSA: mozilla/unused.h renamed to mozilla/Unused.h

On Sat, Aug 27, 2016 at 7:22 PM, Tim Guan-tin Chien wrote: > Hi :gps, > > The more I read into this, the more I think the hook might not likely fix > things. The hook would reject rename-only commits, but the hook would > likely not reject a rename commit from |foo| to

Re: PSA: mozilla/unused.h renamed to mozilla/Unused.h

Hi :gps, The more I read into this, the more I think the hook might not likely fix things. The hook would reject rename-only commits, but the hook would likely not reject a rename commit from |foo| to |bar| and another rename commit from |bar| to |Foo|. These two commits, as you pointed out,

Re: PSA: mozilla/unused.h renamed to mozilla/Unused.h

Yes, thank you Kan-Ru! On Aug 27, 2016 2:10 PM, "Nick Fitzgerald" wrote: > Thanks Kan-Ru! I've personally tried to include the header with the wrong > case multiple times, so I appreciate this change a lot. > > On Fri, Aug 26, 2016 at 7:54 PM, Kan-Ru Chen

Re: PSA: mozilla/unused.h renamed to mozilla/Unused.h

Thanks Kan-Ru! I've personally tried to include the header with the wrong case multiple times, so I appreciate this change a lot. On Fri, Aug 26, 2016 at 7:54 PM, Kan-Ru Chen wrote: > Hello, > > In Bug 1297276 I landed a patch to rename mozilla/unused.h to > mozilla/Unused.h

Re: PSA: mozilla/unused.h renamed to mozilla/Unused.h

On Sat, Aug 27, 2016 at 9:00 AM, Eric Rescorla wrote: > > On Sat, Aug 27, 2016 at 8:53 AM, Gregory Szorc wrote: > >> >> >> > On Aug 27, 2016, at 07:09, Kan-Ru Chen wrote: >> > >> >> On Sat, Aug 27, 2016, at 11:35 AM, Gregory Szorc wrote: >>

Re: PSA: mozilla/unused.h renamed to mozilla/Unused.h

On Sat, Aug 27, 2016 at 8:53 AM, Gregory Szorc wrote: > > > > On Aug 27, 2016, at 07:09, Kan-Ru Chen wrote: > > > >> On Sat, Aug 27, 2016, at 11:35 AM, Gregory Szorc wrote: > >>> On Fri, Aug 26, 2016 at 8:27 PM, Steve Fink wrote: > >>>

Re: PSA: mozilla/unused.h renamed to mozilla/Unused.h

> On Aug 27, 2016, at 07:09, Kan-Ru Chen wrote: > >> On Sat, Aug 27, 2016, at 11:35 AM, Gregory Szorc wrote: >>> On Fri, Aug 26, 2016 at 8:27 PM, Steve Fink wrote: >>> On 08/26/2016 08:16 PM, Gregory Szorc wrote: > On Aug 26, 2016,

Re: PSA: mozilla/unused.h renamed to mozilla/Unused.h

On Fri, Aug 26, 2016 at 8:16 PM, Gregory Szorc wrote: > What I'm trying to say is thank you for reminding me to implement the > hook. And congratulations on likely being the last person to perform a case > only rename on the repo. > Sarcastic commentary on an innocent

Re: PSA: mozilla/unused.h renamed to mozilla/Unused.h

On Sat, Aug 27, 2016, at 11:35 AM, Gregory Szorc wrote: > On Fri, Aug 26, 2016 at 8:27 PM, Steve Fink wrote: > > > On 08/26/2016 08:16 PM, Gregory Szorc wrote: > > > >> > >> On Aug 26, 2016, at 19:54, Kan-Ru Chen wrote: > >>> > >>> Hello, > >>> > >>> In Bug

Re: PSA: mozilla/unused.h renamed to mozilla/Unused.h

On Fri, Aug 26, 2016 at 8:27 PM, Steve Fink wrote: > On 08/26/2016 08:16 PM, Gregory Szorc wrote: > >> >> On Aug 26, 2016, at 19:54, Kan-Ru Chen wrote: >>> >>> Hello, >>> >>> In Bug 1297276 I landed a patch to rename mozilla/unused.h to >>> mozilla/Unused.h

Re: PSA: mozilla/unused.h renamed to mozilla/Unused.h

On 08/26/2016 08:16 PM, Gregory Szorc wrote: On Aug 26, 2016, at 19:54, Kan-Ru Chen wrote: Hello, In Bug 1297276 I landed a patch to rename mozilla/unused.h to mozilla/Unused.h to make it more consistent with our other MFBT headers. Normally rename a header shouldn't

Re: PSA: mozilla/unused.h renamed to mozilla/Unused.h

> On Aug 26, 2016, at 19:54, Kan-Ru Chen wrote: > > Hello, > > In Bug 1297276 I landed a patch to rename mozilla/unused.h to > mozilla/Unused.h to make it more consistent with our other MFBT headers. > Normally rename a header shouldn't cause too much trouble, however this

PSA: mozilla/unused.h renamed to mozilla/Unused.h

Hello, In Bug 1297276 I landed a patch to rename mozilla/unused.h to mozilla/Unused.h to make it more consistent with our other MFBT headers. Normally rename a header shouldn't cause too much trouble, however this rename is only changing the case so you might experience some problems on case