Re: Please don't use functions from ctype.h and strings.h

2020-06-26 Thread Jason Orendorff
This turns out to be super easy to do in clang-tidy, so I took bug 1485588. -j On Wed, Jun 24, 2020 at 2:35 PM Chris Peterson wrote: > On 8/27/2018 7:00 AM, Henri Sivonen wrote: > > I think it's worthwhile to have a lint, but regexps are likely to have > > false positives, so using clang-tidy

Re: Please don't use functions from ctype.h and strings.h

2020-06-25 Thread Henri Sivonen
On Wed, Jun 24, 2020 at 10:35 PM Chris Peterson wrote: > > On 8/27/2018 7:00 AM, Henri Sivonen wrote: > > I think it's worthwhile to have a lint, but regexps are likely to have > > false positives, so using clang-tidy is probably better. > > > > A bug is on

Re: Please don't use functions from ctype.h and strings.h

2020-06-24 Thread Chris Peterson
On 8/27/2018 7:00 AM, Henri Sivonen wrote: I think it's worthwhile to have a lint, but regexps are likely to have false positives, so using clang-tidy is probably better. A bug is on file:https://bugzilla.mozilla.org/show_bug.cgi?id=1485588 On Mon, Aug 27, 2018 at 4:06 PM, Tom Ritter wrote:

Re: Please don't use locale-dependent C standard library functions (was: Re: Please don't use functions from ctype.h and strings.h)

2020-06-15 Thread Frederik Braun
day's example is strerr(), which returns a string that is meant to >> be rendered to the user, but the string isn't guaranteed to be UTF-8. >> >> On Mon, Aug 27, 2018 at 3:04 PM Henri Sivonen wrote: >>> >>> Please don't use the functions from ctype.h and string

Re: Please don't use locale-dependent C standard library functions (was: Re: Please don't use functions from ctype.h and strings.h)

2020-06-12 Thread Jeff Gilbert
is strerr(), which returns a string that is meant to > be rendered to the user, but the string isn't guaranteed to be UTF-8. > > On Mon, Aug 27, 2018 at 3:04 PM Henri Sivonen wrote: > > > > Please don't use the functions from ctype.h and strings.h. > > > > See:

Please don't use locale-dependent C standard library functions (was: Re: Please don't use functions from ctype.h and strings.h)

2020-06-12 Thread Henri Sivonen
, Aug 27, 2018 at 3:04 PM Henri Sivonen wrote: > > Please don't use the functions from ctype.h and strings.h. > > See: > https://daniel.haxx.se/blog/2018/01/30/isalnum-is-not-my-friend/ > https://daniel.haxx.se/blog/2008/10/15/strcasecmp-in-turkish/ > https://stackoverflow.com/

Re: Please don't use functions from ctype.h and strings.h

2018-08-27 Thread Henri Sivonen
mingw-capitalization.yml > https://searchfox.org/mozilla-central/source/tools/lint/cpp/mingw-capitalization.py > > -tom > > On Mon, Aug 27, 2018 at 7:04 AM, Henri Sivonen wrote: >> >> Please don't use the functions from ctype.h and strings.h. >> >> See: >

Re: Please don't use functions from ctype.h and strings.h

2018-08-27 Thread Tom Ritter
/lint/mingw-capitalization.yml https://searchfox.org/mozilla-central/source/tools/lint/cpp/mingw-capitalization.py -tom On Mon, Aug 27, 2018 at 7:04 AM, Henri Sivonen wrote: > Please don't use the functions from ctype.h and strings.h. > > See: > https://daniel.haxx.se/blog/2018/0

Please don't use functions from ctype.h and strings.h

2018-08-27 Thread Henri Sivonen
Please don't use the functions from ctype.h and strings.h. See: https://daniel.haxx.se/blog/2018/01/30/isalnum-is-not-my-friend/ https://daniel.haxx.se/blog/2008/10/15/strcasecmp-in-turkish/ https://stackoverflow.com/questions/2898228/can-isdigit-legitimately-be-locale-dependent-in-c In addition