Re: Removing --enable-shared-js [Was: Rust and --enable-shared-js]

2019-08-14 Thread Henri Sivonen
On Tue, Aug 13, 2019 at 2:18 PM Lars Hansen wrote: > Cranelift should be genuinely optional until further notice; to my > knownledge, no near-term product work in Firefox or SpiderMonkey depends on > Cranelift. Cranelift is present in Nightly but (so far as I can tell) not in > Release. It can

Re: Removing --enable-shared-js [Was: Rust and --enable-shared-js]

2019-08-13 Thread Lars Hansen
Cranelift should be genuinely optional until further notice; to my knownledge, no near-term product work in Firefox or SpiderMonkey depends on Cranelift. Cranelift is present in Nightly but (so far as I can tell) not in Release. It can be disabled in the JS shell by configuring with --disable-cran

Re: Removing --enable-shared-js [Was: Rust and --enable-shared-js]

2019-08-07 Thread Henri Sivonen
On Tue, May 28, 2019 at 3:16 AM Mike Hommey wrote: > > On Tue, May 21, 2019 at 10:32:20PM -0400, Boris Zbarsky wrote: > > On 5/21/19 9:55 PM, Mike Hommey wrote: > > > Considering this has apparently been broken for so long, I guess nobody > > > will object to me removing the option for Gecko build

Re: Removing --enable-shared-js [Was: Rust and --enable-shared-js]

2019-05-27 Thread Mike Hommey
On Tue, May 21, 2019 at 10:32:20PM -0400, Boris Zbarsky wrote: > On 5/21/19 9:55 PM, Mike Hommey wrote: > > Considering this has apparently been broken for so long, I guess nobody > > will object to me removing the option for Gecko builds? > > It's probably fine, yeah... Now removed on autoland v

Re: Removing --enable-shared-js [Was: Rust and --enable-shared-js]

2019-05-21 Thread Boris Zbarsky
On 5/21/19 9:55 PM, Mike Hommey wrote: Considering this has apparently been broken for so long, I guess nobody will object to me removing the option for Gecko builds? It's probably fine, yeah... -Boris ___ dev-platform mailing list dev-platform@lists

Removing --enable-shared-js [Was: Rust and --enable-shared-js]

2019-05-21 Thread Mike Hommey
Hi, I'm revisiting the topic of --enable-shared-js for Gecko builds for different reasons than the one that started this thread. On Mon, Sep 24, 2018 at 08:24:43AM -0400, Boris Zbarsky wrote: > My use case for it is to be able to use the "exclude samples from library X" > or "collapse library X"

Re: Rust and --enable-shared-js

2018-10-03 Thread Mike Hommey
On Tue, Oct 02, 2018 at 03:25:04PM +0300, Henri Sivonen wrote: > On Mon, Sep 24, 2018 at 3:24 PM, Boris Zbarsky wrote: > > On 9/24/18 4:04 AM, Henri Sivonen wrote: > >> > >> How important is --enable-shared-js? I gather its use case is making > >> builds faster for SpiderMonkey developers. > > > >

Re: Rust and --enable-shared-js

2018-10-02 Thread Luke Wagner
(Sorry, I polled #jsapi about this issue back when you first posted and then forgot to reply with the response.) It doesn't seem like any SM devs use --enable-shared-js for their own development but we do know that various embedders (e.g. GNOME) use the JS shared library and so we'd like to keep t

Re: Rust and --enable-shared-js

2018-10-02 Thread Henri Sivonen
On Mon, Sep 24, 2018 at 3:24 PM, Boris Zbarsky wrote: > On 9/24/18 4:04 AM, Henri Sivonen wrote: >> >> How important is --enable-shared-js? I gather its use case is making >> builds faster for SpiderMonkey developers. > > > My use case for it is to be able to use the "exclude samples from library

Re: Rust and --enable-shared-js

2018-09-24 Thread Boris Zbarsky
On 9/24/18 4:04 AM, Henri Sivonen wrote: How important is --enable-shared-js? I gather its use case is making builds faster for SpiderMonkey developers. My use case for it is to be able to use the "exclude samples from library X" or "collapse library X" tools in profilers (like Instruments) t

Re: Rust and --enable-shared-js

2018-09-24 Thread Mike Hommey
On Mon, Sep 24, 2018 at 11:04:43AM +0300, Henri Sivonen wrote: > There's an effort to add Rust code to SpiderMonkey: > https://bugzilla.mozilla.org/show_bug.cgi?id=1490948 > > This will introduce a jsrust_shared crate that will just depend on all > the Rust crates that SpiderMonkey needs like gkru

Rust and --enable-shared-js

2018-09-24 Thread Henri Sivonen
There's an effort to add Rust code to SpiderMonkey: https://bugzilla.mozilla.org/show_bug.cgi?id=1490948 This will introduce a jsrust_shared crate that will just depend on all the Rust crates that SpiderMonkey needs like gkrust_shared depends on the crates the rest of Gecko needs. This is fine bo