Re: Rust code in mozilla-central now builds via cargo

[Henri Sivonen]

On Aug 8, 2016 1:06 AM, "Nathan Froyd"  wrote:
>
> TL; DR: Bug 1231764 has landed on mozilla-central; the build system
> now invokes cargo to build all the Rust code in m-c.  This should
> result in a better Rust developer experience, as well as making it
> easier to import Rust libraries into m-c.

\o/

> The e10s crate must also be checked into the tree at the appropriate
> path.

Are there technical constraints (upcoming arising from the behavior of
cargo vendor maybe?) or guidelines that one should be aware of when
choosing a location for a crate in m-c?
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Rust code in mozilla-central now builds via cargo

[Bobby Holley]

On Mon, Aug 8, 2016 at 12:15 PM, Michael Layzell 
wrote:

> Thanks a ton for your work on this! This makes working on rust code in
> gecko much easier, and makes importing libraries from the ecosystem simpler
> as well (if a tad tedious).
>

Importing libraries from the ecosystem is going to get a lot easier soon
with the introduction of |cargo vendor|. Stay tuned.


>
> On Mon, Aug 8, 2016 at 1:21 PM, Bobby Holley 
> wrote:
>
>> +1. This is an important step forward. Thanks Nathan!
>>
>> On Mon, Aug 8, 2016 at 6:07 AM, Ted Mielczarek 
>> wrote:
>>
>> > On Sun, Aug 7, 2016, at 06:06 PM, Nathan Froyd wrote:
>> > > TL; DR: Bug 1231764 has landed on mozilla-central; the build system
>> > > now invokes cargo to build all the Rust code in m-c.  This should
>> > > result in a better Rust developer experience, as well as making it
>> > > easier to import Rust libraries into m-c.
>> >
>> > Thanks so much for all your hard work on this! This is going to make a
>> > huge difference to the future of Firefox and Gecko.
>> >
>> > -Ted
>> > ___
>> > dev-platform mailing list
>> > dev-platform@lists.mozilla.org
>> > https://lists.mozilla.org/listinfo/dev-platform
>> >
>> ___
>> dev-platform mailing list
>> dev-platform@lists.mozilla.org
>> https://lists.mozilla.org/listinfo/dev-platform
>>
>
>
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Rust code in mozilla-central now builds via cargo

[Michael Layzell]

Thanks a ton for your work on this! This makes working on rust code in
gecko much easier, and makes importing libraries from the ecosystem simpler
as well (if a tad tedious).

On Mon, Aug 8, 2016 at 1:21 PM, Bobby Holley  wrote:

> +1. This is an important step forward. Thanks Nathan!
>
> On Mon, Aug 8, 2016 at 6:07 AM, Ted Mielczarek  wrote:
>
> > On Sun, Aug 7, 2016, at 06:06 PM, Nathan Froyd wrote:
> > > TL; DR: Bug 1231764 has landed on mozilla-central; the build system
> > > now invokes cargo to build all the Rust code in m-c.  This should
> > > result in a better Rust developer experience, as well as making it
> > > easier to import Rust libraries into m-c.
> >
> > Thanks so much for all your hard work on this! This is going to make a
> > huge difference to the future of Firefox and Gecko.
> >
> > -Ted
> > ___
> > dev-platform mailing list
> > dev-platform@lists.mozilla.org
> > https://lists.mozilla.org/listinfo/dev-platform
> >
> ___
> dev-platform mailing list
> dev-platform@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-platform
>
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Rust code in mozilla-central now builds via cargo

[Bobby Holley]

+1. This is an important step forward. Thanks Nathan!

On Mon, Aug 8, 2016 at 6:07 AM, Ted Mielczarek  wrote:

> On Sun, Aug 7, 2016, at 06:06 PM, Nathan Froyd wrote:
> > TL; DR: Bug 1231764 has landed on mozilla-central; the build system
> > now invokes cargo to build all the Rust code in m-c.  This should
> > result in a better Rust developer experience, as well as making it
> > easier to import Rust libraries into m-c.
>
> Thanks so much for all your hard work on this! This is going to make a
> huge difference to the future of Firefox and Gecko.
>
> -Ted
> ___
> dev-platform mailing list
> dev-platform@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-platform
>
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Rust code in mozilla-central now builds via cargo

[Nathan Froyd]

On Mon, Aug 8, 2016 at 6:41 AM, Andreas Tolfsen  wrote:
> This is great, but as of pulling central this morning I can’t build
> because configure complains about missing cargo.  I’ve filed
> https://bugzilla.mozilla.org/show_bug.cgi?id=1293219 about this.

Thanks for the report, I'll take a look.  I can't seem to reproduce,
but I will investigate.

If other people are running into this, posting your mozconfig,
configure output, and $OBJDIR/config.log in the bug would be helpful.

> It doesn’t make a difference if I remove `ac_add_options
> --enable-rust`, but I guess this might now be deprecated?

For avoidance of doubt: it was not the intent of this patchset to make
--enable-rust mandatory.  We're not to that point (yet).

-Nathan
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Rust code in mozilla-central now builds via cargo

[Ted Mielczarek]

On Sun, Aug 7, 2016, at 06:06 PM, Nathan Froyd wrote:
> TL; DR: Bug 1231764 has landed on mozilla-central; the build system
> now invokes cargo to build all the Rust code in m-c.  This should
> result in a better Rust developer experience, as well as making it
> easier to import Rust libraries into m-c.

Thanks so much for all your hard work on this! This is going to make a
huge difference to the future of Firefox and Gecko.

-Ted
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Rust code in mozilla-central now builds via cargo

[Andreas Tolfsen]

Nathan,

Nathan Froyd  writes:

> TL; DR: Bug 1231764 has landed on mozilla-central; the build system
> now invokes cargo to build all the Rust code in m-c.  This should
> result in a better Rust developer experience, as well as making it
> easier to import Rust libraries into m-c.

This is great, but as of pulling central this morning I can’t build
because configure complains about missing cargo.  I’ve filed
https://bugzilla.mozilla.org/show_bug.cgi?id=1293219 about this.

It doesn’t make a difference if I remove `ac_add_options
--enable-rust`, but I guess this might now be deprecated?
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform