Re: Single- vs. double-precision FP in gfx types

2016-01-04 Thread Nicholas Nethercote
On Wed, Dec 9, 2015 at 3:49 PM, Nicholas Nethercote wrote: >> >> One interesting thing I found is that a *lot* of the functions that >> take an nsRenderingContext or gfxContext do so because they end up >> passing it into text run code -- gfxTextRun uses a gfxContext, via

Re: Single- vs. double-precision FP in gfx types

2015-12-09 Thread Nicholas Nethercote
On Tue, Dec 8, 2015 at 4:34 PM, Nicholas Nethercote wrote: > > One interesting thing I found is that a *lot* of the functions that > take an nsRenderingContext or gfxContext do so because they end up > passing it into text run code -- gfxTextRun uses a gfxContext, via >

Re: Single- vs. double-precision FP in gfx types

2015-12-09 Thread Nicholas Nethercote
On Wed, Dec 9, 2015 at 3:49 PM, Nicholas Nethercote wrote: >> >> One interesting thing I found is that a *lot* of the functions that >> take an nsRenderingContext or gfxContext do so because they end up >> passing it into text run code -- gfxTextRun uses a gfxContext, via

Re: Single- vs. double-precision FP in gfx types

2015-12-08 Thread Nicholas Nethercote
On Tue, Nov 24, 2015 at 7:05 PM, Robert O'Callahan wrote: >> >> It still seems like, where possible, we should switch from passing >> around an nsRenderingContext or a gfxContext to passing around a >> DrawTarget. (Presumably starting from leaf functions and moving >> up.)

Re: Single- vs. double-precision FP in gfx types

2015-11-24 Thread Robert O'Callahan
On Wed, Nov 25, 2015 at 11:59 AM, Nicholas Nethercote < n.netherc...@gmail.com> wrote: > On Mon, Nov 23, 2015 at 8:14 PM, Robert O'Callahan > wrote: > >> > >> One major remaining Moz2Dification step is the conversion of thebes > >> types such as gfxSize, gfxPoint, gfxRect,

Re: Single- vs. double-precision FP in gfx types

2015-11-24 Thread Nicholas Nethercote
On Mon, Nov 23, 2015 at 8:14 PM, Robert O'Callahan wrote: >> >> One major remaining Moz2Dification step is the conversion of thebes >> types such as gfxSize, gfxPoint, gfxRect, and gfxMatrix to their Moz2D >> equivalents. > > I think for now we should focus on replacing

Re: Single- vs. double-precision FP in gfx types

2015-11-24 Thread L. David Baron
On Wednesday 2015-11-25 12:49 +1300, Robert O'Callahan wrote: > On Wed, Nov 25, 2015 at 11:59 AM, Nicholas Nethercote < > n.netherc...@gmail.com> wrote: > > > On Mon, Nov 23, 2015 at 8:14 PM, Robert O'Callahan > > wrote: > > >> > > >> One major remaining Moz2Dification step

Re: Single- vs. double-precision FP in gfx types

2015-11-24 Thread L. David Baron
On Tuesday 2015-11-24 18:21 -0800, L. David Baron wrote: > Presumably it's equally important to replace the remaining > nsRenderingContext usage with DrawTarget? > > (nsRenderingContext was the previous API before gfxContext.) Er, never mind; I guess that's sort of a stupid question at this

Re: Single- vs. double-precision FP in gfx types

2015-11-24 Thread Robert O'Callahan
On Wed, Nov 25, 2015 at 3:24 PM, L. David Baron wrote: > On Tuesday 2015-11-24 18:21 -0800, L. David Baron wrote: > > Presumably it's equally important to replace the remaining > > nsRenderingContext usage with DrawTarget? > > > > (nsRenderingContext was the previous API

Re: Single- vs. double-precision FP in gfx types

2015-11-23 Thread Robert O'Callahan
On Tue, Nov 24, 2015 at 4:45 PM, Nicholas Nethercote wrote: > One major remaining Moz2Dification step is the conversion of thebes > types such as gfxSize, gfxPoint, gfxRect, and gfxMatrix to their Moz2D > equivalents. But this is largely blocked by the fact that the

Single- vs. double-precision FP in gfx types

2015-11-23 Thread Nicholas Nethercote
Hi, One major remaining Moz2Dification step is the conversion of thebes types such as gfxSize, gfxPoint, gfxRect, and gfxMatrix to their Moz2D equivalents. But this is largely blocked by the fact that the thebes types use double-precision FP values while the Moz2D types use single-precision FP