Re: Stylesheet wait timeout?

2017-09-03 Thread Boris Zbarsky
On 9/3/17 1:04 PM, Kris Maglione wrote: The first layout flush here is happening when we focus an autofocus form field. That's longstanding https://bugzilla.mozilla.org/show_bug.cgi?id=1155812 and https://bugzilla.mozilla.org/show_bug.cgi?id=712130 -Boris

Re: Stylesheet wait timeout?

2017-09-03 Thread Kris Maglione
On Sun, Sep 03, 2017 at 12:40:04PM -0400, Dustin Mitchell wrote: I just reproduced it with a random page from my history: https://github.com/taskcluster/taskcluster-cli/issues/49. Any github page will do, and it seems to have to do with caching. if I delete today's history, I can reproduce. An

Re: Stylesheet wait timeout?

2017-09-03 Thread Dustin Mitchell
Oops, the profile is from a *different* random github page from my history, sorry for any confusion. 2017-09-03 12:40 GMT-04:00 Dustin Mitchell : > I just reproduced it with a random page from my history: > https://github.com/taskcluster/taskcluster-cli/issues/49. Any github > page will do, and i

Re: Stylesheet wait timeout?

2017-09-03 Thread Dustin Mitchell
I just reproduced it with a random page from my history: https://github.com/taskcluster/taskcluster-cli/issues/49. Any github page will do, and it seems to have to do with caching. if I delete today's history, I can reproduce. And with a repro recipe, I can capture a profile -- https://perfht.ml

Re: Stylesheet wait timeout?

2017-09-02 Thread Panos Astithas
On Fri, Sep 1, 2017 at 7:37 PM, Boris Zbarsky wrote: > I reported this issue to them (copy/paste of my report below) through the > form at https://ghostery.zendesk.com/hc/en-us/requests/new but if someone > has better contact info that might be nice. > I have forwarded your message to my contact

Re: Stylesheet wait timeout?

2017-09-02 Thread Boris Zbarsky
On 9/2/17 8:43 AM, Dustin Mitchell wrote: The flashes (just saw another a moment ago) are on github.com. On which exact page(s), if I might ask? For reproducing this sort of thing details matter, so if you know what exact URL you saw it on that would be very helpful. -Boris ___

Re: Stylesheet wait timeout?

2017-09-02 Thread Dustin Mitchell
I haven't distinguished between those two options -- I was making the point that Ghostery isn't (exclusively) to blame. Yes, it's that test pilot. The flashes (just saw another a moment ago) are on github.com. Dustin 2017-09-01 17:01 GMT-04:00 Boris Zbarsky : > On 9/1/17 10:15 AM, Dustin Mitche

Re: Stylesheet wait timeout?

2017-09-01 Thread Kris Maglione
On Fri, Sep 01, 2017 at 11:32:43PM +0200, Anthony Ricaud wrote: I have no idea if this is feasible but could we prevent extensions from performing synchronous layout flushes before layout has started? If this is possible, extensions that need to perform them could require a new permission? It

Re: Stylesheet wait timeout?

2017-09-01 Thread Anthony Ricaud
I have no idea if this is feasible but could we prevent extensions from performing synchronous layout flushes before layout has started? If this is possible, extensions that need to perform them could require a new permission? Another alternative, can we prevent extensions from injecting content

Re: Stylesheet wait timeout?

2017-09-01 Thread Boris Zbarsky
On 9/1/17 10:15 AM, Dustin Mitchell wrote: I can narrow that bisection down to two sets: [test-pilot] and []. So test-pilot is causing the flash of unstyled content in your case? I assume this is the addon at https://testpilot.firefox.com/ ? What pages are you seeing the flash of unstyled c

Re: Stylesheet wait timeout?

2017-09-01 Thread Ehsan Akhgari
FWIW I filed https://bugzil.la/1396097 for adding a console warning which would have warned about this specific case. On 09/01/2017 12:37 PM, Boris Zbarsky wrote: On 8/31/17 3:00 PM, Michael Froman wrote: If I disable Ghostery, it no long appears to happen for me. YMMV. Michael, Thank you

Re: Stylesheet wait timeout?

2017-09-01 Thread Kris Maglione
On Fri, Sep 01, 2017 at 10:52:30AM -0400, Ehsan Akhgari wrote: On 09/01/2017 09:54 AM, Boris Zbarsky wrote: On 9/1/17 7:02 AM, Gervase Markham wrote: Restarting with no extensions causes my browser to feel a whole lot faster (I'd love to know why that is, but that's a separate issue!) Worth t

Re: Stylesheet wait timeout?

2017-09-01 Thread Boris Zbarsky
On 8/31/17 3:00 PM, Michael Froman wrote: If I disable Ghostery, it no long appears to happen for me. YMMV. Michael, Thank you. So with Ghostery installed, I managed to reproduce a flash of unstyled content when doing a force-reload of https://github.com/servo/servo That's because Ghoste

Re: Stylesheet wait timeout?

2017-09-01 Thread Ehsan Akhgari
On 09/01/2017 09:54 AM, Boris Zbarsky wrote: On 9/1/17 7:02 AM, Gervase Markham wrote: Restarting with no extensions causes my browser to feel a whole lot faster (I'd love to know why that is, but that's a separate issue!) Worth trying to bisect on the extensions to figure this out... Or alter

Re: Stylesheet wait timeout?

2017-09-01 Thread Dustin Mitchell
I can narrow that bisection down to two sets: [test-pilot] and []. Dustin 2017-09-01 9:54 GMT-04:00 Boris Zbarsky : > On 9/1/17 7:02 AM, Gervase Markham wrote: >> >> Restarting with no extensions causes my browser to feel a whole lot >> faster (I'd love to know why that is, but that's a separate

Re: Stylesheet wait timeout?

2017-09-01 Thread Boris Zbarsky
On 9/1/17 7:02 AM, Gervase Markham wrote: Restarting with no extensions causes my browser to feel a whole lot faster (I'd love to know why that is, but that's a separate issue!) Worth trying to bisect on the extensions to figure this out... but I can't reproduce the FOUC in a few minutes of t

Re: Stylesheet wait timeout?

2017-09-01 Thread Gervase Markham
On 31/08/17 19:08, Boris Zbarsky wrote: > The symptoms you observe sound like (A) is happening, possible from an > extension or our browser UI...  If you have a link to a specific url > that reproduces for you, especially in a clean profile, that would be > pretty useful.  This is usually pretty si

Re: Stylesheet wait timeout?

2017-09-01 Thread Gervase Markham
On 31/08/17 20:00, Michael Froman wrote: > I’ve seen this behavior too on OSX. I did a restart with all add-ons > disabled and could not reproduce. Restarted with all add-ons on, and > can reproduce. I narrowed it down to Ghostery. If I disable > Ghostery, it no long appears to happen for me.

Re: Stylesheet wait timeout?

2017-09-01 Thread Gervase Markham
On 31/08/17 18:45, Chris Peterson wrote: > Gerv, do you have Stylo enabled? Even if you did not flip the pref > (layout.css.servo.enabled), you might be in the Stylo experiment for > Nightly users. Check about:support for "Stylo". about:support says "Stylo: true (enabled by default)". Gerv _

Re: Stylesheet wait timeout?

2017-08-31 Thread Boris Zbarsky
On 8/31/17 3:27 PM, Jet Villegas wrote: FWIW, reverting the fix for bug 1283302 (fixed in FF53) fixes this issue. Before that fix, we would wait up to 250ms before painting To be clear, this is 250ms _after_ the layout-starting I described in my previous post. The general point remains: if y

Re: Stylesheet wait timeout?

2017-08-31 Thread Jet Villegas
FWIW, reverting the fix for bug 1283302 (fixed in FF53) fixes this issue. Before that fix, we would wait up to 250ms before painting, now we wait for 5ms. You may be running into the intersection of that change, plus several performance fixes that make us paint much faster in FF57. When we fixed 12

Re: Stylesheet wait timeout?

2017-08-31 Thread Kris Maglione
On Thu, Aug 31, 2017 at 02:00:49PM -0500, Michael Froman wrote: I’ve seen this behavior too on OSX. I did a restart with all add-ons disabled and could not reproduce. Restarted with all add-ons on, and can reproduce. I narrowed it down to Ghostery. If I disable Ghostery, it no long appears

Re: Stylesheet wait timeout?

2017-08-31 Thread Dustin Mitchell
I've seen it a few times now since this thread began. I had Ghostery installed but removed it a few days ago. I only have whimsy (disabled) and test pilot installed. Dustin 2017-08-31 15:00 GMT-04:00 Michael Froman : > >> On Aug 31, 2017, at 1:08 PM, Boris Zbarsky wrote: >> >> The symptoms yo

Re: Stylesheet wait timeout?

2017-08-31 Thread Michael Froman
> On Aug 31, 2017, at 1:08 PM, Boris Zbarsky wrote: > > The symptoms you observe sound like (A) is happening, possible from an > extension or our browser UI... If you have a link to a specific url that > reproduces for you, especially in a clean profile, that would be pretty > useful. This

Re: Stylesheet wait timeout?

2017-08-31 Thread Honza Bambas
On 8/31/17 8:00 PM, Chris Peterson wrote: Maybe this is stylesheet delay is related to Context Driven Priority (CDP) project that changes how network requests are prioritized? https://bugzilla.mozilla.org/show_bug.cgi?id=CDP CSS preload requests (made by html parser when is hit) are left as

Re: Stylesheet wait timeout?

2017-08-31 Thread Simon Sapin
On 31/08/2017 19:45, Chris Peterson wrote: Gerv, do you have Stylo enabled? Even if you did not flip the pref (layout.css.servo.enabled), you might be in the Stylo experiment for Nightly users. Check about:support for "Stylo". I’ve also seen many more "flashes of unstyled content" than usual la

Re: Stylesheet wait timeout?

2017-08-31 Thread Boris Zbarsky
On 8/31/17 1:24 PM, Gervase Markham wrote: Have we changed the timeout recently regarding how long Firefox waits for a stylesheet before rendering the page? We do not have such a timeout at all. Our wait is fairly deterministic. We start layout as soon as: A) Script requests layout informa

Re: Stylesheet wait timeout?

2017-08-31 Thread Chris Peterson
Maybe this is stylesheet delay is related to Context Driven Priority (CDP) project that changes how network requests are prioritized? https://bugzilla.mozilla.org/show_bug.cgi?id=CDP On 2017-08-31 10:46 AM, Dustin Mitchell wrote: I've been seeing this, too, often on github pages. I do not ha

Re: Stylesheet wait timeout?

2017-08-31 Thread Dustin Mitchell
I've been seeing this, too, often on github pages. I do not have stylo enabled per about:support ("false (disabled by default)"). Dustin 2017-08-31 13:45 GMT-04:00 Chris Peterson : > Gerv, do you have Stylo enabled? Even if you did not flip the pref > (layout.css.servo.enabled), you might be in

Re: Stylesheet wait timeout?

2017-08-31 Thread Chris Peterson
Gerv, do you have Stylo enabled? Even if you did not flip the pref (layout.css.servo.enabled), you might be in the Stylo experiment for Nightly users. Check about:support for "Stylo". On 2017-08-31 10:24 AM, Gervase Markham wrote: On 18/08/17 12:11, Gervase Markham wrote: Whereas what I me

Re: Stylesheet wait timeout?

2017-08-31 Thread Gervase Markham
On 18/08/17 12:11, Gervase Markham wrote: Whereas what I meant to say was: Have we changed the timeout recently regarding how long Firefox waits for a stylesheet before rendering the page? In the past few weeks I've seen many more instances of a page loading unstyled, then re-laying out a second

Stylesheet wait timeout?

2017-08-18 Thread Gervase Markham
___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform